From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6CD3148B7 for ; Wed, 17 Dec 2025 12:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765975050; cv=fail; b=TWjctHKF5/LJdVf2S9TGLGkvBR7zKJm2aXtaDmRj2GBbcd2hCvRt+2ywHtYXVTQwf23zOsMdtvRvKR/FrJn2KpWa5UgO5n1JguQMEd7t9m3VheCcp2OHXWcU/DGXpuWUqZ352WEf8rpQlOliBEahpFsvDZuit6vEqcxCa1l+vQw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765975050; c=relaxed/simple; bh=Znw1ROhsGUOozXtQnHTFHCc9KbaqtpKKFXFcoW7tel0=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=auUk1wMs2wlYdNdlGcU487RCNJwUmpPfbWA/20rkt/AihguA7u1CXcqvW/HT5P/SaaCx5YyEMNe9QdoTUcAEevoC3zYSJ/UiL5ZWEcxLX0p6bJNtvixozRwEKFpN/4S0BZ6aeZIEPZm8t+jk/BcrVztuAHcZBZIvoer4ufmoefA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=fail smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=E6h0xK0Y; arc=fail smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E6h0xK0Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765975048; x=1797511048; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Znw1ROhsGUOozXtQnHTFHCc9KbaqtpKKFXFcoW7tel0=; b=E6h0xK0YIS/H0l1ql7kS7EFPPDif0wfHUUfRctdChj9ocvJHuzkdpvyT JHOFogRz6Tlbbx2u4sExkeeUxzH2U7vOCrjHu39QMo+bLBby6uw0rBBzg B0ORy3EI2nqmWX0vVDNAuDOEWWFmAM5JaefXvaVkfbns2s0ehTrDnoZbR 8g4IdgOrXfJapMpaKBDw/x39k1UrRsnoT5yD/5VFdH3EPF2yQ6FD4i40M pIqmcpg9+iig7rfBETpBFNKWDDv0VEFLJ3ftPnr7ioIvfyup5gJ3xnWox tORUPkIR10PjD6HemCHfCzkgKrOKhdA/MOVbvsPoVF/aIsmBOjf9acVcx w==; X-CSE-ConnectionGUID: 2oUtC4oXTEO1TNpoh6IEPg== X-CSE-MsgGUID: TskFEJZCQeSWXZ54GZQtmw== X-IronPort-AV: E=McAfee;i="6800,10657,11645"; a="67794271" X-IronPort-AV: E=Sophos;i="6.21,155,1763452800"; d="scan'208";a="67794271" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2025 04:37:26 -0800 X-CSE-ConnectionGUID: XymdTXWCQZq54eYywrMm9w== X-CSE-MsgGUID: YGvJv95UTSWMCpeUM6amwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,155,1763452800"; d="scan'208";a="203393070" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2025 04:37:26 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 17 Dec 2025 04:37:25 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Wed, 17 Dec 2025 04:37:25 -0800 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.3) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 17 Dec 2025 04:37:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cTLiUdBNClAlFfCyWrkDfEBUiPyy9aY27ks8VcrNtABVC5o4PVzWxJWfnK98P2tG/AkO+PuXzvFFEZYQ9V2qlYypC4Vr1adh9RpYW3+BM+Zs6g56dQAYj/DKmYad3bdhQ9iXajadiwEhrxqWGjas4qrU10GRxxe4pHPJ7LQt2wm/l4hTAI15rh6BXcGGBvMIBkjE6Wl7tKlmZJ7s4TROBtVn6G8gkqsnFdR6MS4tLGt9RU2MNBs8cPqLYSQSY0JB/8bSE3VSZUW6UNF+tsksU94ErIu+/FI0b6Y1N/WktuUdIOjMLjYLecYPQ9pvQXzS3g3kvhZBpb6rdc/OTNeoXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GCNDmlUt5m6Y5wvkfqt5BeJl0VfDLlgiGJbYqr5EPH0=; b=hvyQC7ixYn0byuSETstkUU9ZMDu84HrrsnDlPQOucdH3V7VoGtvfsvex1mbpDs+M+AKN8vBfcZG7SpjgcbYatEll4fG9F2w+wpvroTBJO1F+0XFiCB2W7+/hLxy4iHoP6h/ib8nmpuw1QuC/mSgmW71lkFDnCdCvpLgvA1WH1JdGPZayAdaF+lEvtkSnBQ447vi3N+sgi0yD9fHqMpaKqc+BfICxRUGqSzaskHre4eyv2oqV6D3Wh6iJyUHOTNf/vHAWXIMVy2KRvLsBm5UTTLenzDjFNo7xG/98Cy4tBeZ9uQudQ8WoI37/Ghr5COOvbSvRibBAsw4bYa6OGq9/aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by BN9PR11MB5322.namprd11.prod.outlook.com (2603:10b6:408:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Wed, 17 Dec 2025 12:37:23 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::4af6:d44e:b6b0:fdce]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::4af6:d44e:b6b0:fdce%4]) with mapi id 15.20.9412.011; Wed, 17 Dec 2025 12:37:22 +0000 Message-ID: <90d1b600-6c95-418d-84af-19604ba9a7d8@intel.com> Date: Wed, 17 Dec 2025 20:37:07 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/23] sched/cache: Track LLC-preferred tasks per runqueue To: Vern Hao CC: Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Madadi Vineeth Reddy , "Hillf Danton" , Shrikanth Hegde , "Jianyong Wu" , Yangyu Chen , Tingyin Duan , Vern Hao , Len Brown , Aubrey Li , Zhao Liu , Chen Yu , Adam Li , Aaron Lu , Tim Chen , , Tim Chen , Peter Zijlstra , "K Prateek Nayak" , "Gautham R . Shenoy" , Vincent Guittot , "Ingo Molnar" References: Content-Language: en-US From: "Chen, Yu C" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: KU2P306CA0013.MYSP306.PROD.OUTLOOK.COM (2603:1096:d10:14::17) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|BN9PR11MB5322:EE_ X-MS-Office365-Filtering-Correlation-Id: 633cc810-30f0-4e6d-eeb6-08de3d690687 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UFYrSk52M0VqQmF5Y3IvQmpCcjVhWFMrQUlaQkgwOW5hVThSeWlxS2dya0lC?= =?utf-8?B?NFE5RlBuVWl5TzZYQzgzUEhYcGFkR056L0lGNmVhdFYyL0RvdHZJMlFib0kr?= =?utf-8?B?d0tBU0xha0ZRUWFsdkgyWDZRRlJxNXBuWVgzZUZsZm9hdHh4TC9JaVFMclpq?= =?utf-8?B?WHBRQzJ4a2JmN2JnanM0RFkyQnVNc0JDR2g3RXp6bXN2SW4xZ1R6Z280QVky?= =?utf-8?B?SCt6R05vRnh3K1JuUTZmNUwyUlFwZStHeHpaWlJDUDFwdUdrSDR6WFgxMlF3?= =?utf-8?B?YVVYeHg2STQ4cUltcmY5OXVFeElPWnhySlhldmFEaElCUk04aUlaS3h3VnFp?= =?utf-8?B?QkxDUWk4bEdGTzlsU1k1Y0VIT1kyK1RsVmo4OUFiNkdBcmxndkkrRDVhbks5?= =?utf-8?B?N1ROYWE1bjBhVnR4OFhhdFhqUkQ0OC9uQUkzR3JsalRIZUpORmFkOFEwS1hW?= =?utf-8?B?TnlabXpTQzdONFQ1Y1Y4TDVuTE5GdVdST29oWG8ycW1QbVF1NWV1eGplL2ZQ?= =?utf-8?B?ZC9DZ1c4TW5KUFI2ck5wdlF2RUVHNVdac0I0eWNERFZ3M2RJaHg4UW5uMHBh?= =?utf-8?B?MmpqMFBSeHBBTHJjaE1UZlVpbmpJMDhTaFZLT1d2TmlHSEkrQzd1d29sd1VU?= =?utf-8?B?cVNycFFVZWZ2QnNoQ3Rqci80a2VybkZuejlnT3JDd3JoUzk4WllmVTJzdGZt?= =?utf-8?B?Q28yYUJWalZPa2ZLOEVGelFjdmhUWmpHSzN0bm10MisyT1dMWVRmM0JKdDNj?= =?utf-8?B?b3UzZTgxZDRyYklkc3d2OHMrTGVTTFVqY0piTVUyUEZ2eGZhanBmSEwxS0U5?= =?utf-8?B?QmxRR1F4dGxSa09FdWdoTUIxeHBraXJpUUQvTGpWNVptZzRqWVNGdU5BSVMx?= =?utf-8?B?Q1hUUm5VRUZzNDJkUUx0Q3lLcjFjalYrWmNoVXBoekhqcWFZSDV4QUlrNGtC?= =?utf-8?B?VVp3dERHRjh1eEFwMzJNVVE0Ykg4VkV1Vi93VlpPSlI5bVU0RWdVbGs5TG0w?= =?utf-8?B?MEJ5SXFlZFUrL2g0TFd2OU1BY2Z5eFlJaUFPYSszeU05azZHYmFDS2lkQWJl?= =?utf-8?B?OVRlWmdwbytQczZjazNKRnFOcktyVHpSdy91aVhtTDFrb3lGcFdqamNMNVZ6?= =?utf-8?B?YlhBZkwyd2IzRlBqT2Q1L3FPa2FhODl3YldabUtNQnRlTW9HT2JxemdSQytL?= =?utf-8?B?L3lpRHZVS0lwdWwxVDgwcnBxb3VyZFRWR0MyKzVFbDNuLytxTHdXQTRRYWta?= =?utf-8?B?TG9DRlhUY2ZheDhnVmgyOXZIT0Q3NW5SRXpIaG9ZLzBoT0tERXNVSE5kajcz?= =?utf-8?B?RnFNQzdyUFd3azBmZkwyM0hUeGNVOHk5b0lEWjFvR1BSVXUyaVZ0REcvbGQ4?= =?utf-8?B?SjVxbVpiWW5TeHRpakF3eGJyZk9pNXVJZW1TbStXUmQ1MzUyT1d1OERSanl4?= =?utf-8?B?QTkwNllPNWdBZUpYdTltKytYZldIVUhJbW95T24yeDRqbkVMb08xb05aMS84?= =?utf-8?B?YVVtek5IWStSeGtCNFVGSGV6bTQ1T0QwSzJhczUwc3U0VW4rb0R3ZWhjSHM2?= =?utf-8?B?STFhNVdhRWpXRjB6TXhSK2FVME9INnJLTmNSdElrQ1FERnl4cFA0dmw0NWFM?= =?utf-8?B?a1MwbEtkRUxOMmRpc29FUWJYRDNGWlNIejdCdFk0eEZ3L0pJT3JQRnMzU3ox?= =?utf-8?B?UzM3MFNjYXkwZnduSXVJL2ozV0JLdW1hczB6N0NXMzRHSE5XdHpTTmhUUmF3?= =?utf-8?B?SDlHQndLVk5YSytYT1FPL0k4Skt4OEhENTlaQzVTbmpBcktpNTRnQzVWcTcv?= =?utf-8?B?WDlrS3lHNEFPUkVLZGhpSlNWd2NWYWVLejU0UVduWmJkbUxyUHBDWDVIOG1O?= =?utf-8?B?a3h0OGFGRHJPNkhvbjRkNGRTcGVRN3MzS09hK2tjZnc5ZEVFaW4rYmdSN3RT?= =?utf-8?Q?6rbEGTBzgGNrhu0WrvHZK2YJ2Rel/Aaa?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OS9uZVFpakFWWHlMWWY5SzRvTytvaUZIQ1NMUGdmNGsxd05TakF3U1pKbEYy?= =?utf-8?B?bVpLWi83d3BiTlFlbnExTnFJUmZ3Q1NyeTVQT0dweEdwaHNCUDdzUzZiWU9q?= =?utf-8?B?U2tOb1hsWE9ZQ2x5ZWpHS3U1UmlnUmo3QzhQclFGZ1dQQzBMQkVlSzk4QVRI?= =?utf-8?B?MGIyL0xIbDdGNUt5ejdwMzRJclczWnB2YmRKelZuc2o4cEZPNkJEeHJZVk5U?= =?utf-8?B?L3ZUYnNwYlZIaWNvODV0UVZBMk0weXpxVTB1TVBmK1pqdmpqb2pNUE1QM0x4?= =?utf-8?B?UlNvdWFsWFlqOEZXY3YwTE9BVEpzV053ZUVHd05sODJ4b29zMnFnU2FJMXlz?= =?utf-8?B?dkhpN24vVU5mNG5zRm5qbkpMRW0rcUh4NXpXdEpRUEF2Q1JLZkNrcDhMcUlv?= =?utf-8?B?WnJaUWxyNm9wMW9Pc3BsZUFib25qdXJyM2FkRThXVnpQbVUrNHVvRlBhVzBE?= =?utf-8?B?NlBGc3JGMnFhL2RTczhyYnZ2QXQxOTJDWEo1NlpzaW1Bb3pkMzA0dXdnemxB?= =?utf-8?B?a1dIaXE4bEtHTm9pcGUvM1VNL1NjTWl2Sk9QTy9vdDg2Z2JqM0o5eTlTTC81?= =?utf-8?B?cjVnY1BVYzJxWjdvQ1JXM2hSanc5VmlIcGRZWFN5YXpHUi9KTG9rV1EvS2gr?= =?utf-8?B?WUloZFhIVGZ3aGFYWlQwaTF4RmNFWnRaa05XWU96YXJ2UmR2cDhrOTFZcGJx?= =?utf-8?B?Q1dlcXROUktkRjFDRFlralh6MXJLZU10WmoveWp0REtJS2tDQU9VbDdMTjU0?= =?utf-8?B?UjJxRGJOeUNubDNLcFIzeHY3eXNDL1lXTjkyVFl3SW5nbXlpUEI0KzFpU2Qr?= =?utf-8?B?M1gwZW1Qd2djQys2K04yWTFVandCYW1SNHJZZE5wTUpQcmx2TEdBaEtwVStj?= =?utf-8?B?Y2ZlbDBXOCtJUTU2akRVeWlVd2gzV2w5eE80UFBIbUUwU1JlaHVnRG5yakV0?= =?utf-8?B?Skl1T3owckNuTTdxOHliQ0h1WU5COXUyQWVaclgzSEhaVXVtVlBsZmQ3REIy?= =?utf-8?B?emt1TDNiMmtQNjk5cFFGWEpMVG9UZnlGN2E0eUZLYlo3Sm05Nno0NXFuRENu?= =?utf-8?B?OVdUaDhLb3I2WTNrc3UwK0pwejhFYzRST0xYcVFFUEJKNHdTTmFoY1MvTVFO?= =?utf-8?B?UE8zZ2xEUW1rV1BNaHBrck13TVNsUlpzMmp6dkFwL1hhUW1GbUlWZFRzWGRZ?= =?utf-8?B?bFZHRUx0QmtBUHpiLzV6SGpvWjgvYllybTlKR1IvUlo3aDBNWVQ5dFdFUWs0?= =?utf-8?B?VEYwUEV2NTVGdzlINmxTcklVM25DTUx1Rm1UZUU1ckVQcHF6V0I2bVNMK1M3?= =?utf-8?B?Z2lXY3o1eTZDTVZKS2czUy9SZW5qVkh2c1drK0FDTXBISGNaOWRWTGttQTRv?= =?utf-8?B?RVdmMituTGpvUGRsN0UvKzJlTi9mSHZMNFlZd1phN2ppZHZrRmd2aWcyMFVV?= =?utf-8?B?V1NyR09FczhBa1ZzTWhLTkJxNVpCWmdKa1hjalVzbER5ZnhwNHlWd2pOL1di?= =?utf-8?B?VnBvaGI5L3dYOXN1TFI0OW53TmtiWWw2cXVNUFVobE0xVkpLenRuV1c4eDJX?= =?utf-8?B?YXZsaTNpK0J2OVlaYzZ0VTQzZjlWajJWZGs0cFI2MmJDUlhVU1hEZG0yQ1po?= =?utf-8?B?U2wvMEUrVVVIcWVZYnp2NUhVV1NvcjYvRUVFNWRCcng0RXM5bzVDaHBYeUlS?= =?utf-8?B?T1RUeTZxam5QZ3ViZ3VlalhkeUwxaFpVakZnM3hqdlVWalNrbDBJaHFZS0ph?= =?utf-8?B?bG8zRWptYS9MRHZRTjJwSERIS1phSlVGQmJGYnVGTGw0b2w1UzdmUUw2dThE?= =?utf-8?B?OFpvenJjdEwraUJnL29MOElPc1dCYzVYbWR2Zlo3ZUZpL2Vqc0RuRi92M1RB?= =?utf-8?B?TDBIZ2ZLM04zNk5JNGd0SWxRNXRNV1pJcEx0MVJ4cG1tcHZkOEJBL1BMS29W?= =?utf-8?B?YVBaU1NWOEVGL2gyYjRpcnhLNUp0d29acEtBUlZnUExDWER1YTlrYk5qc1p1?= =?utf-8?B?bFZ2Vi9CeStjRVNGOWhiRVZ2OVc2alk3L2FCL3d5aUV1YU1LNUUwWWdMdG1O?= =?utf-8?B?K1ZONFpzNXQ0NllHb1d2WStadUFXSVp3d3BkaGxndzYraDBSVHdMNUZ2Z3U4?= =?utf-8?Q?NooQR+3aFwcz1Nt+eW/uA5TR5?= X-MS-Exchange-CrossTenant-Network-Message-Id: 633cc810-30f0-4e6d-eeb6-08de3d690687 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2025 12:37:22.6638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 515+zqRv4y3Op0Fkru0/VMg7lu5s85Wq5jlJXvvD22h4yMpUypcWfwoXq7HVgNSUy34R1GlMSR55VCYlTVAQgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5322 X-OriginatorOrg: intel.com On 12/17/2025 6:04 PM, Vern Hao wrote: > > On 2025/12/4 07:07, Tim Chen wrote: >> @@ -1346,8 +1385,13 @@ void account_mm_sched(struct rq *rq, struct >> task_struct *p, s64 delta_exec) >>   #endif >>       } >> -    if (p->preferred_llc != mm_sched_llc) >> +    /* task not on rq accounted later in account_entity_enqueue() */ >> +    if (task_running_on_cpu(rq->cpu, p) && >> +        p->preferred_llc != mm_sched_llc) { >> #ifdef CONFIG_NUMA_BALANCING >>                 /* >>                  * Don't assign preferred LLC if it >>                  * conflicts with NUMA balancing. >>                  */ >>                 if (p->numa_preferred_nid >= 0 && >>                     cpu_to_node(mm->mm_sched_cpu) != p- >> >numa_preferred_nid) >>                         mm_sched_llc = -1; >> #endif >>         } >> >>         /* task not on rq accounted later in account_entity_enqueue() */ >>         if (task_running_on_cpu(rq->cpu, p) && >>             p->preferred_llc != mm_sched_llc) { >>                 account_llc_dequeue(rq, p); >>                 p->preferred_llc = mm_sched_llc; >>                 account_llc_enqueue(rq, p); >> >>         } >> > I am a little concerned that there might be cases where both |p- > >preferred_llc| and |mm_sched_llc| are equal to -1 at this point.", Is > it necessary to add a check here? > Are you concerned about the mismatch between the percpu runqueue values of nr_pref_llc_running, nr_pref_llc, and nr_llc_running? This should not be an issue, because account_llc_dequeue() and account_llc_enqueue() are always invoked together in account_mm_sched(). If p->preferred_llc = mm_sched_llc = -1, account_llc_dequeue/enqueue() will not be invoked, so it is still paired. Please let me know if I understand your comments correctly. thanks, Chenyu