From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D88C433EF for ; Thu, 9 Jun 2022 11:49:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244031AbiFILtK (ORCPT ); Thu, 9 Jun 2022 07:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244568AbiFILsL (ORCPT ); Thu, 9 Jun 2022 07:48:11 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95369EACD7; Thu, 9 Jun 2022 04:47:56 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LJj3J2n3VzgYcq; Thu, 9 Jun 2022 19:46:04 +0800 (CST) Received: from dggpeml500008.china.huawei.com (7.185.36.147) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 19:47:54 +0800 Received: from [127.0.0.1] (10.67.111.83) by dggpeml500008.china.huawei.com (7.185.36.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 19:47:54 +0800 Message-ID: <90d8eeb7-e114-3689-02b5-54f503452100@huawei.com> Date: Thu, 9 Jun 2022 19:47:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH -next] hwmon: (pmbus) fix build error unused-function To: Guenter Roeck , , CC: , References: <20220608084938.173071-1-renzhijie2@huawei.com> <76e05a85-b8c3-eaa5-727e-d8dc8f1c0672@roeck-us.net> From: Ren Zhijie In-Reply-To: <76e05a85-b8c3-eaa5-727e-d8dc8f1c0672@roeck-us.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.83] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500008.china.huawei.com (7.185.36.147) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/6/8 21:35, Guenter Roeck 写道: > On 6/8/22 01:49, Ren Zhijie wrote: >> If CONFIG_PMBUS is y and CONFIG_DEBUG_FS is not set. >> >> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-, will be failed, >> like this: >> drivers/hwmon/pmbus/pmbus_core.c:593:13: error: >> ‘pmbus_check_block_register’ defined but not used >> [-Werror=unused-function] >>   static bool pmbus_check_block_register(struct i2c_client *client, >> int page, >>               ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> cc1: all warnings being treated as errors >> make[3]: *** [drivers/hwmon/pmbus/pmbus_core.o] Error 1 >> make[2]: *** [drivers/hwmon/pmbus] Error 2 >> make[2]: *** Waiting for unfinished jobs.... >> make[1]: *** [drivers/hwmon] Error 2 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [drivers] Error 2 >> >> To fix building warning, wrap all related code with CONFIG_DEBUG_F. > > Please use __maybe_unused for the affected functions instead. > sure. will do that in patch v2. Thanks, Ren Zhijie > Thanks, > Guenter > >> >> Reported-by: Hulk Robot >> Fixes: c3ffc3a1ff83("hwmon: (pmbus) add a function to check the >> presence of a block register") >> Signed-off-by: Ren Zhijie >> --- >>   drivers/hwmon/pmbus/pmbus_core.c | 56 ++++++++++++++++---------------- >>   1 file changed, 28 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/hwmon/pmbus/pmbus_core.c >> b/drivers/hwmon/pmbus/pmbus_core.c >> index 809e666cb52b..2c68ab1fe697 100644 >> --- a/drivers/hwmon/pmbus/pmbus_core.c >> +++ b/drivers/hwmon/pmbus/pmbus_core.c >> @@ -441,18 +441,6 @@ int pmbus_update_byte_data(struct i2c_client >> *client, int page, u8 reg, >>   } >>   EXPORT_SYMBOL_NS_GPL(pmbus_update_byte_data, PMBUS); >>   -static int pmbus_read_block_data(struct i2c_client *client, int >> page, u8 reg, >> -                 char *data_buf) >> -{ >> -    int rv; >> - >> -    rv = pmbus_set_page(client, page, 0xff); >> -    if (rv < 0) >> -        return rv; >> - >> -    return i2c_smbus_read_block_data(client, reg, data_buf); >> -} >> - >>   static struct pmbus_sensor *pmbus_find_sensor(struct pmbus_data >> *data, int page, >>                             int reg) >>   { >> @@ -590,22 +578,6 @@ bool pmbus_check_word_register(struct i2c_client >> *client, int page, int reg) >>   } >>   EXPORT_SYMBOL_NS_GPL(pmbus_check_word_register, PMBUS); >>   -static bool pmbus_check_block_register(struct i2c_client *client, >> int page, >> -                       int reg) >> -{ >> -    int rv; >> -    struct pmbus_data *data = i2c_get_clientdata(client); >> -    char data_buf[I2C_SMBUS_BLOCK_MAX + 2]; >> - >> -    rv = pmbus_read_block_data(client, page, reg, data_buf); >> -    if (rv >= 0 && !(data->flags & PMBUS_SKIP_STATUS_CHECK)) >> -        rv = pmbus_check_status_cml(client); >> -    if (rv < 0 && (data->flags & PMBUS_READ_STATUS_AFTER_FAILED_CHECK)) >> -        data->read_status(client, -1); >> -    pmbus_clear_fault_page(client, -1); >> -    return rv >= 0; >> -} >> - >>   const struct pmbus_driver_info *pmbus_get_driver_info(struct >> i2c_client *client) >>   { >>       struct pmbus_data *data = i2c_get_clientdata(client); >> @@ -2961,6 +2933,34 @@ static int pmbus_regulator_register(struct >> pmbus_data *data) >>   static struct dentry *pmbus_debugfs_dir;    /* pmbus debugfs >> directory */ >>     #if IS_ENABLED(CONFIG_DEBUG_FS) >> +static int pmbus_read_block_data(struct i2c_client *client, int >> page, u8 reg, >> +                 char *data_buf) >> +{ >> +    int rv; >> + >> +    rv = pmbus_set_page(client, page, 0xff); >> +    if (rv < 0) >> +        return rv; >> + >> +    return i2c_smbus_read_block_data(client, reg, data_buf); >> +} >> + >> +static bool pmbus_check_block_register(struct i2c_client *client, >> int page, >> +                       int reg) >> +{ >> +    int rv; >> +    struct pmbus_data *data = i2c_get_clientdata(client); >> +    char data_buf[I2C_SMBUS_BLOCK_MAX + 2]; >> + >> +    rv = pmbus_read_block_data(client, page, reg, data_buf); >> +    if (rv >= 0 && !(data->flags & PMBUS_SKIP_STATUS_CHECK)) >> +        rv = pmbus_check_status_cml(client); >> +    if (rv < 0 && (data->flags & PMBUS_READ_STATUS_AFTER_FAILED_CHECK)) >> +        data->read_status(client, -1); >> +    pmbus_clear_fault_page(client, -1); >> +    return rv >= 0; >> +} >> + >>   static int pmbus_debugfs_get(void *data, u64 *val) >>   { >>       int rc; > > .