From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFC2C433E1 for ; Thu, 27 Aug 2020 06:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD5F5207BC for ; Thu, 27 Aug 2020 06:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbgH0GgT (ORCPT ); Thu, 27 Aug 2020 02:36:19 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:53102 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726395AbgH0GfW (ORCPT ); Thu, 27 Aug 2020 02:35:22 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 73AE2A05E37D5DB2E6B2; Thu, 27 Aug 2020 14:35:19 +0800 (CST) Received: from [127.0.0.1] (10.174.177.253) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 14:35:15 +0800 Subject: Re: [PATCH v3 0/7] bugfix and optimize for drivers/nvdimm To: Oliver O'Halloran , Dan Williams , Vishal Verma , "Dave Jiang" , Ira Weiny , Markus Elfring , linux-nvdimm , linux-kernel References: <20200820021641.3188-1-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <90d93e2e-1124-22ee-81fb-83ffebc3129c@huawei.com> Date: Thu, 27 Aug 2020 14:35:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20200820021641.3188-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all: Any comment? I want to merge patches 1 and 2 into one, then send other patches separately. On 2020/8/20 10:16, Zhen Lei wrote: > v2 --> v3: > 1. Fix spelling error of patch 1 subject: memmory --> memory > 2. Add "Reviewed-by: Oliver O'Halloran " into patch 1 > 3. Rewrite patch descriptions of Patch 1, 3, 4 > 4. Add 3 new trivial patches 5-7, I just found that yesterday. > 5. Unify all "subsystem" names to "libnvdimm:" > > v1 --> v2: > 1. Add Fixes for Patch 1-2 > 2. Slightly change the subject and description of Patch 1 > 3. Add a new trivial Patch 4, I just found that yesterday. > > v1: > I found a memleak when I learned the drivers/nvdimm code today. And I also > added a sanity check for priv->bus_desc.provider_name, because strdup() > maybe failed. Patch 3 is a trivial source code optimization. > > > Zhen Lei (7): > libnvdimm: fix memory leaks in of_pmem.c > libnvdimm: add sanity check for provider_name in > of_pmem_region_probe() > libnvdimm: simplify walk_to_nvdimm_bus() > libnvdimm: reduce an unnecessary if branch in nd_region_create() > libnvdimm: reduce an unnecessary if branch in nd_region_activate() > libnvdimm: make sure EXPORT_SYMBOL_GPL(nvdimm_flush) close to its > function > libnvdimm: slightly simplify available_slots_show() > > drivers/nvdimm/bus.c | 7 +++---- > drivers/nvdimm/dimm_devs.c | 5 ++--- > drivers/nvdimm/of_pmem.c | 7 +++++++ > drivers/nvdimm/region_devs.c | 13 ++++--------- > 4 files changed, 16 insertions(+), 16 deletions(-) >