From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53B11F8ACA for ; Mon, 15 Sep 2025 02:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757902346; cv=none; b=FEIsHvLbHkrK/MdnSMKuVzl8wCmFgQncsngcl1xRj8LTqAbzjmBSnyUeHt3t6hF3zEoBmNc8KK28utDckVc2uyCiv2ynhd0KdXj2uamJSvmMGZQrg1KDWqoPLkt136ibI54QKG32tuq/WhvxLAUDI/mm6rKJ2FtR9pFSmFZJwEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757902346; c=relaxed/simple; bh=0GHhTioe3fCzuyp9mgFvVSdfYm6wWU9Ggz+bSvzK37E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oTpOm8bD+xrSnTCiFYTloxzOfT9uK8qdwi/+3oNRBlZnyYhgPenUsScKMZI7e9NdTInPTIByoajLj7OmM4CxuTeuZ/g4PbtiYvb5GevqnBsV4VNJa26NFCb5ddMEmCwtrnl9zipIZuzP7wscHyP1kqkpPoc6tRc2S6HWbu/UTRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pwn03HvQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pwn03HvQ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58E8t2Kt000331 for ; Mon, 15 Sep 2025 02:12:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PKDP3y3fslPbwAzXQxnOfgYXvBbN4x4JP0Cd/lcj1w4=; b=pwn03HvQRx+QOzw4 CNrv2nPnVR4EeS9xj8OwLkCSr3pDrKIgrnn5zGPD6OSmIVbhIuMRk/sM1ymsiuVT UoS/3B+TTm/PGg6AavsVUT4c60pJjr0xcGi9prdqNa44mlAqdwApVpOZeG3y0UvX 5IneyOQFUpA0/tBtArlsBq/qR6ft07Uf6Q6qHrzeGWpJTijH9Tg/tNPoO+m9+M0/ hXH4VFmAgZX9tScMTUu3BD0M1gcLnYput3L0TM/Neab7F8N6YEqtMys+8kGWxZQw wPMwYjVDG1DxGXPQGiFAaohIH1ZzUMzmiCNs3TWZdLZSxm4hte3uTUf1yOseOq7I 4TtsQA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 494yxkb5v8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 15 Sep 2025 02:12:23 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-32d4e8fe166so5501093a91.2 for ; Sun, 14 Sep 2025 19:12:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757902342; x=1758507142; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PKDP3y3fslPbwAzXQxnOfgYXvBbN4x4JP0Cd/lcj1w4=; b=XB+NH+60uGR1otoEwSHarOXmmAIinr6LtI8FAx5WrZa4K1Zuaipb/dbG1ZX074pN4e oVNTM/USNDOem5+gVpfeg1voZ3VCfEPjGqDtLbni5jzhGGlc7e+18FSfZZJBOJFol6do rH8uJmNAt848UlQbUs5uyyXhQpJ3DHrCGH+3qw2Ix1wahOe181qZSdBWxShEEp3OKVnJ bBopDuymuK/vdTE9QGA1noaenUZl5P3pAJsPgJmQD8dDpUeJ9L+uVgSQgRsDk/5XpzQ8 Q973kzQsI/ixyhVwrrQlFWHjUl9I4iQCvs+idLfDsOBt9EHw9+BE9lsY7cd6ZV0PxafG 7Lxw== X-Forwarded-Encrypted: i=1; AJvYcCWyAEPCZ6cZZSkVjHiIl34u3LgPg9ZSvymRgULIx9EwTuqWR4CS1Leoaip18lLIhXTrczEx8hGhAsCb3r0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2L3GH5t5rA9Ihkld2nBljS7tm+XVWz3rqq442g9XF1JmiFxI0 STN7lGg1gdD5fuDFsLm6q21ZN03wUg2hc25fyCxOU3Pe3To3L0yKfAY/ybpTVe/FfiWtt9R64cc vd4BzMWsx1XXRBPVGas48czXgnquOEPhOZ0d3IyX0DZ9PcaqmaXum2YxV2unxpfbRe00= X-Gm-Gg: ASbGnctokpBrenUFJTiGC9pg9UHrwMOSTptVFLItuhhnegw+MR8D6JqcnYE2AE46MNu wwVtAN5MtkxwbaYoiQG/8BEVd/bdIYy3JW87YbJTEaK0HGBbANunXqBAq48Aqt1cwo5sbOC3HRR 3zy4rok0p6vUfiDH0GcAqg+9NO3RTDurXxeavVIr2J2m2RoE8yBCdSmPfOaCjIipM4g5aKEgmGS sUrMp1PlzfR0EiG45nwcru7FkSbwJaNgSF0LOu+3WxQLXiJ45XNPkdkcgiNHWAd5n7pyATy364I yADU/L2x8C5OFD3EwPGpGGOiGGSokUA+bBahbD/YM5lC3WKJ9bT5y23XKP0Q1a45mA8vkMPyeh6 tumqB+McLR3/Q+IvDyyhRRhDhQLeNSKCsWA== X-Received: by 2002:a17:90b:1651:b0:32d:3895:656b with SMTP id 98e67ed59e1d1-32de4ed5b88mr14891965a91.12.1757902342270; Sun, 14 Sep 2025 19:12:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkLWVKWY8dJJSoWF5RHJnh56tViKNJ+59aIriO7fADzS1hQtOLicZ6cEGv4usM19uQ2SmK5Q== X-Received: by 2002:a17:90b:1651:b0:32d:3895:656b with SMTP id 98e67ed59e1d1-32de4ed5b88mr14891940a91.12.1757902341829; Sun, 14 Sep 2025 19:12:21 -0700 (PDT) Received: from [10.133.33.181] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32e1e5ad768sm4381659a91.0.2025.09.14.19.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Sep 2025 19:12:21 -0700 (PDT) Message-ID: <90dcca12-1a68-4049-bcbe-c333aed07a07@oss.qualcomm.com> Date: Mon, 15 Sep 2025 10:12:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform To: Stephan Gerhold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20250910-hamoa_initial-v11-0-38ed7f2015f7@oss.qualcomm.com> <20250910-hamoa_initial-v11-3-38ed7f2015f7@oss.qualcomm.com> Content-Language: en-US From: Yijie Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDAyMiBTYWx0ZWRfXzkkFEgwQnGDJ GTfBegzVGjWtFLLxRKegHC8JHUbfCbLfH0zprPVleGr/eDQWfSKJT4rs+K2zvEhmMfNsD8NUTe/ TvtzZRybT03GZQ2ZpJrip1w5CpM8it5yCNDZ1VSnVV3xAapNDNNYrNUfe8Eg9VL1Rtb+9+HUbBH c8TISN63ABzpBVbc7BTFhgEHgq0ONBccIFe9G9wwx3/NTsjGbrwSIS8OiE9FLkUXnDR1ZS1qotm Xq/TPN+I/rLYfe5AASOM5Ik4rrQ8//bjKyrZFJBWQC9mnDVBpZ0v/h2AFoFuw1VQVCD4RtqpJIW AV+V8y4H5nYkRjxTdY604U0fRDztI90zfvuTC8qiskpwEEmqAvmHe8knRRlz+kEmrBkRWBUgo8s Gr4MbsQi X-Proofpoint-ORIG-GUID: IhpCyCGQzH87F2JYV8qOSp7lKIE7RjFN X-Authority-Analysis: v=2.4 cv=KfjSsRYD c=1 sm=1 tr=0 ts=68c77607 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=g_NBhjyYV65zCQWelF8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: IhpCyCGQzH87F2JYV8qOSp7lKIE7RjFN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-15_01,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130022 On 2025-09-12 16:48, Stephan Gerhold wrote: > On Wed, Sep 10, 2025 at 05:02:11PM +0800, Yijie Yang wrote: >> The HAMOA-IOT-SOM is a compact computing module that integrates a System >> on Chip (SoC) — specifically the x1e80100 — along with essential >> components optimized for IoT applications. It is designed to be mounted on >> carrier boards, enabling the development of complete embedded systems. >> >> Make the following peripherals on the SOM enabled: >> - Regulators on the SOM >> - Reserved memory regions >> - PCIe6a and its PHY >> - PCIe4 and its PHY >> - USB0 through USB6 and their PHYs >> - ADSP, CDSP >> - Graphic >> - Video >> >> Written in collaboration with Yingying Tang (PCIe4) >> and Wangao Wang (Video) >> . > > This looks like you should have Co-developed-by: tags together with > their Signed-off-by: tags. We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread. > >> >> Reviewed-by: Konrad Dybcio >> Signed-off-by: Yijie Yang >> --- >> arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++ >> 1 file changed, 621 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi >> new file mode 100644 >> index 000000000000..c7c3a167eb6a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi >> @@ -0,0 +1,621 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#include "x1e80100.dtsi" >> +#include "x1e80100-pmics.dtsi" >> +#include >> +#include >> + >> +/ { >> + compatible = "hamoa-iot-som", "qcom,x1e80100"; > > Undocumented compatible (without "qcom," prefix). I think you can just > drop this? This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix. > > Thanks, > Stephan -- Best Regards, Yijie