From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB4D33C417E for ; Thu, 11 Jun 2026 10:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781173800; cv=none; b=B2e9gVnRVGVmmstgE8EzQAlNL8TRDVkDg+HB5lmifuiP4w9be//zx/5wxnzNGPJdPxHC9yBTROdscSG3q5diC+82tmo2jUYsnTQaYuVleZP/nEuwrcLr65SPuIr+JHn0xNcXjDZRDSQbj+CxuvuPGeJI0/b3LV3UuNE+kvEouwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781173800; c=relaxed/simple; bh=6BtBfy3blHmdDbzQ0mHVTFkA9pNVSOFmH6q84PkUHjI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a+kJhXJilYNBAHzw/Ei/Xj1VTG6YIYlTHhKh3wcJliIHZdk8FqUQO7IFwoIwJYff/SP2gmaxJZbi7jdfGNfxVFYjem0Qwt0cyXEpLA2Mca42eR2TUx0xUnhfEEIXetO1xQfywFa5V4W0VpqxWZCyq6GUq89f3OenlA0NOCuvhVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ibH1AWNM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CKIAYAbs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ibH1AWNM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CKIAYAbs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BA1Rsu168086 for ; Thu, 11 Jun 2026 10:29:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AsbX8LJfzS1TZMIkwbo3ResQeTNTfuQ6Cs6WQoVUlHE=; b=ibH1AWNMnqYf4733 LM3sye481UJUyBjAz4Y94Pl8IXMLtxnri52mTXTxtJZihbXU4FmaO1gxGWNKAD3r 9xdVnyRYvtg3rCPxCd0NRuxZK0dTMOGFxtFITJ8Bdn/yeb+NSneRS91QI8Tx+m14 FOHZg09oek6hql1MrQplonw93stutFwXWdoENOxRTRhgK+J7L1vEtPJe3HAgUXVS RTMMPQxF64ONp0qUmauT3WM2aFZQnqLNNXCRcnnJZwK2BRLSSwDEK7L6LuDA8cU2 ZTMjGFDCNbthikmmh4gD3ZkcJnidVdH4DKYG9hnLCjqQ74PWKwWwBIu+jCfhPVWC ia3MoQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6uaxq1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 10:29:57 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-517647fbff1so25777621cf.2 for ; Thu, 11 Jun 2026 03:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781173797; x=1781778597; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AsbX8LJfzS1TZMIkwbo3ResQeTNTfuQ6Cs6WQoVUlHE=; b=CKIAYAbs1CoiFkGiy4nZC0w4VhpvbMYgBFhzgLbMqnvoG00kCiZ1E/mMCMCDkURxb4 3tz2O313sHFXejEl//uQl05trklGYNqvmAoGkCP5AVN7Ka8HwojKmZtOHfbDlV9FDnf6 PZGa1aj+XpklWdRnTrRqkM8Vytg4w1Uxgl5GIazQrRmKLZj7l/LWx6uNaWjR49Mn8Rt7 i5kmBSgn92OFbK9+LMwGIHdBHFY4jqPL5/AzCRgfkBnh4X+l1qv/qmyWaLIzod6q+A/K k2WLvQi1yF3eeLOw3jFODZctNJC9kCmpQrOVuKluvVFMwuEtwAugKMcEWt5VFGKcXRBp GdYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781173797; x=1781778597; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AsbX8LJfzS1TZMIkwbo3ResQeTNTfuQ6Cs6WQoVUlHE=; b=iG1OsdcPvj4b8AvijyWbzQJYmztz6Wr5H2w0fJ6iD6oCSh4sF6A6dJy8oy9t9lBsj+ bMgzDJSQ2TUBTtCfQrZijtO6g/ViJxWcbKOZBaYujtywVEwym2hI8lynhMzoBJuy0/s2 QlckO0r0llo4gWMzHIXskZlt9ejbMEdv8lqyIqbHYOimmxgSuUlmFWGR2MNk4lWrKXYw yfqB8rtviorfWybUCW7hMkhBinPeIs/d5Og2gDPQkPCQ3sELaMPMBgaehyjQl4hEl0Zv 3U1xSLx4y93oYwcz2FQqS44kVxkPp+Wbvyfmm9eXVWFC9df4gemJ/q+QEfMn6f1C4cOh U0rA== X-Forwarded-Encrypted: i=1; AFNElJ8tIx3ha9+e8MDYhF3nwqh5/xGMxQD0oNRlGWviBf4ge+qj8+pExnHLUPHJUIm1j/kZ+iZGo3a/imaZ+Kc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg3neBxQEE9MUZI9syEusALVcedsO6SMw6XVFhe+fQUyXKkub/ VuiSPWYICBPxj1FaExVwkI808ckoJ0tGRu572ysJgb4wBqVdJVibvYhUkJuZ7o+J9gNE8gHPy0u 7CZTmH6plwy4iZYpFEMY12LxAWyNQQKcd0K9007KgABnkBgJwkJ8QX48b6McMEwQ8Wmg= X-Gm-Gg: Acq92OFVmiB18eCNeBXZF5wFBL9uOXnqma1Wa13p0A6kUXBpK37x9gMqZA9oQQa307v hewKkN7Avxn5zjjtEykxaoNc5pOu/wBnWirJNX97bFeZVtMj9yeLxyE2BB73SOmd+7oD4frwHMf sbFeh/elNUoLGBpCM1SjQ7ntg2rxCVt+Z6hRpFfIDzEG0fxkGtkB/Si37xOTVYwzha1VzaqExhi 0pk445Zpu6He/l33XIm58wjWGAtFW4uW1W6V4VV+OlU10LK398pwTRQP8vq0T5qvbJJTbuDc3op azkI0ua1lHs1f0ytl5ZJ+oUQfhvzWQU+iBLJCFcfR2W11mGP36OPjORT9Xz00a9ufZyC+IYKEuk ayBjvycUswzLS6pVoMXOVoJSyilrKAnj7QgC9ZKnkt4NJig2icoz3GYnY X-Received: by 2002:a05:622a:1dc4:b0:517:5af6:77f9 with SMTP id d75a77b69052e-517ee1d207fmr22539741cf.3.1781173797071; Thu, 11 Jun 2026 03:29:57 -0700 (PDT) X-Received: by 2002:a05:622a:1dc4:b0:517:5af6:77f9 with SMTP id d75a77b69052e-517ee1d207fmr22539341cf.3.1781173796593; Thu, 11 Jun 2026 03:29:56 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e6585154dsm10778203a12.15.2026.06.11.03.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 03:29:55 -0700 (PDT) Message-ID: <90de58eb-b440-44ee-882c-cb52d0f816cf@oss.qualcomm.com> Date: Thu, 11 Jun 2026 12:29:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] drm/msm/adreno: fix use after free on error path in a6xx_gpu_init() To: Dan Carpenter Cc: Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Harshit Mogalapalli References: Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDEwNSBTYWx0ZWRfX3R0PCy3BFMoo OOkzThEe/X6Yhku12s3e/gbSxyFe4sENkEWFxUCPdV8PqQl91muToeL7Tvg+gofbBPdJ7SMu7Bg ryanP6Xr9IEoBU88UMo4nzmh8SIMf60= X-Authority-Analysis: v=2.4 cv=atOCzyZV c=1 sm=1 tr=0 ts=6a2a8e25 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=CLLU5E3UPER3H5ubdxMA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDEwNSBTYWx0ZWRfX+Q6z7kMKoXLy 4MOWZQs4PFbn1bLI5EraTUoxRbTBOhg3EvMpXmFor174T3r9jr78ZoxRz1Kz7TFeuurNtpwbYqQ fLU4rFGYQiVaM2nbO4z2/K7l7+4GftWzzw9d6WDj5ZI9C88Y04IH6ifhNg/zqJNShSJu46eAusy sCEb7g91hLfHZtY6vwsWLYWxcunLVl08txUMN9/dOm9HSB6eu7D2xF+sRClSYbAwQuwdSesLR2P qnpUCK55x0v6fWIgWzdwnANlkXU/qvv74LNWaJqb46lsOT6PXiIbKDH628DZC58T2+CXX3wkysG VEN87CBXj3WAEN3EUAR8iXVsul0hvtTuBL+iKo68y+vNzVmREPHJhq4SFj58tmlKfvyC/4YoYvk ACOBof2btUvJKapD3LZHr9wfFfOKqHKM9+lL2sgwOXn8/tVKEcor/pQZWllm+MIBLlz7JM0NU33 94bpqrEfcBZ+0pYk79w== X-Proofpoint-GUID: v1RGKTOop5TY3b4M1E0ATfCOAEiAxUbS X-Proofpoint-ORIG-GUID: v1RGKTOop5TY3b4M1E0ATfCOAEiAxUbS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110105 On 6/11/26 12:27 PM, Dan Carpenter wrote: > The a6xx_destroy() function frees "a6xx_gpu" and so "adreno_gpu" points > to freed memory. Preserve the error code before freeing the memory to > avoid a use after free. > > Fixes: d158886cba08 ("drm/msm/adreno: Trust the SSoT UBWC config") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Konrad Dybcio Konrad