From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Oleg Keri <okerixx@gmail.com>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] phy: qcom: qmp-combo: check qmp_combo_com_init() in the typec callbacks
Date: Wed, 21 Oct 2026 11:58:18 +0200 [thread overview]
Message-ID: <90e14985-be2c-41cb-be74-60ca1829322e@oss.qualcomm.com> (raw)
In-Reply-To: <20260916133814.3977-3-okerixx@gmail.com>
On 9/16/26 3:38 PM, Oleg Keri wrote:
> qmp_combo_typec_switch_set() and qmp_combo_reconfigure_phy(), which the
> typec mux callback and the USB4 init path use, tear the common block down
> and bring it straight back up on an orientation or altmode change, but
> they discard the result of the bringup:
>
> qmp_combo_com_exit(qmp, true);
>
> qmp->qmpphy_mode = new_mode;
>
> /* Now everything's powered down, power up the right PHYs */
> qmp_combo_com_init(qmp, true);
>
> if ((qmp->usb_init_count || qmp->usb4_init_count) &&
> new_mode != QMPPHY_MODE_DP_ONLY)
> qmp_combo_usb_power_on(qmp->usb_phy);
Sashiko has some comments which seem valid
Is this something you hit in real life, or is that a static finding?
Konrad
next prev parent reply other threads:[~2026-10-21 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 13:38 [PATCH v3 0/2] phy: qcom: qmp-combo: keep the Type-C callbacks off unclocked registers Oleg Keri
2026-09-16 13:38 ` [PATCH v3 1/2] phy: qcom: qmp-combo: hold a runtime PM reference in the typec callbacks Oleg Keri
2026-10-21 9:53 ` Konrad Dybcio
2026-09-16 13:38 ` [PATCH v3 2/2] phy: qcom: qmp-combo: check qmp_combo_com_init() " Oleg Keri
2026-10-21 9:58 ` Konrad Dybcio [this message]
2026-10-21 12:25 ` Oleg Keri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e14985-be2c-41cb-be74-60ca1829322e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=okerixx@gmail.com \
--cc=quic_bjorande@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®