From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37F6A39EF02 for ; Tue, 17 Mar 2026 09:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739529; cv=none; b=V4fLBZT9ukLQQISffoFSrihc8CcJFyEnI6+4Jy3VfL0kO+a1jRXn489rK3JdCR6YwTDq4VNkGmEVVgGNpD7UTX0zoLaaOfsQ5GUus9hc5ZjcubuUaTLGYiaeo/zMfygJrtBSgFf9NXdNwl8mN5vhh7n+2STzHkKWuHgXLC9ZspE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739529; c=relaxed/simple; bh=cYAUf7tYdCbIp0kTz7vRfdzxvjmcwGrNweRRCyA8n0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hhDDzvbLtoAuoqC4yTgJw/3lEOqcNVabE9koAZUg+Ek17BZnduiRzxNnZmZ6yBT0M5S9Z9lh5uJLZw6JPzEh9NpVyLtmVg2wkiSWXoJbXnkmHTKeYXdjuHA3HFLcZbwIA1nVwIbYa3Pwy/5GDjJbdRdE1T0jz9vYmHRM9Hp9kpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=equERnHi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QRD5fIDb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="equERnHi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QRD5fIDb" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H9C9GA3101993 for ; Tue, 17 Mar 2026 09:25:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NEQX+EDkomw9M3dwmMKBzxuBhFDxwqMzLHFUnr0OFuU=; b=equERnHiKsZkOnIR Xlt8Dh6zE6GT6R1LSU75jKjmzG/GoU/IA18gebinn08Nfwy91zv1K2tpbpNcLH6e jGnE+3EDldZzU2iRgjfd7HjNK41Y67wYUHB7nKv1ICc9Hp6m7j0EBiSqrA/FJzdO 7Vwx690zU89gychHcpkSHAgaKivtV0KZgvEuOu6thhkqCPX1HpyHxFTdNMX5dt/s 5JkgPAiTBRXdGoBXwScwW7KHwYt9MsQU6Z7FXDw/KdkLQwZu5hZFx69YV73ICXZC gCi1dj0PWzK25Bq6wXZVC88AX8kVeWVnCz4R3SsY+UCai2nCGnz/pv5iEZG4mYJq wWhSnw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxnb7b4yv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:25:27 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a90510a6d1so5994715ad.0 for ; Tue, 17 Mar 2026 02:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739527; x=1774344327; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NEQX+EDkomw9M3dwmMKBzxuBhFDxwqMzLHFUnr0OFuU=; b=QRD5fIDbYcZ4cQuZJtCLbr+Jg06uGRJSW4+xzT0yHOQ/FMMYxz4RISqqDsxKKwCtbi ZuoZSNwRI27XrL9vAqF6pFqJMXMSX4N6ErdvEi+3eoT5PoxNQtioSbeU8iWH6d0HsxK7 Xx3sAWnN/px13J7qMVaPJm9jgzezBqmUg8lIccFy5kDAaUoSdV0uha0/aWdDErstc7Cl 8pG4hw3hTPaOMrBs5nBBfzhRfyM35HJq1nY5LUILlfsa8Et/LgLrLOC2zw3Vix+q/Vd9 WpEEaRLg5AdfgIrFxdmsSyThxqY6d86co0Xk137CO3JOmgyKL5q6RgSPoqLyXVqa+Am1 agKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739527; x=1774344327; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NEQX+EDkomw9M3dwmMKBzxuBhFDxwqMzLHFUnr0OFuU=; b=oDtLJAmzsb2LUVkdyWOW0jr/qd0E4M+s7ABQlO4ehdxMEa+HAr2Nzm5NAa3gH0w4kw c7AOjEt819K/m2BrSY7YmENo35qs0h5vPfB/3JwMz/zD0LIkohdupyR9StGbhZTKl5FA pLI/PVvdhNphHTd6kdlXMheHZZrWypDMwM/v/+Dn8wAFHw7ungfHvBBXacyuZ+kRTLfl cqaYs0rfJuexC7zMa5sBWp7BJ6yfp1ydPrIRVSBAKu8vqVIYJ5miJMMvokDkoN5rYe0d z7PiDwtCcy9x8JLWdgLpN43sTMvMpZaEqy0E2ZuXZf5CKapwkg0QXZ6zkP71hXaqrH2i FXZQ== X-Forwarded-Encrypted: i=1; AJvYcCVgxuXZTDzLfmEBTnjVHAgm1IX2cuuhtGQtjMKUAecCoPLS+ueO3RHrbwGNy7ur+bdb/x22m5C6oFUtr5M=@vger.kernel.org X-Gm-Message-State: AOJu0YxXffh5ymUjUiF/UJ+ljECwNlJMZm/U1S95q5UyU5cZj2aVWj1P ReYeGKuX5EIkYETKpDzpKfBxtOpJHG0W2DMZ6i/tL4bi8miWbjC2MgYZq5NunDNnTxu5IzpAISt 39Opatiq/9XzMFpbALEjF9Yrw4pczA7lJi5NR6lVwuOEGQ3P6B6vhhs9/uFBnvNHFaqY= X-Gm-Gg: ATEYQzzlsdWOQWSp/Qc0BKxXXa6myBVf/W6ELFvusl6/TqbLEYPQys4Wv5/M05ET9vL CTfCVS04gPF0hifWB8nj05473ZzkuSK9uyQXL7Fcyx4y/Zd2t28QmvfCf73afkgonb4O0t+Ya3+ H4hE9tG1MlUA21a7nkcDcvvUmF8XWSTDcrq9qpmEHgbgTUzro3id3an5CFKcHULzVrcDbU3st8+ imGoXPIV/goefb+qWE1ukmVpA+Y193imm0CZVtzYvz37RVam/cW8SPTXNfdlTrkgINi23CKTgKz vUHaVefCF6ubkGBnFoV+hzPhh46Bgfi7Khfvta/n8ZbAUNNRt1ErFiz5BBR/iU7ukcpcL6Vexp2 J3s2U2Y7skBtrU8k27Lg3pslYaMcKlxXZ5YLDZ0SsIf4J38ncUlM= X-Received: by 2002:a17:903:22cb:b0:2ae:5a70:477e with SMTP id d9443c01a7336-2b06365b4dbmr28028645ad.12.1773739526814; Tue, 17 Mar 2026 02:25:26 -0700 (PDT) X-Received: by 2002:a17:903:22cb:b0:2ae:5a70:477e with SMTP id d9443c01a7336-2b06365b4dbmr28028325ad.12.1773739526299; Tue, 17 Mar 2026 02:25:26 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece7ee3ecsm176093325ad.42.2026.03.17.02.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 02:25:25 -0700 (PDT) Message-ID: <90e2efd8-77e4-469e-bd36-61bcae290e21@oss.qualcomm.com> Date: Tue, 17 Mar 2026 14:55:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: crypto: ice: Document sm8250 inline crypto engine To: Krzysztof Kozlowski , Alexander Koskovich , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309-sm8250-ice-v3-0-418bf5c5c042@pm.me> <20260309-sm8250-ice-v3-1-418bf5c5c042@pm.me> <9e740dae-3197-4cdd-85fd-8a840d2317a3@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <9e740dae-3197-4cdd-85fd-8a840d2317a3@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX7/GqADYXg2Rw fPfzrP+/EkAmjggPYRIAEBn2EcoEgi0gab+FbDCbR8di/54gIkWuUQiVnge1bxz9/xxrHNsi3GP apxxGcfDv3UUCrBY54U/mruomVjESj9RTr3RKlYT41/4L852TcYb+sy9vzfWFOtui2bNXk42e+x RHi0wSTpBx+D7jOrHad2c3MXNY37bewatYykt4TM+qaLQL3NXFTfz67SCr6Is4P1v0xpmb3uX3A BWljV3zBSf+UlvmQlwMoK7F6hzTrqSX2WBSxfzneTwEe67QK4bIMKN97d8J/l2orCGKLCvJ4mLw xQQazp72ospkAeS2tdQ1244yqoCI9vO5aI5VU/In8jbbi910mmTd8YBSgAOkbf4PCGjfJCFzagM lee3tXSbFT2fk3lDOi4+2hq5FJtegSb31ap1o5iHABDzpx0s0HZRNoHaGptpEdx/mNDRNKNy6ej KItSHQ4lMtFAb/347rg== X-Authority-Analysis: v=2.4 cv=D7pK6/Rj c=1 sm=1 tr=0 ts=69b91e07 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=BNPdHxw50mfEycljYbQA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: aQLQKN3YGX9Vpv5HKw2B0tQVD9Ydy9pC X-Proofpoint-GUID: aQLQKN3YGX9Vpv5HKw2B0tQVD9Ydy9pC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 On 3/11/2026 11:56 PM, Krzysztof Kozlowski wrote: > On 10/03/2026 04:12, Alexander Koskovich wrote: >> Document the compatible used for the inline crypto engine found on >> SM8250. >> >> Signed-off-by: Alexander Koskovich >> --- >> Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> index 061ff718b23d..ccb74ea14ce8 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> @@ -19,6 +19,7 @@ properties: >> - qcom,sa8775p-inline-crypto-engine >> - qcom,sc7180-inline-crypto-engine >> - qcom,sc7280-inline-crypto-engine >> + - qcom,sm8250-inline-crypto-engine > > SM8250 does not need two clocks? > > https://lore.kernel.org/r/20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com/ It does need the two clocks along with the power-domain. I can see they have been added in the DTS but with the updated DT binding, I think they should also be made 'required' for sm8250 similar to Eliza and Milos. https://lore.kernel.org/all/20260317-qcom_ice_power_and_clk_vote-v3-2-53371dbabd6a@oss.qualcomm.com/ Regards, Harshal > > Best regards, > Krzysztof >