From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72DD9282F1C for ; Tue, 9 Jun 2026 08:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780995018; cv=none; b=L78HzJucnxsA2f0G+6mbwPzVp2VwZGg45bHDU0+kyC2X83Vle98Q0ALHdJAf/u8UulJc3dKrfUlt/nK2BewLkyYb5nl7jxlMFINUus/e+5CVZHLmeChkJ7Ggb3Yktb0tXGiqYii9j53Uyze5HsIfTtgE02FiP1l3j8/jsfeFYLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780995018; c=relaxed/simple; bh=aT+06l9JPS/W+pqx/huAMo+hW8G+qSykMxbB+7ekHio=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TnUNa0BG0o/77BpFoHgdtO3KKSrOSFqLleEIxS/hI64Kg5ld15bzUFvb/2jGfmqOgV+089GY1ovc+b8FTVQEJZJAOsP3T2V5BE6e6wimMxtL5iPtk/+zgoB6GbAqd2omVY5vJGXSzRqETElO4vurt66vZNR3aknmKQYehttmQGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a8uS1YDT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZB0K+MkD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a8uS1YDT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZB0K+MkD" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6597rMsc1585684 for ; Tue, 9 Jun 2026 08:50:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aQ8sqSDtMKXLNJDD7UQJ1CI9HnoEnTFDVTKs30mRhZ8=; b=a8uS1YDTcw3zbn/F c/HWDHM7crqvSMm0jvRhfyD7y4g3j3AMCcPOoUivysrc+R3COCFZdyJEvTYDlJdf NeyFGO5vXHu9sUs6/I6My5/A7BTjNyuQugqbzqkWPHyjcVYD3jDBqqOfdKxbxdUS D/gw8KcRtvf8mX7S6bQOlNylrxHiay9pqZqpqMcMvTAZ4U1alPKjDZSsF8trcadv cLJCPU/2B6SoUU5AqeoMxILotqgKQRzz66AtZBJn20PAc5SXplZeM2+BYWLenVZM pyQg4nzsf/z/YwoMwsTa94bSdPkBQyStr03FMbeGCLWnnkf1nKnhO+assLR6BZ7V 9dr24Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epeqgg961-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 08:50:15 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51768072950so72679291cf.1 for ; Tue, 09 Jun 2026 01:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780995015; x=1781599815; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=aQ8sqSDtMKXLNJDD7UQJ1CI9HnoEnTFDVTKs30mRhZ8=; b=ZB0K+MkDpRYpOMqAZaGV49kVVJ5HOO0HTOOVC7hjYcYb7Uwvqic321d6TuBRYYW4FX TuA6bCd0yZrc3EBKMpcjFLcxcigY+D0IA9NN6EphAFz9HPiMKm+mBZsFCNwhekTgxYDT pGxX+OmJLLorjHvlSeObISbOoDlmUYiiFmYsel1Em1yEMKzRxcGkQlFu3xmXKxGELKf5 7ANmMTAOupI6DdPBd4ex/UCcfWqw+qWyE7iAR5Xg+CpyROVWMRNTgD0WabkGFiWnsi6z gBpiLATxGOQwzMlxsakB878ibKFOBGe74Fe7IXQ0hxPgzGPvfVMGE2KYGnftV9MAHJQH agNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780995015; x=1781599815; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aQ8sqSDtMKXLNJDD7UQJ1CI9HnoEnTFDVTKs30mRhZ8=; b=gC27I74W9KASEbIp42s5gGPEXQqYQ376VzBaCOJLawkB+xcxymscvrHgYrkvc7HeZJ uMk2CVpNPreXnI8aLwDgvrTo+sldNg67l2qDVBAg6lP3gEIZlhoq3qTkPp6rq/kaCsQw PRUn1M3nuD3aWk7XgiyJroKl2bBF6spCHE5WQbm72sLLTJJNs7nRIgb4AJrpgbH+ugte 96rRg86+Yw5U5IL/AoRXNfWZmGoP2PsllvVVh2V8Elqenz6U2frEi57J1jxLzqGokzF4 NuVRebmiLCAXPTp0SxxmgOk7wYUL2wJlXoDW2MT9MvPffLasnQkAaXyhJ7kfrKkRaYZo qruw== X-Forwarded-Encrypted: i=1; AFNElJ8ka74TG1Z0F6TwhUtIJEYq0vwjbW2HTqgga1oQxt4KraquG369ECcgf9wSJtlKd4iFDuLRlDkxmL/dq2M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2OHTdW4iCdE+3ZMUmW/0yEx2PleokofJktt37oaQjZoBUWfcr O4NRPunGfweR/hoic/L83M2l3UoM7DNpZr2kcRze8P9/Oas3YbQFA3pvP86z7qlrlRbiXaQs4il cZDUrHKSEvv3W5G1Jv/24UXiFZjXjzJqtScsdHUpa+NpIEB0Cr5nYM1SLG0ZemmGA1R0= X-Gm-Gg: Acq92OG7eC9NxlvqPvySk3dLfHKU+TlygQRzgk1xsCEARl8d3CNuEhw2o6XrLRwDhx4 5STjBnyy/8aBZYQqBttB4ynfaPkHNk83codR9mZ/aCU16FJGaSrovvXNwKjFDf+HvuNbL7bdHP9 QbZzNW6uP5srG8HkJr+SQvh3Ac8Aleit4yTRY5Hd8M9Tz6ZAanR3YPfu2zG49l7ejOixB50pdlX rveCiGXUN4DCXTNcMHXAWJgV+l5tvmtJEDGecbAt80UuWyg7luaqQtXnmhUZZYTEbnEjZPyYvWn FD/VhzuodN6BoJn1kvlBR0Qg5j51ZE3NbcW1YnAe6WirRJHEF//HdGRbfDvRzHpluih6CGqDn2D m41ciy26XxtD+blPPmrK0O7zpK/LJbwGarRtsD70w9GEq2qSVSxrPYkcMY71/2SzZvGtaaQsNqi XHeL9SjIQZBlim34R0klvXkomQn2z+EuncDUml7ouM9pYGTRWMN81nmyIAGFx3zAYZqtn2COkZ+ W4uH56f3I7Q68P7bikmwuOIGRI= X-Received: by 2002:ac8:73ce:0:b0:517:8f52:2724 with SMTP id d75a77b69052e-51796953373mr207761921cf.43.1780995014648; Tue, 09 Jun 2026 01:50:14 -0700 (PDT) X-Received: by 2002:ac8:73ce:0:b0:517:8f52:2724 with SMTP id d75a77b69052e-51796953373mr207761651cf.43.1780995014160; Tue, 09 Jun 2026 01:50:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf054e02b43sm980240566b.40.2026.06.09.01.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 01:50:13 -0700 (PDT) Message-ID: <90e55476-691b-4528-8404-0a8577a532b6@oss.qualcomm.com> Date: Tue, 9 Jun 2026 10:50:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v6 1/2] platform/x86/lenovo: lenovo-ymc: Suppress probe on Yoga Book 9 14IAH10 To: Dave Carey , platform-driver-x86@vger.kernel.org Cc: mpearson-lenovo@squebb.ca, ilpo.jarvinen@linux.intel.com, armin.wolf@outlook.de, linux-kernel@vger.kernel.org References: <73c27728-2f07-41c1-82c7-fd6f46c89f3c@oss.qualcomm.com> <20260608215205.678182-1-carvsdriver@gmail.com> <20260608215205.678182-2-carvsdriver@gmail.com> Content-Language: en-US, nl In-Reply-To: <20260608215205.678182-2-carvsdriver@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA4MSBTYWx0ZWRfX4yWSojdmMUVb ToS1FrV3YHsLifO9Txxr+GURmW/fCk+QemNGR8Wl3eFpUBtMO2T+HuD4L8mIr+ilFY8BOLR+jYh v164kpAJBURIcyZSaEOcHuHxaseEuho5tw7PD2w/IQk+cSgc5MGnuuo9mB95tXxIxzhVK8Ompqv 1uwxYy+B6z9CqYFVJwL5NAe7HFGC6lbQpLx6myD63+W6RhfqTgJ0oj5/A0pTydjOZxgdtrl6RiG suXvP6hbqtxq1saA15/YrnmwMwAezOrErj2Bue0fIhaOGHpJVT4obbD6XtnYUzYp5+oammWlfD1 gZuZ1dw/DWL7vJJdcNtAa451R2Uvf1ch5KUkN7RzqcekuLmpwkPrqPuRZbOqJ9GgIjhPJN+TvjA BvYyqUN9/QMAsCtgepvnxy6DPk5gANzBcMvUos6f3QqDERXUFfXS+vT84BwD4eu9XxCtFQ65/El 0G+qa7kkdwocmaiXgUA== X-Proofpoint-ORIG-GUID: L-7L1sHaAx0f7335sExjWT4463DGv8zy X-Authority-Analysis: v=2.4 cv=KdHidwYD c=1 sm=1 tr=0 ts=6a27d3c7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=xL4ekoq9v3liqJ9o2P0A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: L-7L1sHaAx0f7335sExjWT4463DGv8zy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090081 Hi, On 8-Jun-26 23:52, Dave Carey wrote: > The Yoga Book 9 14IAH10 (DMI product name "83KJ") has a dedicated > yb9-kbdock WMI driver that registers an input device reporting > SW_TABLET_MODE to track the detachable Bluetooth keyboard. > > lenovo-ymc also loads on this machine and creates an input node with the > SW_TABLET_MODE capability bit set. For input switches, the presence of > the capability bit has semantic meaning: userspace (e.g. GNOME) reads > the switch state at startup from every node advertising the capability > and does not expect more than one such node. > > Add a DMI match for the Yoga Book 9 14IAH10 to probe() so that > lenovo-ymc returns -ENODEV on this hardware, leaving yb9-kbdock as the > sole SW_TABLET_MODE source. The ymc_ec_trigger EC write, the only > other action taken in response to a YMC event, is guarded by a separate > DMI table that excludes this machine; no other functionality is affected. > > Signed-off-by: Dave Carey Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/lenovo/ymc.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/platform/x86/lenovo/ymc.c b/drivers/platform/x86/lenovo/ymc.c > --- a/drivers/platform/x86/lenovo/ymc.c > +++ b/drivers/platform/x86/lenovo/ymc.c > @@ -23,7 +23,23 @@ module_param(force, bool, 0444); > static bool force; > module_param(force, bool, 0444); > MODULE_PARM_DESC(force, "Force loading on boards without a convertible DMI chassis-type"); > > +static const struct dmi_system_id lenovo_ymc_nosupport_dmi_table[] = { > + { > + /* > + * Yoga Book 9 14IAH10: SW_TABLET_MODE is reported by the > + * yb9-kbdock driver. Suppress lenovo-ymc on this machine to > + * avoid userspace seeing two input nodes that both advertise > + * the SW_TABLET_MODE capability. > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_NAME, "83KJ"), > + }, > + }, > + { } > +}; > + > static const struct dmi_system_id allowed_chasis_types_dmi_table[] = { > { > .matches = { > @@ -100,7 +116,10 @@ static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx) > struct lenovo_ymc_private *priv; > struct input_dev *input_dev; > int err; > > + if (dmi_check_system(lenovo_ymc_nosupport_dmi_table)) > + return -ENODEV; > + > if (!dmi_check_system(allowed_chasis_types_dmi_table)) { > if (force) > dev_info(&wdev->dev, "Force loading Lenovo YMC support\n"); > -- > 2.54.0