From: michael.christie@oracle.com
To: Bodo Stroesser <bostroesser@gmail.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: target: configfs: Remove redundant assignment to ret
Date: Fri, 30 Apr 2021 10:40:20 -0500 [thread overview]
Message-ID: <90e67d9f-e524-62b4-df04-2ea2ea28559c@oracle.com> (raw)
In-Reply-To: <69ef77bd-4ef8-6446-8192-6d8569516f33@gmail.com>
On 4/30/21 9:29 AM, Bodo Stroesser wrote:
> BTW: why is "initiator_sid" input handled as string?
> core_scsi3_alloc_aptpl_registration later calls get_unaligned_be64 for
> that string. I don't think this makes sense.
It's broken.
Remember the isid patches that you reviewed of mine trying to fix the
isid code in target_core_transport.c? I can't remember all the details but
I think it was that the aptpl code thinks the buffer is in the format that
sess_get_initiator_sid uses and is trying to do something similar as
target_core_transport.c.
I can't find the version of the patches you had looked at. This was the first
version of the patch:
https://patchwork.kernel.org/project/target-devel/patch/1531696591-8558-3-git-send-email-mchristi@redhat.com/
next prev parent reply other threads:[~2021-04-30 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 9:23 Jiapeng Chong
2021-04-30 14:29 ` Bodo Stroesser
2021-04-30 15:40 ` michael.christie [this message]
2021-04-30 15:43 ` Bodo Stroesser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e67d9f-e524-62b4-df04-2ea2ea28559c@oracle.com \
--to=michael.christie@oracle.com \
--cc=bostroesser@gmail.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®