From: "Chen, Yu C" <yu.c.chen@intel.com>
To: Adam Li <adamli@os.amperecomputing.com>
Cc: <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
<bsegall@google.com>, <mgorman@suse.de>, <vschneid@redhat.com>,
<cl@linux.com>, <linux-kernel@vger.kernel.org>,
<patches@amperecomputing.com>, <shkaushik@amperecomputing.com>,
<mingo@redhat.com>, <peterz@infradead.org>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>
Subject: Re: [PATCH RESEND] sched/fair: Only update stats for allowed CPUs when looking for dst group
Date: Sun, 12 Oct 2025 01:42:30 +0800 [thread overview]
Message-ID: <90e7343e-7741-45d8-b076-d3852d1870fb@intel.com> (raw)
In-Reply-To: <20251011064322.8500-1-adamli@os.amperecomputing.com>
On 10/11/2025 2:43 PM, Adam Li wrote:
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index bc0b7ce8a65d..d5ec15050ebc 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -10671,7 +10671,7 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd,
> if (sd->flags & SD_ASYM_CPUCAPACITY)
> sgs->group_misfit_task_load = 1;
>
> - for_each_cpu(i, sched_group_span(group)) {
> + for_each_cpu_and(i, sched_group_span(group), p->cpus_ptr) {
Looks good to me. One minor question, would pre-calculating the mask be
better?
Copied from select_idle_cpu():
cpus = this_cpu_cpumask_var_ptr(select_rq_mask);
cpumask_and(cpus, sched_group_span(sd), p->cpus_ptr);
for_each_cpu(i, cpus) {
thanks,
Chenyu
next prev parent reply other threads:[~2025-10-11 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 6:43 Adam Li
2025-10-11 17:42 ` Chen, Yu C [this message]
2025-10-14 10:51 ` Adam Li
2025-10-14 12:07 ` Chen, Yu C
2025-10-15 10:10 ` Adam Li
2025-10-14 11:37 ` Peter Zijlstra
2025-10-15 8:41 ` Chen Yu
2025-10-16 9:33 ` [tip: sched/core] " tip-bot2 for Adam Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e7343e-7741-45d8-b076-d3852d1870fb@intel.com \
--to=yu.c.chen@intel.com \
--cc=adamli@os.amperecomputing.com \
--cc=bsegall@google.com \
--cc=cl@linux.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patches@amperecomputing.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shkaushik@amperecomputing.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®