From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbeDXRuf (ORCPT ); Tue, 24 Apr 2018 13:50:35 -0400 Received: from thoth.sbs.de ([192.35.17.2]:47595 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbeDXRud (ORCPT ); Tue, 24 Apr 2018 13:50:33 -0400 Subject: Re: [PATCH] of: overlay: Stop leaking resources on overlay removal To: Frank Rowand , Pantelis Antoniou , Rob Herring , devicetree Cc: Linux Kernel Mailing List , Alan Tull References: <097f1b01-6cb4-8dcb-0498-7b4c59a7ea53@siemens.com> <7aca82c1-a02c-2f84-bc32-6e8a118ba601@gmail.com> From: Jan Kiszka Openpgp: preference=signencrypt Message-ID: <90e7da9d-d40a-17f1-e627-873f58a3dce5@siemens.com> Date: Tue, 24 Apr 2018 19:50:27 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <7aca82c1-a02c-2f84-bc32-6e8a118ba601@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-04-24 19:44, Frank Rowand wrote: > On 04/24/18 09:19, Jan Kiszka wrote: >> Only the overlay notifier callbacks have a chance to potentially get >> hold of references to those two resources, but they do not store them. >> So it is safe to stop the intentional leaking. >> >> See also https://lkml.org/lkml/2018/4/23/1063 and following. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Ideally, we sort out any remaining worries during the 4.17-rc cycle. >> >> drivers/of/overlay.c | 13 ++----------- >> 1 file changed, 2 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c >> index b35fe88f1851..3553f1f57a62 100644 >> --- a/drivers/of/overlay.c >> +++ b/drivers/of/overlay.c >> @@ -671,17 +671,8 @@ static void free_overlay_changeset(struct overlay_changeset *ovcs) >> of_node_put(ovcs->fragments[i].overlay); >> } >> kfree(ovcs->fragments); >> - >> - /* >> - * TODO >> - * >> - * would like to: kfree(ovcs->overlay_tree); >> - * but can not since drivers may have pointers into this data >> - * >> - * would like to: kfree(ovcs->fdt); >> - * but can not since drivers may have pointers into this data >> - */ >> - >> + kfree(ovcs->overlay_tree); >> + kfree(ovcs->fdt); >> kfree(ovcs); >> } >> >> > > Nack. It is premature to submit this while the conversation is > continuing in the other thread. > > I'll continue the conversation in the other thread. > Well, at least the strongest argument has been resolved now, the notifier topic. Curious to learn what remains. As I noted, we should work hard to sort out the API regression prior to the release. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux