From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD504C43464 for ; Tue, 28 Jul 2020 23:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DEF5207FC for ; Tue, 28 Jul 2020 23:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730374AbgG1XGP (ORCPT ); Tue, 28 Jul 2020 19:06:15 -0400 Received: from smtprelay0009.hostedemail.com ([216.40.44.9]:42968 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730323AbgG1XGN (ORCPT ); Tue, 28 Jul 2020 19:06:13 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id DF3A3182CED5B; Tue, 28 Jul 2020 23:06:11 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: swing96_0a091fa26f6d X-Filterd-Recvd-Size: 5557 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 28 Jul 2020 23:06:10 +0000 (UTC) Message-ID: <90f4d174d8a2d50104ad52aa0bd4e0ece86f2e90.camel@perches.com> Subject: Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member" From: Joe Perches To: "Winkler, Tomas" , "Gustavo A. R. Silva" , Greg Kroah-Hartman Cc: "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" , "Gustavo A . R . Silva" Date: Tue, 28 Jul 2020 16:06:08 -0700 In-Reply-To: <398e20e8c3f7436bb50d671b9aa9f809@intel.com> References: <20200728214139.3129532-1-tomas.winkler@intel.com> <8ec7601780b542c2bc0168e03749ec0e@intel.com> <398e20e8c3f7436bb50d671b9aa9f809@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-07-28 at 22:14 +0000, Winkler, Tomas wrote: > > -----Original Message----- > > From: Gustavo A. R. Silva [] > > I'm using this command: > > > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback > > > > and this is the output for both files: > > > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback > > drivers/misc/mei/hdcp/mei_hdcp.c Arnd Bergmann > > (supporter:CHAR and MISC DRIVERS) Greg Kroah-Hartman > > (supporter:CHAR and MISC DRIVERS) linux- > > kernel@vger.kernel.org (open list) $ scripts/get_maintainer.pl --nokeywords -- > > nogit --nogit-fallback drivers/misc/mei/hdcp/mei_hdcp.h Arnd Bergmann > > (supporter:CHAR and MISC DRIVERS) Greg Kroah-Hartman > > (supporter:CHAR and MISC DRIVERS) linux- > > kernel@vger.kernel.org (open list) > > For some reason you don't appear on the list above. Do you see anything > > wrong with the command I'm running to get the maintainers and lists? > > Not sure, it should be caught by drivers/misc/mei/* ? No, this pattern matches _only_ files in that particular directory and not any files in any subdirectory. > Maybe it is not recursive? It depends on the pattern. Patterns with trailing slashes match subdirectories too. from MAINTAINERS: F: *Files* and directories wildcard patterns. A trailing slash includes all files and subdirectory files. F: drivers/net/ all files in and below drivers/net F: drivers/net/* all files in drivers/net, but not below F: */net/* all files in "any top level directory"/net One pattern per line. Multiple F: lines acceptable. > Need to check the script, > frankly I usually check this manually. prob > > INTEL MANAGEMENT ENGINE (mei) > M: Tomas Winkler > L: linux-kernel@vger.kernel.org > S: Supported > F: Documentation/driver-api/mei/* > F: drivers/misc/mei/* You probably want: F: drivers/misc/mei/ > F: drivers/watchdog/mei_wdt.c > F: include/linux/mei_cl_bus.h > F: include/uapi/linux/mei.h > F: samples/mei/* > > > > Thanks > > -- > > Gustavo > > > > > > > I really do not appreciate that the code is bypassing driver > > > > > maintaner review, I think this is a minimum we can ask for, this is > > > > > not for a first time. > > > > > > > > > > This reverts commit c56967d674e361ebe716e66992e3c5332b25ac1f. > > > > > > > > > > Cc: Gustavo A. R. Silva > > > > > Signed-off-by: Tomas Winkler > > > > > --- > > > > > drivers/misc/mei/hdcp/mei_hdcp.c | 2 +- > > > > > drivers/misc/mei/hdcp/mei_hdcp.h | 2 +- > > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c > > > > > b/drivers/misc/mei/hdcp/mei_hdcp.c > > > > > index d1d3e025ca0e..e6c3dc595617 100644 > > > > > --- a/drivers/misc/mei/hdcp/mei_hdcp.c > > > > > +++ b/drivers/misc/mei/hdcp/mei_hdcp.c > > > > > @@ -572,7 +572,7 @@ static int mei_hdcp_verify_mprime(struct device > > > > *dev, > > > > > HDCP_2_2_MPRIME_LEN); > > > > > drm_hdcp_cpu_to_be24(verify_mprime_in.seq_num_m, data- > > seq_num_m); > > > > > memcpy(verify_mprime_in.streams, data->streams, > > > > > - array_size(data->k, sizeof(*data->streams))); > > > > > + (data->k * sizeof(struct hdcp2_streamid_type))); > > > > > > > > > > verify_mprime_in.k = cpu_to_be16(data->k); > > > > > > > > > > diff --git a/drivers/misc/mei/hdcp/mei_hdcp.h > > > > > b/drivers/misc/mei/hdcp/mei_hdcp.h > > > > > index 834757f5e072..18ffc773fa18 100644 > > > > > --- a/drivers/misc/mei/hdcp/mei_hdcp.h > > > > > +++ b/drivers/misc/mei/hdcp/mei_hdcp.h > > > > > @@ -358,7 +358,7 @@ struct wired_cmd_repeater_auth_stream_req_in > > { > > > > > u8 > > > > seq_num_m[HDCP_2_2_SEQ_NUM_LEN]; > > > > > u8 m_prime[HDCP_2_2_MPRIME_LEN]; > > > > > __be16 k; > > > > > - struct hdcp2_streamid_type streams[]; > > > > > + struct hdcp2_streamid_type streams[1]; > > > > > } __packed; > > > > > > > > > > struct wired_cmd_repeater_auth_stream_req_out { > > > > >