From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26884C38A02 for ; Sat, 29 Oct 2022 14:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbiJ2OXt (ORCPT ); Sat, 29 Oct 2022 10:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbiJ2OXc (ORCPT ); Sat, 29 Oct 2022 10:23:32 -0400 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [IPv6:2001:4b7a:2000:18::171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E0266F26 for ; Sat, 29 Oct 2022 07:21:55 -0700 (PDT) Received: from [192.168.1.101] (95.49.29.156.neoplus.adsl.tpnet.pl [95.49.29.156]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id AB0023EBD1; Sat, 29 Oct 2022 16:21:53 +0200 (CEST) Message-ID: <90f5d5a8-eae6-f891-2169-aed62b0ee325@somainline.org> Date: Sat, 29 Oct 2022 16:21:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 11/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} ADC_TM5 channels Content-Language: en-US To: Manivannan Sadhasivam , andersson@kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org References: <20221029051449.30678-1-manivannan.sadhasivam@linaro.org> <20221029051449.30678-12-manivannan.sadhasivam@linaro.org> From: Konrad Dybcio In-Reply-To: <20221029051449.30678-12-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.10.2022 07:14, Manivannan Sadhasivam wrote: > Add ADC_TM5 channels of PM8280_{1/2} for monitoring the temperature from > external thermistors connected to AMUX pins. The temperture measurements > are collected from the PMK8280's VADC channels that expose the > measurements from secondary PMICs PM8280_{1/2}. > > Signed-off-by: Manivannan Sadhasivam > --- > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 9545b471c2fa..ca77c19c6d0d 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -259,6 +259,74 @@ pmic-die-temp@403 { > }; > }; > > +&pmk8280_adc_tm { > + status = "okay"; > + > + sys-therm@0 { > + reg = <0>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM1_100K_PU(1)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; If you decide to change the order in the prev patches, it applies here too. Otherwise: Reviewed-by: Konrad Dybcio Konrad > + }; > + > + sys-therm@1 { > + reg = <1>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM2_100K_PU(1)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > + > + sys-therm@2 { > + reg = <2>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM3_100K_PU(1)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > + > + sys-therm@3 { > + reg = <3>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM4_100K_PU(1)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > + > + sys-therm@4 { > + reg = <4>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM1_100K_PU(3)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > + > + sys-therm@5 { > + reg = <5>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM2_100K_PU(3)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > + > + sys-therm@6 { > + reg = <6>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM3_100K_PU(3)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > + > + sys-therm@7 { > + reg = <7>; > + io-channels = <&pmk8280_vadc PM8350_ADC7_AMUX_THM4_100K_PU(3)>; > + qcom,avg-samples = <2>; > + qcom,ratiometric; > + qcom,hw-settle-time-us = <200>; > + }; > +}; > + > &qup0 { > status = "okay"; > };