From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbdBJHNA (ORCPT ); Fri, 10 Feb 2017 02:13:00 -0500 Received: from seldsegrel01.sonyericsson.com ([37.139.156.29]:9020 "EHLO SELDSEGREL01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbdBJHM7 (ORCPT ); Fri, 10 Feb 2017 02:12:59 -0500 Subject: Re: [PATCH 1/3 v2 staging-next] android: Collect statistics from lowmemorykiller To: Greg Kroah-Hartman References: <20170209201329.GA12148@kroah.com> CC: , , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Linus Torvalds , From: peter enderborg Message-ID: <90fbd714-df4d-8c91-b2cc-927492b6c838@sonymobile.com> Date: Fri, 10 Feb 2017 08:12:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170209201329.GA12148@kroah.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2017 09:13 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 09, 2017 at 04:42:35PM +0100, peter enderborg wrote: >> This collects stats for shrinker calls and how much >> waste work we do within the lowmemorykiller. >> >> Signed-off-by: Peter Enderborg >> --- >> drivers/staging/android/Kconfig | 11 ++++ >> drivers/staging/android/Makefile | 1 + >> drivers/staging/android/lowmemorykiller.c | 9 ++- >> drivers/staging/android/lowmemorykiller_stats.c | 85 +++++++++++++++++++++++++ >> drivers/staging/android/lowmemorykiller_stats.h | 29 +++++++++ >> 5 files changed, 134 insertions(+), 1 deletion(-) >> create mode 100644 drivers/staging/android/lowmemorykiller_stats.c >> create mode 100644 drivers/staging/android/lowmemorykiller_stats.h > What changed from v1? Nothing. I thought I found the reason why my tabs are replaced by spaces in transport. >> @@ -72,6 +73,7 @@ static unsigned long lowmem_deathpending_timeout; >> static unsigned long lowmem_count(struct shrinker *s, >> struct shrink_control *sc) >> { >> + lmk_inc_stats(LMK_COUNT); >> return global_node_page_state(NR_ACTIVE_ANON) + >> global_node_page_state(NR_ACTIVE_FILE) + >> global_node_page_state(NR_INACTIVE_ANON) + > Your email client is eating tabs and spitting out spaces, making this > impossible to even consider being merged :( > > Please fix your email client, documentation for how to do so is in the > kernel Documentation directory. > > thanks, > > greg k-h