From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F8EC27C76 for ; Fri, 20 Jan 2023 10:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbjATKdZ (ORCPT ); Fri, 20 Jan 2023 05:33:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjATKdU (ORCPT ); Fri, 20 Jan 2023 05:33:20 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4562B9B11A; Fri, 20 Jan 2023 02:33:13 -0800 (PST) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 30KAX0b0125334; Fri, 20 Jan 2023 04:33:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1674210780; bh=HP2xLw269Gp7Sa//mR41L4KDctGIpf5WTOz57YV+kJU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=U/3GfRbni9J6d95RE6cYEKqx8P7II0yWn6u+GnsifrqHu3G5ez8OHLwgdLeR1cK0J yPUfAEIFNmdwkV51fOqMrYlV3AGCup9FiYSdJyZteUmRe6fHwXjk9foC98W3GlMFB7 cJdWzUqXq7NvrX1HoBX/NLXevg8xEJCCBnHZQX/M= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 30KAX0Pk018627 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Jan 2023 04:33:00 -0600 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 20 Jan 2023 04:33:00 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 20 Jan 2023 04:33:00 -0600 Received: from [172.24.145.182] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 30KAWutX005968; Fri, 20 Jan 2023 04:32:57 -0600 Message-ID: <90fe0c56-0179-0be1-7a7c-91c26a1eedb6@ti.com> Date: Fri, 20 Jan 2023 16:02:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] arch: arm64: dts: Add support for AM69 Starter Kit Content-Language: en-US To: Krzysztof Kozlowski , , , , , , CC: , , , Dasnavis Sabiya References: <20230119132958.124435-1-sabiya.d@ti.com> <20230119132958.124435-3-sabiya.d@ti.com> <802ae1e3-8046-675d-cf4e-d3468604a3e8@linaro.org> From: Vignesh Raghavendra In-Reply-To: <802ae1e3-8046-675d-cf4e-d3468604a3e8@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 19/01/23 19:06, Krzysztof Kozlowski wrote: > On 19/01/2023 14:29, sabiya.d@mistralsolutions.com wrote: >> From: Dasnavis Sabiya >> >> AM69 Starter Kit is a single board designed for TI AM69 SOC that >> provides advanced system integration in automotive ADAS applications, >> autonomous mobile robot and edge AI applications. The SOC comprises >> of Cortex-A72s in dual clusters, lockstep capable dual Cortex-R5F MCUs, >> Vision Processing Accelerators (VPAC) with Image Signal Processor (ISP) >> and multiple vision assist accelerators, Depth and Motion Processing >> Accelerators (DMPAC), Deep-learning Matrix Multiply Accelerator(MMA) >> and C7x floating point vector DSP >> >> AM69 SK supports the following interfaces: >> * 32 GB LPDDR4 RAM >> * x1 Gigabit Ethernet interface >> * x3 USB 3.0 Type-A ports >> * x1 USB 3.0 Type-C port >> * x1 UHS-1 capable micro-SD card slot >> * x4 MCAN instances >> * 32 GB eMMC Flash >> * 512 Mbit OSPI flash >> * x2 Display connectors >> * x1 PCIe M.2 M Key >> * x1 PCIe M.2 E Key >> * x1 4L PCIe Card Slot >> * x3 CSI2 Camera interface >> * 40-pin Raspberry Pi header >> >> Add initial support for the AM69 SK board. > > Thank you for your patch. There is something to discuss/improve. > >> >> Design Files: https://www.ti.com/lit/zip/SPRR466 >> TRM: https://www.ti.com/lit/zip/spruj52 >> >> Signed-off-by: Dasnavis Sabiya >> --- >> arch/arm64/boot/dts/ti/Makefile | 1 + >> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 180 ++++++++++++++++++++++++++ >> 2 files changed, 181 insertions(+) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am69-sk.dts >> >> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile >> index e7c2c7dd0b25..04b1a7611096 100644 >> --- a/arch/arm64/boot/dts/ti/Makefile >> +++ b/arch/arm64/boot/dts/ti/Makefile >> @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb >> >> dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb >> >> +dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb > > I was told the order of entries here is "time of release". Is it > correct? This is the order you want to keep here and am69-sk was > released after j721s2-common-proc-board but before j784s4-evm? Unfortunately, files are not in any particular order at the moment. Currently, entries are grouped into a block based upon SoC present on them. Boards within the family block are sorted alphabetically. But the block of SoCs itself is arranged in no particular order. I would like to propose to cleanup this file such that board dtbs are grouped as per SoC present on them (like now), sort the group alphabetically. Also then sort alphabetically within the family (similar how boards appear in dt bindings) Will do that towards end of rc6 once these patches are queued up to avoid merge conflicts. > >> dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb >> > > > Best regards, > Krzysztof > -- Regards Vignesh