From: Reinette Chatre <reinette.chatre@intel.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] x86/resctrl: Fix kernel-doc in internal.h
Date: Fri, 18 Jun 2021 13:37:08 -0700 [thread overview]
Message-ID: <9100bce9-d27f-23e7-f5b5-2a6468a6b3bd@intel.com> (raw)
In-Reply-To: <20210616184330.13301-1-fmdefrancesco@gmail.com>
Hi Fabio,
On 6/16/2021 11:43 AM, Fabio M. De Francesco wrote:
> @@ -78,10 +79,13 @@ struct mon_evt {
> };
>
> /**
> - * struct mon_data_bits - Monitoring details for each event file
> - * @rid: Resource id associated with the event file.
> + * union mon_data_bits - Monitoring details for each event file
> + * @priv: Used to store monitoring event data in @u
> + * as kernfs private data
> + * @rid: Resource id associated with the event file
> * @evtid: Event id associated with the event file
> * @domid: The domain to which the event file belongs
> + * @u: Name of the bit fields struct
> */
> union mon_data_bits {
> void *priv;
This hunk continues to be whitespace broken. You are adding tabs when
existing comments use spaces. Please ensure that your changes fit with
the current style in this area.
Reinette
prev parent reply other threads:[~2021-06-18 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:43 Fabio M. De Francesco
2021-06-18 20:37 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9100bce9-d27f-23e7-f5b5-2a6468a6b3bd@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=fmdefrancesco@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®