From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39DC635F197 for ; Tue, 16 Jun 2026 20:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781642827; cv=none; b=E6I/87/RmM3K2iXq/Qi9OnKthEX5rQs2icCavZBy1wvbKYsikk166PpdZT10gF5/68+Vk0fNvvscYC3vU2AVbFzjoK+Ys73+IGT9dNlcUls4ptRuBFcrZmqh+WZcOTee8BZbrbJkIzqfusRaLhp497zgB+/F51hGovc1rCVkn2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781642827; c=relaxed/simple; bh=55ubhwgPFP/ggX+sEQoWYZsZ9CMeijE8qXL6+9SVM4U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QU9XMrV440WZRFAXI9ysK+EGouDCHEMuIw51xktsQ4HSttbC6oBozN65F0zbjxlVMKbDhq9DPqYmnbf5KT2THvaIgUmuLmFyIsZzBbmj6nZI/1ZCAR7UzUv2CK+9mDYTKnBgn7uxZu7oTk8Q+MDXPskZyKwNHv7SY3E8h64/8so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=Py9mUpUd; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="Py9mUpUd" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-43cce34c881so4357694fac.2 for ; Tue, 16 Jun 2026 13:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1781642823; x=1782247623; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N3bsbmxS4GadL4Z4bToRsBD+Gi0dvukUshOqKGVXCG8=; b=Py9mUpUdWt5vXOQMHpSDFKNdc07dV8zSmKyrmmqNUKFTu/VSDcSGSFT/b2qqNsW69W SNSwSPbiHJsW7x7URUBqDzziXp+n1NzryTK6BcpA4Rp1Nra3/rgmAqE1ch2zhzeu30wP e1wZ/1W1k+2sVKyjipQ8CzHQw2tNo2TI0UXy5fhdoeYEJPL9fckaT7oF38Oax4pwssJK 0MUYJxjS5vtn2bFYV+tidJ0pp8MVx6j2bH6L5OgHnqOA5K9+Brdd+NsaYlPCCw2f4h8W ODsQ5gbidbn8t2I5yA/Zgp1SMqBzcNCcFo72ar7wJ6jooOBG+XkY527bxxeVUQFJ9PNA B29Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781642823; x=1782247623; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N3bsbmxS4GadL4Z4bToRsBD+Gi0dvukUshOqKGVXCG8=; b=IESkbGZeDD8SG1DxXF1m4k3DNPYbTrP8qb9l/p9uMNIEZtfxduJO9AnxPOQ0I474VS v7PVu9yvN4f7ltP1rrKPbN5u51JaZulPQZXiWNn24rkJ+y8q5v6SxnrTHAu+nMVOGRFv nunYD3qjApbCTy4FwgQXEFbJDVDdWUarSAOukkG5ZeU4bir9nJFlbXEZgTaR4kWh7OUp aMTtCNypDGVhks7njW3MWxT/8X6A/Lxlapzn4GrDxAyn9pSz5sXnL+0DKhVM772IrXPL q5uzNI8fHSVTn4D9/3NaDYKj/HvtxdHW7l3MM0yZ19E6iNh00EGE3jylgCPCbSm5bZNI oMNQ== X-Forwarded-Encrypted: i=1; AFNElJ+RunT+tiilQ1nMiqojfkpRqXhR7D7Y5TeWKn5Q7C0+907bK11wkDAUHtKbrc2tYNhepZchB1rUkv0zBoI=@vger.kernel.org X-Gm-Message-State: AOJu0YzuB8EqRsEtEm4XkyEBpt1nwImXmctpP0H/ccwkd23qQHP1ZI3B 3AzXF9o+vuSEtOWDk392ppOtCAKWi/GXr3t6XcHBQ+pRgXot2mYVJzXhZiV5cy67NVeUrHVtgyB ru085d+4= X-Gm-Gg: Acq92OH6/sbeuBvD2lbNZhql3TAzHzXHSjWun7of2zofGks59Db6fvDA9N+DwsSdJFv M0zU0iiGiv3UVNYktvpp+HpInh8V6bc4za4vJ60C4sLOceJ911N5mnSQ5F6z9c8D/klHNI07uHy 6fBcq8oAhIWIh3gwH7LbEl6jLq7oFWlVLhLeCFUiT/HKoAkou3q0u0pI/hOlVH4IRxnP7L7jCwv niAzrHG+IZPFy6w3eTku5BsHHNf7lgZmXzzJzFqu1a/T3/qIue428Y3APmoIwwsn5CRTQrIIqFR pUzGBZjqG4bKNeJCSFD0tV43gsA2gw5TEuXBnLnWbPdqN6nqCAhjBpawBy1AEidcCwWCr3ibf4q Rjebu2VsGkLLTfrkiqZhxDtgqvApBu978T4GabZ+iyKp/lDRsu+aj95OylVKMDrwDmHCxDzH4aR V+ZaVPx24e7dibVHQNdlA8EUNqkB95efJsJzY+7bdiQgFcG6eoLDLlD2bMM3Ad6/siQqxCtAqnP zRhvf4elw== X-Received: by 2002:a05:6871:538a:b0:442:175:cea7 with SMTP id 586e51a60fabf-4469010a70amr626699fac.1.1781642823167; Tue, 16 Jun 2026 13:47:03 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-443090386basm2851306fac.17.2026.06.16.13.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 13:47:02 -0700 (PDT) Message-ID: <910230d8-6a14-4d56-9520-169bd379f3d2@kernel.dk> Date: Tue, 16 Jun 2026 14:47:00 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 1/2] iov_iter: export iov_iter_restore To: Octavian Purdila , netdev@vger.kernel.org Cc: Alexander Viro , Andrew Morton , Arseniy Krasnov , "David S. Miller" , Eric Dumazet , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jakub Kicinski , Jason Wang , kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Paolo Abeni , Simon Horman , Stefan Hajnoczi , Stefano Garzarella , virtualization@lists.linux.dev, Xuan Zhuo References: <20260613000953.467473-1-tavip@google.com> <20260613000953.467473-2-tavip@google.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260613000953.467473-2-tavip@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/12/26 6:09 PM, Octavian Purdila wrote: > Export iov_iter_restore so that it can be used by modules. > > This is needed by the virtio vsock transport (which can be built as a > module) to restore the msg_iter state when transmission fails. > > Signed-off-by: Octavian Purdila > --- > lib/iov_iter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/iov_iter.c b/lib/iov_iter.c > index 243662af1af73..067e745f9ef53 100644 > --- a/lib/iov_iter.c > +++ b/lib/iov_iter.c > @@ -1491,6 +1491,7 @@ void iov_iter_restore(struct iov_iter *i, struct iov_iter_state *state) > i->__iov -= state->nr_segs - i->nr_segs; > i->nr_segs = state->nr_segs; > } > +EXPORT_SYMBOL(iov_iter_restore); I don't have a problem exporting this to modules, but any new export should be _GPL. So please change it to that. -- Jens Axboe