From: bot+bpf-ci@kernel.org
To: andrew@amutable.com,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,agk@redhat.com,snitzer@kernel.org,mpatocka@redhat.com,bmarzins@redhat.com,dhowells@redhat.com,jarkko@kernel.org,paul@paul-moore.com,jmorris@namei.org,serge@hallyn.com,ebiggers@kernel.org,tytso@mit.edu,corbet@lwn.net,skhan@linuxfoundation.org,rdunlap@infradead.org
Cc: dm-devel@lists.linux.dev,linux-kernel@vger.kernel.org,keyrings@vger.kernel.org,linux-security-module@vger.kernel.org,bpf@vger.kernel.org,fsverity@lists.linux.dev,linux-doc@vger.kernel.org,andrew@amutable.com,brauner@kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next v2 1/3] keys: add KEY_SPEC_DM_VERITY_KEYRING
Date: Thu, 8 Oct 2026 21:44:46 +0000 (UTC) [thread overview]
Message-ID: <910460850fd4163dadb804fbdf6c17f6a9dfec060f4d865a17df87336ea3e165@mail.kernel.org> (raw)
In-Reply-To: <20261008-ajhalaney-dmverity-key-identifier-v2-1-008456d189cb@amutable.com>
[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]
> keys: add KEY_SPEC_DM_VERITY_KEYRING
TL;DR: Design/uapi question: was David Howells' v1 suggestion (reserved
negative key ID block, common register functions) intentionally dropped? The
new uapi value -10 should be settled before release.
> diff --git a/include/uapi/linux/keyctl.h b/include/uapi/linux/keyctl.h
> --- a/include/uapi/linux/keyctl.h
> +++ b/include/uapi/linux/keyctl.h
> @@ -25,6 +25,7 @@
> #define KEY_SPEC_REQKEY_AUTH_KEY -7 /* - key ID for assumed request_key auth key */
> #define KEY_SPEC_REQUESTOR_KEYRING -8 /* - key ID for request_key() dest keyring */
> #define KEY_SPEC_BPF_KEYRING -9 /* - key ID for the BPF-specific keyring */
> +#define KEY_SPEC_DM_VERITY_KEYRING -10 /* - key ID for the .dm-verity keyring */
On v1, David Howells wrote:
I have no particular objection to setting aside a block of negative key
IDs for special keyrings that need to be accessed a lot - though I would
make common reg/unreg functions that take the ID to be registered and,
say, set the block at -257..-512. Moving the BFP keyring to -257 and
DM to -258.
(<715249.1789718726@warthog.procyon.org.uk>)
The question of whether this was being asked for v2 was raised in reply, but
there was no answer, and this version still continues the one-off -9/-10
sequence with a dm-verity specific key_register_dm_verity_keyring() and
dm_verity_keyring_lock.
Was the suggestion to use a reserved ID block with common register and
unregister functions intentionally dropped, or should it still be addressed?
Since KEY_SPEC_DM_VERITY_KEYRING is a UAPI value, would it be possible to
settle this before the -10 value is released?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/37844805282
next prev parent reply other threads:[~2026-10-08 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 20:57 [PATCH bpf-next v2 0/3] keys: Add well known IDs for fs-verity/dm-verity keys Andrew Halaney
2026-10-08 20:57 ` [PATCH bpf-next v2 1/3] keys: add KEY_SPEC_DM_VERITY_KEYRING Andrew Halaney
2026-10-08 21:44 ` bot+bpf-ci [this message]
2026-10-08 21:57 ` Andrew Halaney
2026-10-11 9:35 ` Manuel Huber
2026-10-12 13:12 ` Christian Brauner
2026-10-12 17:14 ` Manuel Huber
2026-10-08 20:57 ` [PATCH bpf-next v2 2/3] keys: add KEY_SPEC_FS_VERITY_KEYRING Andrew Halaney
2026-10-08 20:57 ` [PATCH bpf-next v2 3/3] Documentation: keys: document IDs added since KEY_SPEC_REQKEY_AUTH_KEY Andrew Halaney
2026-10-12 10:38 ` [PATCH bpf-next v2 0/3] keys: Add well known IDs for fs-verity/dm-verity keys Christian Brauner
2026-10-16 0:38 ` Alexei Starovoitov
2026-10-16 8:27 ` Christian Brauner
2026-10-16 14:53 ` Alexei Starovoitov
2026-10-18 15:49 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=910460850fd4163dadb804fbdf6c17f6a9dfec060f4d865a17df87336ea3e165@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=agk@redhat.com \
--cc=andrew@amutable.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bmarzins@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=eddyz87@gmail.com \
--cc=fsverity@lists.linux.dev \
--cc=ihor.solodrai@linux.dev \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=mpatocka@redhat.com \
--cc=paul@paul-moore.com \
--cc=rdunlap@infradead.org \
--cc=serge@hallyn.com \
--cc=skhan@linuxfoundation.org \
--cc=snitzer@kernel.org \
--cc=tytso@mit.edu \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®