From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDCA3BD64E for ; Mon, 11 May 2026 09:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778491255; cv=none; b=AXg2JS4ljt3vVUwzxoc7JX6xKyWqjCNj8TbSdxU2p3Kq0laj8N1c0vY1QiClqnuLwEhFKBgGbqi+kP/JheudhwKc3sb/r8c2d1FiYlpgMjL/H4XvP1K72iL9eH7LhpEza+6C8uiL17C4oq6n5MqLz1cTPwRceVqeqTOUZkFOwfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778491255; c=relaxed/simple; bh=SpTDGbdvTc18UyL3DOpIzK5PBThgc3A8Zu4M14UXk68=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TUoNeYEA1V6yvmyxGxKaxxoiqsMWy9SjjQ6vz/7N5bkVgXPTtqLLRrSzygy/kCm1gxdAmeqoJEEo4wTI5EYQlukBUqYmvRy0kBFh1DIE0qKt+Gx8wQqc7ovrgEZFY0ZAasqIy60yi0S+0+fXMqDdvdaFhR/e75mMzHoFISFO07Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ICsgLT+Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S5olRLmX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ICsgLT+Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S5olRLmX" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B7A6wp1258560 for ; Mon, 11 May 2026 09:20:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xXimfsnLc93d9P+AWFCnUGcMd4c3BkbDrYHZZJMoFU0=; b=ICsgLT+Yf9GvxQ7b Uev6xyRrAiQcnqfoLOaJvAyn0YW5rI1/EIhgv4Vrx+cYV6UaizTtyPKEIyIO6uYH 5nTbB7Fqh9z+ttHKDexOgZKxknDL+PC8XKoDKQNUMNFm8M1AYPODmWQaQdnPkaIl PohERZ5eLUo07jGhsmNGCtO7Roy1cA0erimSmj9l11IgjCflA8mxtT3I/8NUARZU FURqOMcp1kRMyBnIiafcYnWtB1DP2akl/DcyPwkRdycbwLxQsHlnDb2n6/LLQ1EG SfMmCc2AcaWeWKm9gsAmzUV6J75nz0SS6Xm11HSA2GNC0Q0OvhQNB8p1PU3nc641 36aZtg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3ag20fgj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 09:20:52 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ba86e35aa1so61831575ad.1 for ; Mon, 11 May 2026 02:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778491252; x=1779096052; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xXimfsnLc93d9P+AWFCnUGcMd4c3BkbDrYHZZJMoFU0=; b=S5olRLmXRaPAwGfAJCGmfVPM9+J0C3kWpoJTt4nLK2pgsuXYD7ft+yYHWKylfKahMz W7JCrYLvspE6Hay3x5v6/Z4ZorhOoqQpduOaWhp8x/JZbVZRmOmmGRWET20/kRl970xn w3Qo4RuSFcZ8bwt5TOKz1Ydpgn06NBqr6N3ap4PfbVkML9BC7xSERfYYD43QWa/OAejI pza6DUdCatYbrlfJXrsO1CawHjz6u57EcuONLmKjIpawZ7ROOk4x7il3w/WFRTJF2u6F T7xRSnuSrJDMatFS54jGaLIUCwFE3Ho2Zx21HDq87a9FSw5lEkQQ54/CQFY+BN+v89DF i4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778491252; x=1779096052; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xXimfsnLc93d9P+AWFCnUGcMd4c3BkbDrYHZZJMoFU0=; b=GzYxsdbX5fSixZ9tBFoMAVc5PC9ltOTQz5otU6tP5kyW7ItJix8d1cN7ABycgJy0/o 0koHDWX8/hJqy42ySl7tEulf8cnojKS21nIoyB6klz9XIlrulQRL80R983Ya27rfDOJ/ zKWAtIMhX/KFmFVa6IslPdezFOJU219beqUhAJKR73iSL9RX0Yv1gGWJv5YKJUxtHIIE Pc8qKNCtLxb85+G9EG49dsQ4bCmMjx7y0MMzVLmRAiuOAhmTmrwCU+ScsbtqonO0ZlEh iQK4oOAcOSPVIuq3jENHNqEjLLA7hPPnzlVpQEGcI2y+JjHLT+4ESTg6q52NosgNrCiM zTSg== X-Forwarded-Encrypted: i=1; AFNElJ8L0pz/utgp1orChSUdOoZnj+ql45L7eMvwhmHfmEfhpHwW1cS+EH9QnqiCEhHpcFppuduqANK/6CZbEI0=@vger.kernel.org X-Gm-Message-State: AOJu0YwiACas9EmAA+6W8TCPuEdEbut4jURDuWcLhmFTfB2tRHONC9OP odwfXjUEz4JDPU0bJmVQBCIt1uQQtPEtKNSeC6wtSrCAHFh2hWYbDkM44G2/nVy48Tel+07d+eE nX4+VOFpRLP8RAwmJ7pQPhtoDym4GSRNrQDXzo2tTh/1Y+kgURoWgrYU4OH3Zo3uZUJI= X-Gm-Gg: Acq92OHsuDPBDS/2jhGTZBTPBBxlR5mORhUdfWjRN/4PZ2Sf7NLAHvzei8dGZZg9UDq G5cMIRS1VRToMPk8qXHchFuL+4DkKpjCguBdld7lsMOGfcptrx6Rg1g8llBNMYCVmluh45G9zsB gMF+IJMRjMcbGB9gQMB2vxOF86OtGh10X0QcztC6SYWGGvQRBjQot5yBuszWDXnn9mYg3ZZniWl jojATbQNwAMlMgHQQuyURbXt1QxUTumQ++dqrJHoAMf6LNSMxZnXX3bALeuKbaO0X5gG9rm6Oz1 cMRvNQk3Fcw0yUtmowbOm2oti46NBGgd+fYuWYbD/vz1oCHuw+ftA/rQrZa2bIMvVHCeiYPJTXj tpl3S/PVavbLbs2YLB+PmkoNwMFTXnFYNo1xuR1PMXn4h0+7CflJWlm0V/dICEZSW3jTxu39Oz0 qCGSrvXIqhqw== X-Received: by 2002:a17:902:76c3:b0:2ba:b643:1f81 with SMTP id d9443c01a7336-2bab64320a2mr145141675ad.15.1778491251894; Mon, 11 May 2026 02:20:51 -0700 (PDT) X-Received: by 2002:a17:902:76c3:b0:2ba:b643:1f81 with SMTP id d9443c01a7336-2bab64320a2mr145141435ad.15.1778491251424; Mon, 11 May 2026 02:20:51 -0700 (PDT) Received: from [10.133.33.31] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e3571dsm96251205ad.42.2026.05.11.02.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 02:20:50 -0700 (PDT) Message-ID: <9107c2ad-c4b7-4d2c-97ce-2e20a97518de@oss.qualcomm.com> Date: Mon, 11 May 2026 17:20:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] coresight: fix source not disabled on idr_alloc_u32 failure To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jie Gan References: <20260511-fix-coresight-sysfs-enable-issue-v1-1-1b3829748171@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260511-fix-coresight-sysfs-enable-issue-v1-1-1b3829748171@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: tGnXu6AcihqtmEFmJv8-NpDChLYXjob3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDEwMiBTYWx0ZWRfXzzcdv7v5ObrE D+NQTzElDBDnFBQ1KMQReHYJJkiPEJXgoVuNlEqpGHjKSzu6C/RAT6v2nr1Qi+mh5aezTazHQSu aWSVnD4g8NUrDFOc11rxXgZPSygVvOZMxBrnYezHkUUVE57jlQM2dF08arvn2mTSvUVn7nkmTQZ 0tDQHtd/GpxNeEXc3Ni8l0A8q3+RZA1rzRtmVWCoEPiJSFbndCYzx02seIY67SzwjhNDXUlZeKd GFOM7/cuNerkqgxInepFrzi+UCKIFNeXCE7eH9oLkZTRF3NeSkZpfT7Qe4u2RjRmeTpIsEGn8nJ yiDFiy9AjSafKNCIEU7Fx/09cYeiR2AgRgXflmcouge0BUQFrzbERWb2Ra8sJWhREhToBbIxBb8 ZY/CWZoh14ueTF0P0zUIJfYcHy+oYNy9jgg7Ec3tzAwd6lvs+Uan/RzstrPI/9ds99ZVnt9Kjnp 0FtmObXZWJi77lM4jlQ== X-Proofpoint-GUID: tGnXu6AcihqtmEFmJv8-NpDChLYXjob3 X-Authority-Analysis: v=2.4 cv=NODlPU6g c=1 sm=1 tr=0 ts=6a019f74 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=5Qk88030wN86dW-1ruMA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110102 On 5/11/2026 5:04 PM, Jie Gan wrote: > In coresight_enable_sysfs(), for non-CPU sources (SOFTWARE, TPDM, > OTHERS), the source device is enabled via coresight_enable_source_sysfs() > before idr_alloc_u32() maps the path. If idr_alloc_u32() fails, the > original code jumped directly to err_source, which only calls > coresight_disable_path() and coresight_release_path(). The source device > was left enabled with an incremented refcnt but no path tracked for it, > leaving the device in an inconsistent state. > > Disable the source before jumping to err_source so the enable and path > operations are fully unwound. > > Fixes: 1f5149c7751c ("coresight: Move all sysfs code to sysfs file") > Signed-off-by: Jie Gan My git made a mistake here.. should be: Signed-off-by: Jie Gan Thanks, Jie > --- > Signed-off-by: Jie Gan > --- > drivers/hwtracing/coresight/coresight-sysfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-sysfs.c b/drivers/hwtracing/coresight/coresight-sysfs.c > index d2a6ed8bcc74..a5c08fab97a1 100644 > --- a/drivers/hwtracing/coresight/coresight-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-sysfs.c > @@ -244,8 +244,10 @@ int coresight_enable_sysfs(struct coresight_device *csdev) > */ > hash = hashlen_hash(hashlen_string(NULL, dev_name(&csdev->dev))); > ret = idr_alloc_u32(&path_idr, path, &hash, hash, GFP_KERNEL); > - if (ret) > + if (ret) { > + coresight_disable_source_sysfs(csdev, NULL); > goto err_source; > + } > break; > default: > /* We can't be here */ > > --- > base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 > change-id: 20260511-fix-coresight-sysfs-enable-issue-91533f26f9bb > > Best regards,