From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C87DF1EFF93 for ; Thu, 28 Aug 2025 02:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756347450; cv=none; b=pWruwQuy5FXMKUdZxj84KQvRmY7wJxXJm8FgO6qUjio4qZ7YChUqe7+5cTU7k02zb8dGvuH9+9EF3LGJd6pdkSsmKxMbmr1MHJ0Vn/B7hUvKNfPjb+m8+gPko1kSWLq/MIdfeABn8D/GlTKvSgaYwR+RdfEgOgCnBt08a1r1p6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756347450; c=relaxed/simple; bh=N9vnL96LHzTSI8yQopxfDh1YR87Qvfz2R3K9FkZdD+M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kxKjVuLgseqCgMnawf3lSL0HIRomF3F18tq5kWMep4eh3aMaEmILgbhR31VdhaDadGEhHLeHGU3BNbN8fqFDQXumBWgHAZLigaQ9HNtdJ3M7SVQ/Z1vxK6jHFssAU2w3NXMKpJ1F+8lIscI+f7C6QpGE1PV8dNx/0eMJumpLjfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=SZ8HzpU/; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="SZ8HzpU/" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-2445827be70so5527035ad.3 for ; Wed, 27 Aug 2025 19:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756347448; x=1756952248; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=prg3sotdOQOd9SAT1I4QjPjY9bIuPacP6Im3454z7xg=; b=RONFhqu0qfWxJZDMwULPVpiVK1S2ZrpzVqd73Iv4FrZ73VttxJWm6ngS4q2Y/LrlaF U65zl+d2CSNSt0l9jOOeGcSh07stFAZgD2ZoBVIsA26xEC3e6vdm50lteklYk/W06Bty icRo5RORb69zQIs6zH2GOub7zcCmpmVmmmmCFB77qrr7JwiWf6v891cBMdsU5DdiRXbQ rzq9NKMVRj7JGLblqi6ne1D6rXstfIh78EV9qhT3l+gA/pXD9eLD3bG+eAeSfmJXfnO9 kl3hVYl1Tm+lbhW7BwRZWJoprNSEefqYJJmLIHUjbVbUS5PTtpqLPar/5EtediDFS0Er +zbg== X-Forwarded-Encrypted: i=1; AJvYcCWT80H86dFvcKuVSzNaf4owPuUurSipw4ok/eIScCJbfQoVtrkogM+Disf2eGxhqsMmrU9azrcjzO5/Ty0=@vger.kernel.org X-Gm-Message-State: AOJu0YyyvamOKckHR/drGR4LXT8Eztn/9i2H6SYIg8YJcw7mQdb5QT3Z yFudbM0KdF9OerkjX3BXvSaAUtctDQ0M41cjqfhYBR/3vf7woP0D2DTcuoggwOE612kViaBskf0 8FZpyGi/EhCqKIhwF9xt50nUfkY3zV+Ul7w7fPypsdoyDiAtGK7F3LwD3Tpa7zd05ty0oZGXBFQ +r57fnciGLOhAPuIZ2nH9aEMtmUHUc2LREan+fKw5rRmTnmp0p06b6KmPoLLDKC3zhSDnvh9Tly 0CvQ1+Np9yNTJlaShQy8Cf/ X-Gm-Gg: ASbGncsDoB60dB/DFQ0r3/zAsc/ydFriwTeqCK0TDcjqfvCYW5ZwQgmpPnZIs5r8bY1 VtbQPy3rzl6iPhDaxzRRb4Nm8pvSeaX0QC4EgmdhQT0R4SKv0xPikGhK0bDKSg9c2QRhA4U3iUj n613XlAV8NptpnNaaCPVMTMbERN29a4K5p7KVlcnQLubn76MM55euKaNbqVWCDX6Wf3TiF7I/sO vvb+bwe3F32eXmGrdxz4zUOSOHj2MC3phwjeOW37B2qGz/4bs+dPXt1reEIzZQpnzzhHqhJgEo9 /aK9u+DkktDVglhk6ISucKF+6XvQlXdfhqhm0JXsGUk8hhmoGXit+kalHSb7NY+hlSkpJ30QKkA ZcYwrsEk9HKHnvTMHaL/xSD5Ba9oq0qQy0n4zCK2tGlTrvEVt91AkYJgImNq7rP5hbuichUdyJq 8oTkoLOAo= X-Google-Smtp-Source: AGHT+IHxnm8rlpCqU6T0J/9JZ0V2a6lpBEKFd/F9QyOuh7T704aVxzVlnLFGg2qQ9UHth3hDgjqijpbkZ1E4 X-Received: by 2002:a17:903:8c6:b0:240:92f9:7b85 with SMTP id d9443c01a7336-2462eb19bc8mr285251795ad.0.1756347447930; Wed, 27 Aug 2025 19:17:27 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-122.dlp.protect.broadcom.com. [144.49.247.122]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-248a0330373sm2541435ad.1.2025.08.27.19.17.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2025 19:17:27 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-76e2e60221fso773648b3a.0 for ; Wed, 27 Aug 2025 19:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1756347446; x=1756952246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=prg3sotdOQOd9SAT1I4QjPjY9bIuPacP6Im3454z7xg=; b=SZ8HzpU/ZsKSWXEAdSOKF/PRO/uBcPm6m5T1OmBxi4Lua2+oUr0XmBs9ehcLF7l9u7 YqJAtUsdFcEI0UIHoFZIpbKjXV03lxmKUjm746hzJVjbfi4/85j1MTOl+cJ9VxDg+NdK MmXHceFao3/qsHUV2CBnKTg00nWD1+7NT0Qm0= X-Forwarded-Encrypted: i=1; AJvYcCVKe9rdhD1XQcqcfITb8OFY/+I793brQO9JVJMIYDcL5mMb+GtUWEnsakEBtjpGEtMmODwnoWCM7WbuVwE=@vger.kernel.org X-Received: by 2002:a05:6a00:190e:b0:758:66a2:981f with SMTP id d2e1a72fcca58-7702fa0590emr29938712b3a.12.1756347446324; Wed, 27 Aug 2025 19:17:26 -0700 (PDT) X-Received: by 2002:a05:6a00:190e:b0:758:66a2:981f with SMTP id d2e1a72fcca58-7702fa0590emr29938690b3a.12.1756347445858; Wed, 27 Aug 2025 19:17:25 -0700 (PDT) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771ebabeeffsm8361867b3a.30.2025.08.27.19.17.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Aug 2025 19:17:25 -0700 (PDT) Message-ID: <910dae68-0545-46fa-b41f-8e4fb32ed649@broadcom.com> Date: Wed, 27 Aug 2025 19:17:23 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] include: linux: Destage VCHIQ interface headers To: Stefan Wahren , Umang Jain , Jai Luthra , Laurent Pinchart Cc: Broadcom internal kernel review list , Greg Kroah-Hartman , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-list@raspberrypi.com, Dave Stevenson References: <20250827-vchiq-destage-v1-0-5052a0d81c42@ideasonboard.com> <20250827-vchiq-destage-v1-1-5052a0d81c42@ideasonboard.com> <20250827124016.GF5650@pendragon.ideasonboard.com> <8ed6519a-6e45-4793-b11b-7b63c1703d6e@gmx.net> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <8ed6519a-6e45-4793-b11b-7b63c1703d6e@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 8/27/2025 12:05 PM, Stefan Wahren wrote: > Hi, > > Am 27.08.25 um 16:33 schrieb Umang Jain: >> On Wed, Aug 27, 2025 at 02:40:16PM +0200, Laurent Pinchart wrote: >>> Hi Jai, >>> >>> Thank you for the patch. >>> >>> On Wed, Aug 27, 2025 at 11:54:08AM +0530, Jai Luthra wrote: >>>> From: Umang Jain >>>> >>>> Move the VCHIQ headers from drivers/staging/vc04_services/include to >>>> include/linux/vchiq >>>> >>>> This is done so that they can be shared between the VCHIQ interface >>>> (which is going to be de-staged in a subsequent commit from staging) >>>> and the VCHIQ drivers left in the staging/vc04_services (namely >>>> bcm2835-audio, bcm2835-camera). >>>> >>>> The include/linux/vchiq/ provides a central location to serve both >>>> of these areas. >>> Lots of SoC-specific headers are stored in include/linux/soc/$vendor/. >>> This would be include/linux/soc/bcm/vchiq/ in this case. I'm also fine >>> with include/linux/vchiq/ but other people may have a preference. >> I agree with this point and I might have missed to notice the >> include/linux/soc earlier. That's seems a better location to me since >> it's actually broadcom-specific. > I would expect that headers and source would be more related. > > For example: > > include/linux/soc/bcm > > drivers/soc/bcm/ This is not Broadcom code, it is Raspberry Pi AFAICT, therefore, just like drivers/firmware/raspberrypi.c, we would need some namespacing here that reflects that, ideally. -- Florian