From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42D5A17C220 for ; Thu, 19 Mar 2026 05:36:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773898585; cv=none; b=lY8MtfsKq9myn4llRWT0gpMSx994EdSYuoQgR0xM5KolQNX5u59mCE1OOK1cqoBSvonjnWHf7BKobcu2d7AWuYFbjFd6Y76OqOHc6HNq0oLr6u7HFmXurmzhP68No7uKSSOhzSu6b8CBq9qQBeJtghIsr+j2Kf0FbVWvWXRWayY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773898585; c=relaxed/simple; bh=SK7gP3AdRB2weRwhUuhaO5iljg38WO1Y1+ShrFidEb8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HjrHCdjAtgkd4XeciFUnHl+URr/i9zHpQ4sljRwgOhMfy9NJ+dkSerIbUXiXPF1TXynZ/paCkOFFGttqIi+3Ub7z3pQb8rr9+aoMWHa0vZdZHQ9T5zsa0TNX3gTBCTYbw7Ma3SY/fIgglgD80+2gaid9mWVHYzCK25JPBMsJEeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hMlKPRU8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cJevdxLe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hMlKPRU8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cJevdxLe" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J5XfhN573909 for ; Thu, 19 Mar 2026 05:36:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a+6eVRTkI5BP0q9Hzgp+FpLtQ3rpJVvxCo062+FaU84=; b=hMlKPRU8a8PGc+hK Q1XF3agKNfoO02GGtokawDrQHwhSuwkGgwni1/30hGZZx0Ymaky9tfllw4A8i0pT NPLDnIevrpEAmdRfiZri+itYhm3jx/l5XDQAdwaqQGCbuZS15mOLctBBQwjYVJ3l FVkyE4sxyw/yT7cL0s8tmBod0OJTd9WJgh3IEM6tfNtRVOaklAPRCL3tQ3S8noKP iUU9gB5ET0UtqKmesODdS04Iqb02UvGmTuV62+qOawxzwm5FEFLQdDMDI8wWr5u3 PpIA1drBlIqSt1LRg1Ltt8KqDFX1Taze7KwPzIUww5A4qnm/EkRt9V9cArtw9nhm awQvtA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d00eg9vqs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 05:36:23 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b059ab124dso12494675ad.1 for ; Wed, 18 Mar 2026 22:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773898583; x=1774503383; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a+6eVRTkI5BP0q9Hzgp+FpLtQ3rpJVvxCo062+FaU84=; b=cJevdxLexZel1s841LHlG1jLE9zKUhtfYcgsGCFzalcqEusZLHKIVU3IsifrqaNOKA CDH6lL5VB5IKt2ElMJQXj9l72H1MEwVrjdwVRRvQ/+sURmtOVq+NEw+YdO6U4wMfsGky tVLuu5Bcm+lRawH6UlhFGwJ9BrdirGNf9tt19w5KYADRBW0G29q/GTDeKerYefcysCSX QNJHDo5Gxs2nhxqUvWl0MjIBBdLwg226oKeyS1AlW//fW2ustO5xy8mo7UonC7tSLkeF 2qtj5jzfcLs5f0W8K3+wX16+UAGUaynn2E6eSXcoJCPd5vPyMFAR+Ze2En9+B1j6706H bynw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773898583; x=1774503383; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a+6eVRTkI5BP0q9Hzgp+FpLtQ3rpJVvxCo062+FaU84=; b=pJSwSJ/CgH/rbfRCrO8xG7Amvf6XfhUerqOwefHzGwXYqmVXCKHlCPSIBKq8BLBOVm S298N9tunHLPYRu93hUvubdg+YtxfndNF+ITcIIQlNy7efk6O2JOI+mFkWDGNFVK7bQT rlSWokfFnbECHAM6ZrfqtiFWemoWMwl+3cBCLyVzLFCZzOWwRpA9qbGijii+x3MJoSpM eoYCJXgk4z9/Fj7Emn4LdYLPiG3UEKO6O8pPs5W7uwnk11Q7AX4x63uZplLrSco1RyRu pizMn0SCzjSfsL79e5Ih4ugVnyTNnUX7gisp1dm++NwM/tiwBtV9FlUiwlszYb7YHBQf A9YA== X-Forwarded-Encrypted: i=1; AJvYcCX/MwKCoert9O91691e+lRTQdBW8G4MWMOknnsNWj2fdE5lZj5zJZe+yCoOz8FGgJpc0mnNFWYE2ZeIzV4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3ggL+wqJmQommQyF/UOY0LjC+cYexVUgUmn4HlYKz26iFWc74 QlpYwAUTznrZciRXqVFtAl3FouRMjz/6filHlSwCQJNZhW0ih5nV9as8dQ1wx9r23+S6lF2vL6U ZpC5/jo7O7uIrTR0a3LuyXXBwDC4rkHyuvZanluQ0cJYYbemVLDY5Vjj9MFJPCiZmQUw= X-Gm-Gg: ATEYQzxNk8DBbuOZazzsWP+liYDwRaReoMIqf2DBN44BAhZzq/JLE1vS1ss2Wcr/khd IFXyxpbteQ2BfEuqH8Wfy4j3ffo9G5WGSMGwAL3pOvcFf2vDPywhIO6zU0CDgnMiooVeBya5TGZ o1D4kHFwbaVXCu+PThq+VEQAeOKPqRVCG948CtM+iUfu+39vz1wCJcvZ3kkKn/L//2njugB90rj JzAd+b+kJB1s0azQ8+CK17pYpf3z4raBUUybbwSS0twME7hmjLkA12OCl/BffQXEnJ4TDAE4ThK 6uu74yYd7VFJxR6PVoCaMCneIsyXU4ms04snW3rl7pW5bM+SytlZdln18OCFfkZn1yhVZQPJ2rg kalmA+yWvlbYUsavUpbI8i8RKG1PSBfdcIGDnxADWpovTUc0Dq9Ix+YnjKT07XRTu+iVIY77XHx kIymToDKEUig== X-Received: by 2002:a17:903:1109:b0:2b0:61f8:9f01 with SMTP id d9443c01a7336-2b06e3e18famr55996315ad.44.1773898582799; Wed, 18 Mar 2026 22:36:22 -0700 (PDT) X-Received: by 2002:a17:903:1109:b0:2b0:61f8:9f01 with SMTP id d9443c01a7336-2b06e3e18famr55996035ad.44.1773898582319; Wed, 18 Mar 2026 22:36:22 -0700 (PDT) Received: from [10.133.33.84] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b07a508f00sm9565725ad.80.2026.03.18.22.36.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 22:36:21 -0700 (PDT) Message-ID: <910ef3e2-76e5-493e-808c-73132d939864@oss.qualcomm.com> Date: Thu, 19 Mar 2026 13:36:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/12] scsi: ufs: core: Add support to refresh TX Equalization via debugfs To: =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "beanhuo@micron.com" , "mani@kernel.org" , "bvanassche@acm.org" , "avri.altman@wdc.com" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "adrian.hunter@intel.com" , "alim.akhtar@samsung.com" , "James.Bottomley@HansenPartnership.com" , "quic_nguyenb@quicinc.com" , "linux-kernel@vger.kernel.org" References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-8-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=MMNtWcZl c=1 sm=1 tr=0 ts=69bb8b57 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=lZOxv685zBznO1DyOMIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: I0AUe91w3A2vNQI2Tl0WSPADb8vItkNP X-Proofpoint-GUID: I0AUe91w3A2vNQI2Tl0WSPADb8vItkNP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA0MCBTYWx0ZWRfXxHp+O7o1h7kd M26E1oIyEJd0UTU0OL0s9igdRz9VWuQpfhOiP2aqo4aK6B5ELPKgo0PPeFPpUssobR3okZeAHNt szeyCvWM8gnBxSJ6YseJrjrL7ABia3tSqYqfcSbrDcuhUq0PpTCuFMnV8NfLEp7QdOFVFxlKe5G qSbLXra/luG/gAFvMC2JDHNigT7FsJxdH7SqCe+ll59gwnDYVEE/Sf0dzRopXwNmS8wLpTynXoN /6KG8ThAYpRMyYOOCSx9ZqYRwqfQYj8Ztp0KqyQoqzOHAkEmObxGt1KLoOU3tz7nFWX9zxp40l+ NgEoMMDav/Y49E9z5GNF1nO30lqNxYZOMpvhFzNRDAnaOnGTH/MEVpK+lDQ3olnMHzfo6JehVMN ZkraDFSea//6q6oAlQ1pWqwFxrq4Uw8Q1hbJHcZSfUWfMW5CdB3cNurT9h4Pixqfod/hHjHtSYs hmsWQqz3Mu9HqegAGWA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190040 On 3/17/2026 9:05 PM, Peter Wang (王信友) wrote: > > On Mon, 2026-03-16 at 10:14 -0700, Bart Van Assche wrote: > > On 3/14/26 3:45 AM, Can Guo wrote: > > > I chose 'refresh' because the code conducts more than just > > > retraining of > > > TX EQ, > > > the code also carries out a Power Mode change after that, and only > > > by > > > doing a > > > Power Mode change, the new (optimal) TX EQ settings are really used > > > by > > > both Host > > > and Device. > > > > Thanks for the feedback. Not sure what others think but I still think > > that "retrain" makes it more clear what happens than "refresh". > > > > Bart. > > Hi Can and Bart, > > I agree with Bart’s opinion. I will move back to 'retrain' Thanks for the suggestions. Can Guo. > > Thanks > Peter > > > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!