From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE3AC433F5 for ; Mon, 16 May 2022 09:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242228AbiEPJLt (ORCPT ); Mon, 16 May 2022 05:11:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242389AbiEPJLF (ORCPT ); Mon, 16 May 2022 05:11:05 -0400 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07727237E0 for ; Mon, 16 May 2022 02:10:46 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VDHYTt8_1652692240; Received: from B-LB6YLVDL-0141.local(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VDHYTt8_1652692240) by smtp.aliyun-inc.com(127.0.0.1); Mon, 16 May 2022 17:10:41 +0800 Subject: Re: [PATCH v2] RISC-V: Mark IORESOURCE_EXCLUSIVE for reserved mem instead of IORESOURCE_BUSY To: Conor.Dooley@microchip.com, mick@ics.forth.gr, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, anup@brainfault.org, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, rppt@kernel.org, david@redhat.com, wangborong@cdjrlc.com, twd2.me@gmail.com, seanjc@google.com, alex@ghiti.fr, petr.pavlu@suse.com, atishp@rivosinc.com Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, jianghuaming.jhm@alibaba-inc.com, guoren@kernel.org, stable@kernel.org References: <20220512060910.601832-1-xianting.tian@linux.alibaba.com> <2e62621a-1fb8-5de7-8d0e-e6c4019931a1@microchip.com> From: Xianting Tian Message-ID: <910efc8b-5d6f-820e-3b89-97c668e78cd8@linux.alibaba.com> Date: Mon, 16 May 2022 17:10:40 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <2e62621a-1fb8-5de7-8d0e-e6c4019931a1@microchip.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/5/16 下午5:03, Conor.Dooley@microchip.com 写道: > On 16/05/2022 09:50, Xianting Tian wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Hi >> >> Could I get any comments for the v2 patch, thanks > Looks like you have 3 Reviewed-bys already & there's only been one full > working day since you sent the patch, probably just worth waiting a little > for Palmer to get around to picking it up :) > Thanks, > Conor. thanks :) I just saw Heiko Stuebner gaved Review-by on patchwork.kernel.org, but I didn't received the mail. Let's wait Palmer to pick up. >> 在 2022/5/12 下午2:09, Xianting Tian 写道: >>> Commit 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tree") >>> marked IORESOURCE_BUSY for reserved memory, which casued resource map >>> failed in subsequent operations of related driver, so remove the >>> IORESOURCE_BUSY flag. In order to prohibit userland mapping reserved >>> memory, mark IORESOURCE_EXCLUSIVE for it. >>> >>> The code to reproduce the issue, >>> dts: >>>          mem0: memory@a0000000 { >>>                  reg = <0x0 0xa0000000 0 0x1000000>; >>>                  no-map; >>>          }; >>> >>>          &test { >>>                  status = "okay"; >>>                  memory-region = <&mem0>; >>>          }; >>> >>> code: >>>          np = of_parse_phandle(pdev->dev.of_node, "memory-region", 0); >>>          ret = of_address_to_resource(np, 0, &r); >>>          base = devm_ioremap_resource(&pdev->dev, &r); >>>          // base = -EBUSY >>> >>> Fixes: 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tree") >>> Reported-by: Huaming Jiang >>> Reviewed-by: Guo Ren >>> Reviewed-by: Nick Kossifidis >>> Signed-off-by: Xianting Tian >>> --- >>>   arch/riscv/kernel/setup.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c >>> index 834eb652a7b9..e0a00739bd13 100644 >>> --- a/arch/riscv/kernel/setup.c >>> +++ b/arch/riscv/kernel/setup.c >>> @@ -189,7 +189,7 @@ static void __init init_resources(void) >>>               res = &mem_res[res_idx--]; >>> >>>               res->name = "Reserved"; >>> -             res->flags = IORESOURCE_MEM | IORESOURCE_BUSY; >>> +             res->flags = IORESOURCE_MEM | IORESOURCE_EXCLUSIVE; >>>               res->start = __pfn_to_phys(memblock_region_reserved_base_pfn(region)); >>>               res->end = __pfn_to_phys(memblock_region_reserved_end_pfn(region)) - 1; >>> >>> @@ -214,7 +214,7 @@ static void __init init_resources(void) >>> >>>               if (unlikely(memblock_is_nomap(region))) { >>>                       res->name = "Reserved"; >>> -                     res->flags = IORESOURCE_MEM | IORESOURCE_BUSY; >>> +                     res->flags = IORESOURCE_MEM | IORESOURCE_EXCLUSIVE; >>>               } else { >>>                       res->name = "System RAM"; >>>                       res->flags = IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY; >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv