From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10CBE3346B4 for ; Wed, 10 Jun 2026 03:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781061032; cv=none; b=EhS87X5xauhXAz0JA0y9b5XNkLc/4FhmYzqo35i3KvISUWDpXZOQ6rE9lqgSfYS7WyxjN8A4B5knmtOACTVxqMI4QsfBcLVvGdwCY8Tcy3w+rGVA4CuprLXs10eF4zNiPBmsMlPrBc0gH4i/rPedQd+sj16AsyCQjgZeoT9YOtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781061032; c=relaxed/simple; bh=634BnfYsa7PCxiyercmqvt7DGN4XvxrpkhGybRKzMJY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OmZjF+CkIwPPjeO2Sqi9LNEifE1ujrls2/GQB75AktYBK/GqXy2BXsFGOfRjIDAG6wIVFILrnwLc89qdzwfKk6BWkDeh+wwQlbciWsV45A16eX660OVpNljImie6UWVDy1WbZf0+SDuMdTG2NXM/IfYz3zRs1anjJSTGscFE0Jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AZvpFaZG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NXIoYoMw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AZvpFaZG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NXIoYoMw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A2f0UH4064617 for ; Wed, 10 Jun 2026 03:10:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9+eFqPsmWaRwlbi0tjndZiwSh3Muv16DZxWChbiNGE4=; b=AZvpFaZGKas/vkxw ZaoEYCJF8siap+SM0o3/kr5OMrlfcn2dvsKGv5CkFidMhRfpeTLBKqos0pfEwbVe IeAtQoIUuxdUWgF8K4wz6mS8T2RPJthooo03MP59p1jzA+oSoD0NH5urlL+hwmq9 a63ZaqQud3LAlazUoBPsxaoB9RA7LG1APnf4B6fAlkALAZVwYgwS335EpVEH3Vph 6lNHv8dFHKO7UxRDV7Cy3t3PcnQq4MkjfvqL6DEmBSmaCJBmQ2NZHhYaUl7e0EGq wmjVLGVmuVkHB0De/nDsafPZfKH7xZWgfgMtuZ6hnOYMqWM2bTREJgHiE9oeNXxZ iMX07w== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epdeewe1w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 03:10:30 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36b7c55406bso4460664a91.2 for ; Tue, 09 Jun 2026 20:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781061029; x=1781665829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9+eFqPsmWaRwlbi0tjndZiwSh3Muv16DZxWChbiNGE4=; b=NXIoYoMwoYkcyqMb77urlpJcynZELEA4/QzxnN9qWGF8xJ+cBthdd/YhEOV312nR+C cIa32NLD8vEQBlIHtx1gy2nCkrpTOT8pCsD2iMXN36+tqmv2tKO+8n3ar/823YTNPhiw 1HD+O0/A/fdTkH34KSRSoVhk449m2xl4HizkvOUaCbKpLe2VJZYKXBZSJDq5/S/jVuDY h9pUMFoARmsAheOcdTy+he9183HTUYphWdc8AqSlu1l6GkJiw7CBn8pcNEjxdR44GbbL pF2lMKdJDezAZxFgQISiyW5urBtgH7I9TuW52e9Se+4JVFcM8I66uj90gz4ubeOOW4j7 nMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781061029; x=1781665829; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9+eFqPsmWaRwlbi0tjndZiwSh3Muv16DZxWChbiNGE4=; b=A1P1RcXKvKBRlJ9B9rq21fkKJlNDHA2MJzV6q9Vja3HZxgAqlKpxF50cnYhZuzoIjy Tiz1O9B/+DAYMYV31cc1fTtqAn8Md7+bamVxlD4TMNmTv57hVlvOG497pTM6XhXtj/+8 3zoGfDr5TdPaHUkkLRerH13Q2wveO0ZDCVhs70yvDdNhLLsNzSYySLPamD9KEVHUg9Hj fBqOFxWIKqQqTyWG8OvchgiVw6Lt0u4yvSYIFW2sl4f/nimYbTGQJvsu4pBePia9TQsc /m/mqXCdeugzAoS9YJGEZJqcmxPYdlvOFen5rrz/EeVzsFfilFD3nQoXZXAval03WMr7 7ImQ== X-Forwarded-Encrypted: i=1; AFNElJ8rEDk06jCytFDz1JZuWw7IRckvKj6VdvfPpzVkwcUhCpP6jSqibPv8KCyVbcf2lSUqdzrr0x0rsob7Bws=@vger.kernel.org X-Gm-Message-State: AOJu0YzdY9jG2c2zuk8ExmL73tCdX01b0ELK58Hw32i0c+Z4K59N0Ao8 P4Fti8iRDkx0WYL122Bd6dCSX4vyRfZqjU7xz+PBFZ745ZMTyQ82tr+ayUZFJlG5ldRmwniayR2 +tsbWcFgYVlkhL2EytJ6cuz+iMEjPTm0Pmvs58Y2JJzQ6picvjlY7qJZy2I7JobHY4sA= X-Gm-Gg: Acq92OEwdnxiKFdJlwQDOQiYVoVFzE4xaw8joocooTgsuJje1XKPPp3+ygOc0uL6kWi yOyOLLWBuh1/QJZ8rMtUPC5y5eMAdlHkf8WAsSkfH4dkeHdJoTd8uodKQJcObJoj/EHozYIkbGv xgjDayNA1cpQ2x2mTepi9gICxzBGDe/5rwH9ysqIHgQSyBLEdKwV6sW6pm3tJwZU1FrC8Tq/5k9 ca0AHLWIgLsFGLcEU9E60v3H9BciR7MFSKuspzOaamzu9DmpaSPWjeqUFcd4jWQemezkFCIwc4t +irb+YdIdd3zXjPCBakTvoV+XJ0KHSKWr5ZLzbThmTtc/FgxaNPdo4tUS6w1D59gi/0/75Aunbf EEuGYRR9mnCX0MfRDiFrlxUuKG1Za9i0ufGKNXNyr6DwExEOWq/iho0xVrId4kZ6C78KTk3gpML Xcujdt9yqLb4Gi/xJATrQ8mQ== X-Received: by 2002:a17:90b:3909:b0:36b:bb66:fbd0 with SMTP id 98e67ed59e1d1-370ee33d069mr22550839a91.4.1781061029348; Tue, 09 Jun 2026 20:10:29 -0700 (PDT) X-Received: by 2002:a17:90b:3909:b0:36b:bb66:fbd0 with SMTP id 98e67ed59e1d1-370ee33d069mr22550806a91.4.1781061028859; Tue, 09 Jun 2026 20:10:28 -0700 (PDT) Received: from [10.133.33.189] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37624a8e7c4sm908882a91.13.2026.06.09.20.10.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 20:10:28 -0700 (PDT) Message-ID: <91117dd7-91e1-4c1a-934e-1b6717698377@oss.qualcomm.com> Date: Wed, 10 Jun 2026 11:10:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate To: Kathiravan Thirumoorthy , Konrad Dybcio , george.moussalem@outlook.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260521-ipq5018-cmn-pll-rate-fix-v2-1-04b28a92e0f2@outlook.com> <9ab1340d-72bb-48df-8784-a584a37b5c76@oss.qualcomm.com> Content-Language: en-US From: Jie Luo In-Reply-To: <9ab1340d-72bb-48df-8784-a584a37b5c76@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=H+DrBeYi c=1 sm=1 tr=0 ts=6a28d5a6 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=bC-a23v3AAAA:8 a=UqCG9HQmAAAA:8 a=EUspDBNiAAAA:8 a=DmDlxQa2pT8N5fOTvVMA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDAyNyBTYWx0ZWRfX6R4L7Hs14ORK GpTUtqxkLjjsfRoKNz06tY1OGW4OHJQyy6zYGJN8zlhb8I3V+aZynQAvpIUk8aqZrvkcKJYdl4X ROTMyWtoscWiUe8p1fdaa/I5Ug38eLmqPJ49dJjJJUnvJvAls5QFQCD0ppx/4JNsNTUOWYrN7tW 7gFmRoXVQ/KNByLYhWABO4a2UiZQZH9goO14pcp2SYgUTdEq5C7y6XHycOPQjFMBgLl0cCDwDH/ iKoG6uh6uKZoknnPTB7MSt4ry7P1ZLOOUL7rO9PEuT+MQrwcdC6mp00iaeeBUaORDgfY3g6QtsU XWMQyi5sZmfRsyj7cxwJtDi1qsRwhloLFI0NyEOR87C2g/hmFr/+XQSgZcYjGO1XCnUO+UTKXD+ YgvY5gICPRUkSJIKxjzLSMc1H3BqRYBGNYmENeLLz0ZQwfuszB9LHK3f8MCMy7r4m5M2UCbc+Wp 6cEZnPf0vAiyzqL+1Tg== X-Proofpoint-ORIG-GUID: XTZzzrUEVRtNhzq9mxDg9VGNAFhI1nAd X-Proofpoint-GUID: XTZzzrUEVRtNhzq9mxDg9VGNAFhI1nAd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100027 On 6/10/2026 12:59 AM, Kathiravan Thirumoorthy wrote: > > On 6/9/2026 8:42 PM, Konrad Dybcio wrote: >> On 5/21/26 9:55 AM, George Moussalem via B4 Relay wrote: >>> From: George Moussalem >>> >>> The correct CMN PLL reference clock rate for IPQ5018 is 4.8 GHz. >>> >>> The CMN PLL driver did not account for the ref clock divider which is 2 >>> for IPQ5018. Therefore, the computed rate was twice the actual output. >>> >>> With the driver now accounting for the CMN PLL reference clock >>> divider (commit: 88c543fff756), set the correct reference clock rate. >>> >>> Fixes: c006b249c544 ("arm64: dts: ipq5018: Add CMN PLL node") >>> Signed-off-by: George Moussalem >>> --- >>> Changes in v2: >>> - Removed line break in commit message between Fixes and SOB tags >>> - Link to v1: https://patch.msgid.link/20260519-ipq5018-cmn-pll-rate- >>> fix-v1-1-3c83a173c27f@outlook.com >>> --- >> I have no reference for this, but I trust you.. maybe +Kathiravan >> could double-check > > Thanks Konrad. As per the HW doc and the commit 88c543fff756 ("clk: > qcom: cmnpll: Account for reference clock divider"), default ref clock > divider is 1 in IPQ5018. > > @Jie, Can you help here? > Hello Konrad, Kathiravan, As confirmed on the IPQ5018 RDP board, the ref clock divider is set to 2. >> >> Acked-by: Konrad Dybcio >> >> Konrad