mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 管雪涛 <gxt@pku.edu.cn>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>, linux-kernel@vger.kernel.org
Subject: 回复: [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure
Date: Wed, 21 May 2014 15:58:35 +0800 (CST)	[thread overview]
Message-ID: <911514109.40740.1400659115169.JavaMail.root@bj-mail03.pku.edu.cn> (raw)
In-Reply-To: <537C0344.5010509@gmail.com>

Thanks.

For __muldi3, it is no longer used by gcc, so I think that's ok.
For __bswapsi2, maybe it's because I copied it from arm.

Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>

----- Chen Gang <gang.chen.5i5j@gmail.com> 写道:
> After check the code, 'bswapsi2' and 'muldi3' are useless for
> unicore32, so can remove them to avoid compiling failure.
> 
> The related error (with allmodconfig under unicore32):
> 
>     LD      init/built-in.o
>   arch/unicore32/kernel/built-in.o:(___ksymtab+__muldi3+0x0): undefined reference to `__muldi3'
>   arch/unicore32/kernel/built-in.o:(___ksymtab+__bswapsi2+0x0): undefined reference to `__bswapsi2'
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/unicore32/kernel/ksyms.c | 2 --
>  arch/unicore32/kernel/ksyms.h | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
> index bc06140..e78911a 100644
> --- a/arch/unicore32/kernel/ksyms.c
> +++ b/arch/unicore32/kernel/ksyms.c
> @@ -53,9 +53,7 @@ EXPORT_SYMBOL(__ashrdi3);
>  EXPORT_SYMBOL(__divsi3);
>  EXPORT_SYMBOL(__lshrdi3);
>  EXPORT_SYMBOL(__modsi3);
> -EXPORT_SYMBOL(__muldi3);
>  EXPORT_SYMBOL(__ucmpdi2);
>  EXPORT_SYMBOL(__udivsi3);
>  EXPORT_SYMBOL(__umodsi3);
> -EXPORT_SYMBOL(__bswapsi2);
>  
> diff --git a/arch/unicore32/kernel/ksyms.h b/arch/unicore32/kernel/ksyms.h
> index 185cdc7..31472ad 100644
> --- a/arch/unicore32/kernel/ksyms.h
> +++ b/arch/unicore32/kernel/ksyms.h
> @@ -8,8 +8,6 @@ extern void __ashrdi3(void);
>  extern void __divsi3(void);
>  extern void __lshrdi3(void);
>  extern void __modsi3(void);
> -extern void __muldi3(void);
>  extern void __ucmpdi2(void);
>  extern void __udivsi3(void);
>  extern void __umodsi3(void);
> -extern void __bswapsi2(void);
> -- 
> 1.9.2.459.g68773ac


      reply	other threads:[~2014-05-21  7:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21  1:37 Chen Gang
2014-05-21  7:58 ` 管雪涛 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911514109.40740.1400659115169.JavaMail.root@bj-mail03.pku.edu.cn \
    --to=gxt@pku.edu.cn \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®