From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C496C433E0 for ; Sun, 9 Aug 2020 08:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 125CC206C0 for ; Sun, 9 Aug 2020 08:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgHIIKu (ORCPT ); Sun, 9 Aug 2020 04:10:50 -0400 Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:44738 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726250AbgHIIKu (ORCPT ); Sun, 9 Aug 2020 04:10:50 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 5FE701800028E; Sun, 9 Aug 2020 08:10:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: tin89_2a09b8826fd0 X-Filterd-Recvd-Size: 2260 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Sun, 9 Aug 2020 08:10:47 +0000 (UTC) Message-ID: <91159e176c090f2d7ada6957af342c4b6d787973.camel@perches.com> Subject: Re: [PATCH 5/4] RDMA/efa : Remove pci-dma-compat wrapper APIs From: Joe Perches To: Suraj Upadhyay , dledford@redhat.com, jgg@ziepe.ca, galpress@amazon.com, sleybo@amazon.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sun, 09 Aug 2020 01:10:46 -0700 In-Reply-To: <20200809074517.GA4419@blackclown> References: <20200809074517.GA4419@blackclown> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-08-09 at 13:15 +0530, Suraj Upadhyay wrote: > The legacy API wrappers in include/linux/pci-dma-compat.h > should go away as it creates unnecessary midlayering > for include/linux/dma-mapping.h APIs. > > Instead use dma-mapping.h APIs directly. > > The patch has been generated with the coccinelle script below > and compile-tested. [] > diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c [] > @@ -405,13 +405,13 @@ static int efa_device_init(struct efa_com_dev *edev, struct pci_dev *pdev) > return err; > } > > - err = pci_set_dma_mask(pdev, DMA_BIT_MASK(dma_width)); > + err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(dma_width)); > if (err) { > dev_err(&pdev->dev, "pci_set_dma_mask failed %d\n", err); Coccinelle is great for some things, but not necessarily for these sorts of changes in an completely automated way. The dev_err messages also need to be changed as the format string contains the old name. > - err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(dma_width)); > + err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(dma_width)); > if (err) { > dev_err(&pdev->dev, > "err_pci_set_consistent_dma_mask failed %d\n",