From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7CC534D4DB for ; Fri, 21 Nov 2025 14:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763735278; cv=none; b=nz6hqVSajv3HV17BEgbFaBtx9k7JELEz2sVSgdleW70Yyh9rA4QSSRphxNLGzMwafQwpDqTrd8MYH2ASRviEXP+nhK7vJiNmCvOUynkDfwsROxcuiVSW0ZQOaEDVxlDFtNxdD5DyqwAlWVwKDLuOTdTiCDi/bo+RpdwL8j4xGZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763735278; c=relaxed/simple; bh=wUkh/mA7UXzEpu2dfAzT82Tp3jTQmu50WJCMbHGKJbk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HiempxtQkt37Gkv1is1detHxCpSRNrPMWmRKzqJ1sm2lbKVXeCA6RURMopy3oXh8iOZRwssIjbpphi7xkn0fbL/VcsWFU6FkSFrsYucWCK7E34eXFoJ5ZOHRfzwxeqNkv5bgkusRhYyfl4WIVacspBYXBua0nYQ8wa73WVQWERk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UPTfl/ZS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JfIJNBeZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UPTfl/ZS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JfIJNBeZ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ALC60TV2759593 for ; Fri, 21 Nov 2025 14:27:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XNvNNydzFcqtzPPQd0uumLEbg50M+dE9GK8gmZ+m4YA=; b=UPTfl/ZSd73ms0fa XCu0VJF47+3IEUzEpZWKr0/TMhetX0B20awXHYlyBUeHLgcynnlkWwZJOKIth/Ll aB3uXyjtLygbyXA0FnRTmTtoVAmXN7AXBZsb2wvoUIq/Kx8mReUMhBM8AhkC4RxM FtCUbxE5b0nqeOqqPYms5HxVv1DKKHSNrnGCn5y+KzQv+nY07VCYHpc2wNs8PKLK QnFl5vF165Xe2kKwS40nvV16kaTcW+JqmIomfQUEptz085m/ApfKRFxZ/aMhXWSN QIunUxg082efyFl0R5gwAIZt84m0ytZxg+VW3Dv8lyu6+HARwwo8do0ml7fj3QPq fQu3RA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ajhy61qqr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 14:27:54 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8adc67e5340so31141285a.2 for ; Fri, 21 Nov 2025 06:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763735273; x=1764340073; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XNvNNydzFcqtzPPQd0uumLEbg50M+dE9GK8gmZ+m4YA=; b=JfIJNBeZ4+jME/Uem8H+Y+dyESSOgBOWt0NY/P/RievbwgGkfz99Ccl6bfV12roAYm Sy8MPnFlVJaU1SJYifPTm3irdeP/bgbqNNREg1MTI+yGN6vDggBoMao/vqewEVbDZH54 75ywObn8qJSkO1Q+IjghImziZRabalk6LK4+1EWm1hKM6mdQyYmUgKamnbkRcvAvFhY0 AeZiAULh2LzmF1+7+MyBc1SAoZpZPwotqwxmtCXX1lsFdVAmMrfxQWgRBZe+8aHMnPm+ 7UJs8qknyq+bWIwL6dZjp295T9VgtPMRCN+7Ca5FpWp2bF0y9o3SpXWOYy4aTKMtVrXj MRmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763735273; x=1764340073; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XNvNNydzFcqtzPPQd0uumLEbg50M+dE9GK8gmZ+m4YA=; b=atdPXRfYuH+pSS6Tbm1rMpQKSl+jEnbaPX53dbeTLnul4dXDnEKBHjHJnGi/N4Yju0 9xFaB8WfUtJfN0tL6Y7IiSX4IIQbzWs+MJfGb1Wco0ZaSEjbYMISzBvbFunHnlPrRvBk NrEp9pw5LhX7GR1pHBdvutDlGeUPWUCeSK258mOqh5oCXAmeL9Ajs+dpZY8b19S1yeAF 0Zx9zqYYfj5TZoJtR7P81kFi/8VwOJC1sjzxz/DIssP3kKul3z29+q+CG7Vc5X6PlI/Y 07IUU5BeYrCwmhzdpj4lvq4I5JBmcwhlkQODha+Rx7HzAc0Jf3f7iyzmcwPjxdNKbAUY Ow8A== X-Forwarded-Encrypted: i=1; AJvYcCVp1yqDrVkg75dw3t2sWyYGcu0VwSl3nvGaQLjMPm74jFcJXymcyTL95kgqm/yvGWN+0phRsX7lVbIglrI=@vger.kernel.org X-Gm-Message-State: AOJu0YyiLa+HO32UJVKpV59XmjtbXhbpC1/guk69njUU6KBdYwhzhjby RBfazwC8NkLJC2/GX/EUf7kGqJGiFBB//JElI44DqfOoA4gc/vGq6W1N+RxL0YalG1bLW08Rt17 YYwUOHWHf84UEwSgs3i7f0e7DT7I4MaoQXbCqP6JGuuE7U6Td7RicPtTXuuUXxRWikGw= X-Gm-Gg: ASbGnctGVdOUik7Pe4VnGyuvqRFM9s1TAIc/LTfX1xueaj/e+8A8Qtjy1uG5KxhQzft RONwSECE3xV2thWzOD5T4JwaiI1x+pAGX6IRbOs/0aMesnEiG0KCWO2ZL0Mi3MnDlmKmqGsT4a8 t0ZVR8TN6dvTIp+l7y0KSL+Q5wXT3vZcQ0RykhPgtBMO+TElrRkh4Bai6fYxP444otc4pKrPeDD sSU2jyeglw2WygUpamMcnn062z8qOFQbWuAEdL2OcI7vLBr99UtdE5LbIZ/PiD9ecPp2DyplGef MaK7Q9EzMaVR9RdC1lYi2bF40gZ2VAJN6IVN3BN3IoVE0qXkJ8XVZivBjX/9qwRWgkmjzB8kM2H sQ0jf/p+eX/H5E+ShfkxE4k8Q2NTqshq04q8BkKu8HqzT38Xdh13zfzU5AAubwHz0tpI= X-Received: by 2002:a05:620a:3190:b0:8b2:6eba:c45d with SMTP id af79cd13be357-8b33d1bdc37mr194450685a.2.1763735273242; Fri, 21 Nov 2025 06:27:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRmFB1GxC6Q+zoHdmsKJyIPaTMFy7R3exQ75WgnZMbkuvFthtmdv6PD5GBKDlm/9diAPNtlA== X-Received: by 2002:a05:620a:3190:b0:8b2:6eba:c45d with SMTP id af79cd13be357-8b33d1bdc37mr194445185a.2.1763735272471; Fri, 21 Nov 2025 06:27:52 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654fd4f4esm469143966b.45.2025.11.21.06.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 06:27:51 -0800 (PST) Message-ID: <9115c560-45f3-474d-8290-78b44f2b2b35@oss.qualcomm.com> Date: Fri, 21 Nov 2025 15:27:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] ARM: dts: qcom: msm8960: expressatt: Add NFC To: guptarud@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251121-expressatt_nfc_accel_magn_light-v2-0-54ce493cc6cf@gmail.com> <20251121-expressatt_nfc_accel_magn_light-v2-3-54ce493cc6cf@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251121-expressatt_nfc_accel_magn_light-v2-3-54ce493cc6cf@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Lb0xKzfi c=1 sm=1 tr=0 ts=692076ea cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=INxY3ozUAYpN26jWuhcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: xUzmBWelMZ-bLZjARiY3TdLrRzen7Cuo X-Proofpoint-GUID: xUzmBWelMZ-bLZjARiY3TdLrRzen7Cuo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDEwNSBTYWx0ZWRfXxERBeybNPJ2W oxTknHyTQfkNeTdEtzFvUGRS6yc3gvJ4AKKr9+cmGWGhACNgnpbKmqk9UskAaE/jpU839ULxKlV b0LHohCyIeGN+qPUpjxvK2XqlE3LGeunhNFaPMBb+r02G+tUDUzlNy7KYNyLaUqsurvXqvUcOKt bm+ESf5qNdAb8MZSHVfFJOQejTssMXLEtF1omJHbb7fo0nGaE5ilquNpztATxo1B/3zyzgHA6gm 1u5xQZDOfLeiTFOxJY8ajyo2UkWXwYi4FT9k1Yt/Nhoj8Zg9ZX0lKKq2oQ/mhLfxyPLwvrhU0YM f7umfYac7kqmo50KGdEA/L0ED9OBmfoLsQNyRycBW/5quIf/yWtgKpD7KmvoZK7ks4yF6Z5+Osx 82GgG1JBNYdlS4c5n06H2SEutFsFrw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_03,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210105 On 11/21/25 12:44 PM, Rudraksha Gupta via B4 Relay wrote: > From: Rudraksha Gupta > > Add pn544 NFC chip > > Signed-off-by: Rudraksha Gupta > --- [...] > + nfc_enable: nfc-enable-state { > + pins = "gpio21"; > + function = "normal"; > + output-low; output-low should be unnecessary, since there's a gpio reference on the consumer node and one would expect the direction/state to be configured through that > +&gsbi7_i2c { > + status = "okay"; > + > + nfc@2b { > + compatible = "nxp,pn544-i2c"; > + reg = <0x2b>; > + interrupt-parent = <&tlmm>; > + interrupts = <106 IRQ_TYPE_EDGE_RISING>; Sorry for not catching this earlier - interrupts-extended would be "neater" in all cases Konrad > + enable-gpios = <&pm8921_gpio 21 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&nfc_default &nfc_enable>; property-n property-names in this order, please Konrad