mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Doug Smythies <dsmythies@telus.net>
Subject: Re: [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs
Date: Wed, 26 Aug 2020 12:54:15 +0300	[thread overview]
Message-ID: <91190a53b9d78ffe08d4b001d021868ad7ba6d1c.camel@gmail.com> (raw)
In-Reply-To: <CAJZ5v0hkmcAuCsnfjCSWTarr4pkQry2VCtk2aWM74fOW2guzmg@mail.gmail.com>

Thanks for answer Rafael, it looks like there are 2 different things
now.

1. What kernel returns when I _read_ e_p_p file - truth or "cached" ?

2. How kernel behaves when I _write_ to e_p_p file something it cannot
provide - error or success.

For #1, I think we need to keep it simple and always return true policy
value. Does not matter what someone wrote there. If some process wrote
"powersave", but kernel uses EPP 0 anyway, the other process probably
wants to know the truth and get "performance" when reading e_p_p.

On Tue, 2020-08-25 at 16:51 +0200, Rafael J. Wysocki wrote:
> An alternative is to fail writes to energy_performance_preference if
> the driver works in the active mode and the scaling algorithm for the
> scaling CPU is performance and *then* to make reads from it return the
> value in the register.

Yes, this is #2. This sounds like the _right_ way to do it.

Suppose my script wants to exercise the system with 4 different EPP
policies. It changes the policy and runs measurements, each run takes
few _days_.

Now, my script asks for "powersave". Kernel _knows_ it cannot provide
it (performance+active enabled). Why would it not return error ("can't
do") instead of success ("yes, Sir!")?

Note, I deliberately use simple words like "my script" instead of "a
user-space process" to make it easier to convey the idea.

Anyway, if kernel returns error, I can go and improve my script WRT
controlling the performance+active mode knobs.


  parent reply	other threads:[~2020-08-26  9:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 17:39 [PATCH v2 0/5] cpufreq: intel_pstate: Address some HWP-related oddities Rafael J. Wysocki
2020-08-24 17:41 ` [PATCH v2 1/5] cpufreq: intel_pstate: Refuse to turn off with HWP enabled Rafael J. Wysocki
2020-08-24 17:42 ` [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs Rafael J. Wysocki
2020-08-25  6:20   ` Artem Bityutskiy
2020-08-25 14:51     ` Rafael J. Wysocki
2020-08-25 15:06       ` Srinivas Pandruvada
2020-08-25 15:14         ` Rafael J. Wysocki
2020-08-25 15:26           ` Srinivas Pandruvada
2020-08-25 15:53             ` Rafael J. Wysocki
2020-08-26  9:54       ` Artem Bityutskiy [this message]
2020-08-24 17:43 ` [PATCH v2 3/5] cpufreq: intel_pstate: Add ->offline and ->online callbacks Rafael J. Wysocki
2023-11-03 10:56   ` Jinjie Ruan
2023-11-03 15:56     ` Doug Smythies
2023-11-06  3:03       ` Jinjie Ruan
2020-08-24 17:46 ` [PATCH v2 4/5] cpufreq: intel_pstate: Free memory only when turning off Rafael J. Wysocki
2020-08-24 17:47 ` [PATCH v2 5/5] cpufreq: intel_pstate: Restore cached EPP value during offline Rafael J. Wysocki
2020-08-24 23:56 ` [PATCH v2 0/5] cpufreq: intel_pstate: Address some HWP-related oddities Srinivas Pandruvada
2020-08-25  1:00   ` Doug Smythies
2020-08-25 15:11     ` Srinivas Pandruvada
2020-08-25 21:07       ` Doug Smythies

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91190a53b9d78ffe08d4b001d021868ad7ba6d1c.camel@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®