From: Valdis.Kletnieks@vt.edu
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: jeff@garzik.org, htejun@gmail.com, akpm@linux-foundation.org,
arjan@linux.intel.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [patch 3/4] Enable link power management for ata drivers
Date: Sat, 11 Aug 2007 00:58:49 -0400 [thread overview]
Message-ID: <9122.1186808329@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 09 Aug 2007 14:24:16 PDT." <20070809142416.a110ba25.kristen.c.accardi@intel.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Thu, 09 Aug 2007 14:24:16 PDT, Kristen Carlson Accardi said:
> +++ 2.6-git/drivers/ata/libata-scsi.c
> @@ -2904,6 +2976,52 @@ void ata_scsi_simulate(struct ata_device
> + if ((dev->horkage & ATA_HORKAGE_IPM) ||
> + !(dev->flags & ATA_DFLAG_IPM)) {
> + ata_dev_printk(dev, KERN_ERR,
> + "Unable to set Link PM policy\n");
> + ap->pm_policy = MAX_PERFORMANCE;
> + }
KERN_INFO please, or KERN_WARNING at the highest, at least until such time
as enough drivers support enough hardware that it really *does* qualify for
"this should not fail" status.
(OK, so I'm just cranky because I'm tired of seeing a KERN_ERR thrown at every
reboot, just because the ata_piix driver doesn't know how to set this stuff up
for the DVD?RW drive in my laptop. But when this goes upstream, lots of
*other* people are going to get hit by the exact same thing and think there's
something actually *wrong* with their hardware.)
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2007-08-11 4:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070809211800.022150464@intel.com>
2007-08-09 21:23 ` [patch 1/4] Store interrupt value Kristen Carlson Accardi
2007-08-15 8:15 ` Jeff Garzik
2007-08-09 21:23 ` [patch 2/4] increase number of allowable device flags Kristen Carlson Accardi
2007-08-09 21:24 ` [patch 3/4] Enable link power management for ata drivers Kristen Carlson Accardi
2007-08-11 4:58 ` Valdis.Kletnieks [this message]
2007-08-13 17:26 ` Kristen Carlson Accardi
2007-08-09 21:24 ` [patch 4/4] Enable Aggressive Link Power management for AHCI controllers Kristen Carlson Accardi
[not found] <20070705194909.337398431@intel.com>
2007-07-05 20:05 ` [patch 3/4] Enable link power management for ata drivers Kristen Carlson Accardi
2007-07-05 22:33 ` Andrew Morton
2007-07-05 22:37 ` Andrew Morton
2007-07-06 0:01 ` Jeff Garzik
2007-07-06 0:02 ` Jeff Garzik
2007-07-06 0:17 ` Andrew Morton
2007-07-06 0:00 ` Jeff Garzik
2007-08-01 8:27 ` Tejun Heo
2007-08-01 9:45 ` edwintorok
2007-08-01 21:11 ` Kristen Carlson Accardi
2007-08-02 5:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9122.1186808329@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®