From: Mihai Carabas <mihai.carabas@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
bobo.shaobowang@huawei.com, rdunlap@infradead.org
Subject: Re: [PATCH v5 3/3] misc/pvpanic: add PCI driver
Date: Tue, 16 Mar 2021 20:02:14 +0200 [thread overview]
Message-ID: <91231b60-d559-5d1e-aff8-303fefc1f25e@oracle.com> (raw)
In-Reply-To: <YFDq5Wj4AQOm/Bm4@kroah.com>
La 16.03.2021 19:29, Greg KH a scris:
> On Tue, Mar 16, 2021 at 07:08:38PM +0200, Mihai Carabas wrote:
>> ..snip..
>>>> +};
>>>> +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
>>>> +static unsigned int events;
>>>> +
>>>> +static ssize_t capability_show(struct device *dev,
>>>> + struct device_attribute *attr, char *buf)
>>>> +{
>>>> + return sysfs_emit(buf, "%x\n", capability);
>>> A global capability for all devices? No, this needs to be a per-device
>>> attttribute as you are showing it to userspace as such.
>> We can only have a pvpanic-pci device. This is necessary in that case?
> Why would it not be? Why constrain yourself to something that someone
> will only have to fix sometime in the future?
Agree. But why this got in in Jan2021 for pvpanic-mmio.c (ex. pvpanic.c)
like this :)?
next prev parent reply other threads:[~2021-03-16 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:20 [PATCH v5] add support for pci in the pvpanic driver Mihai Carabas
2021-03-16 12:20 ` [PATCH v5 1/3] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-03-16 16:44 ` Greg KH
2021-03-16 12:20 ` [PATCH v5 2/3] misc/pvpanic: probe multiple instances Mihai Carabas
2021-03-16 16:46 ` Greg KH
2021-03-16 12:20 ` [PATCH v5 3/3] misc/pvpanic: add PCI driver Mihai Carabas
2021-03-16 16:48 ` Greg KH
2021-03-16 17:08 ` Mihai Carabas
2021-03-16 17:29 ` Greg KH
2021-03-16 18:02 ` Mihai Carabas [this message]
2021-03-16 18:16 ` Greg KH
2021-03-17 0:02 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91231b60-d559-5d1e-aff8-303fefc1f25e@oracle.com \
--to=mihai.carabas@oracle.com \
--cc=arnd@arndb.de \
--cc=bobo.shaobowang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®