From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: linusw@kernel.org, andrew@lunn.ch, olteanv@gmail.com,
kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux@armlinux.org.uk,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 0/9] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB
Date: Mon, 19 Oct 2026 07:09:44 +0200 [thread overview]
Message-ID: <9124a33c-55b5-4c7a-b8a7-25d0bd4e6936@yahoo.com> (raw)
In-Reply-To: <CAJq09z4kKcQ+idfP+19pogi-H5s07SgKO-CGg7AWX8An-9p4Fw@mail.gmail.com>
On 10/19/2026 4:44 AM, Luiz Angelo Daros de Luca wrote:
>> This series adds support for the RTL8367S-VB (chip ID 0x6642) to the
>> rtl8365mb driver. The chip belongs to a new "family D" that differs from
>> the existing family C in its VLAN table layout, speed/RGMII configuration
>> and SerDes (SDS13) handling.
[...]
>
> Support for Family D is very welcome and increasingly necessary, as Family C
> ASICs are no longer being used in new designs. However, the current support
> still feels incomplete in critical areas.
>
> When porting a new switch family to rtl8365mb, each feature and hardware table
> shared with Family C needs to be verified against the new family's register
> layout. In particular, this series leaves rtl8365mb_l2.c untouched, but the L2
> table layout in Family D differs from Family C (from memory, the table entry
> format is 1 byte shorter and the bitfields are organized differently).
>
> Passing basic traffic in a default router setup can easily give a false sense
> of stability because the switch starts forwarding with factory defaults.
> However, as soon as DSA attempts to configure FDB entries, dump the L2 table,
> or manage multicast groups via bridge operations, the driver will interact with
> the L2 table using the wrong layout, causing silent data corruption.
>
> To make Family D truly upstream-ready, we should adapt these shared components
> (especially L2/FDB handling) or, at the very least, explicitly return
> -EOPNOTSUPP
> for unsupported operations so the driver fails gracefully instead of corrupting
> hardware state.
>
> In the cover letter, you mentioned the test device. Do you have the Archer AX55
> on your own bench now, or were these tests run remotely by users?
> Exercising full
> DSA functionality (FDB add/del/dump, VLAN filtering, STP, flooding controls)
> usually requires a dedicated local test setup where you can generate, sniff,
> and inspect traffic directly.
>
> Best regards,
>
> Luiz
To answer your question: no, I do not have the Archer AX55 or any other
RTL8367S-VB hardware on my bench, and I have no test environment of my own.
I cannot exercise FDB, VLAN filtering, STP or flooding controls myself.
All testing so far was done by other users who run this code on their
devices, and I depend on their reports.
The code was put together from the Realtek vendor SDK, the existing swconfig
driver code and the help of other contributors. It works on the setups where
it was tested (CPU port over HSGMII, bridge VLAN filtering and per-port
PVIDs), but I could not verify the shared parts against the family D
register layout, and you are right that rtl8365mb_l2.c is untouched.
Without a way to test, I cannot develop this further responsibly. I am
therefore leaving the series as it is for anyone with the hardware and a
proper test setup to pick up, adapt the L2/FDB handling and the remaining
shared code paths, and take it forward. I am happy for others to reuse,
rework or resubmit any part of it.
Best regards,
Mieczyslaw
prev parent reply other threads:[~2026-10-19 5:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5a4715dd-89e0-4868-9ffb-c8fb73b18d04.ref@yahoo.com>
2026-10-16 0:59 ` Mieczyslaw Nalewaj
2026-10-16 1:01 ` [PATCH net-next v6 1/9] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-10-16 13:50 ` Luiz Angelo Daros de Luca
2026-10-16 1:02 ` [PATCH net-next v6 2/9] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-10-16 13:53 ` Luiz Angelo Daros de Luca
2026-10-16 1:03 ` [PATCH net-next v6 3/9] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-10-16 20:04 ` Linus Walleij
2026-10-18 22:40 ` Luiz Angelo Daros de Luca
2026-10-18 23:04 ` Andrew Lunn
2026-10-19 8:28 ` Linus Walleij
2026-10-16 1:04 ` [PATCH net-next v6 4/9] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-10-16 20:06 ` Linus Walleij
2026-10-16 1:05 ` [PATCH net-next v6 5/9] net: dsa: realtek: rtl8365mb: set and get vlan 4k " Mieczyslaw Nalewaj
2026-10-16 20:06 ` Linus Walleij
2026-10-16 1:06 ` [PATCH net-next v6 6/9] net: dsa: realtek: rtl8365mb: use raw VID for PVID on " Mieczyslaw Nalewaj
2026-10-16 20:08 ` Linus Walleij
2026-10-16 1:07 ` [PATCH net-next v6 7/9] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-10-16 20:14 ` Linus Walleij
2026-10-16 1:08 ` [PATCH net-next v6 8/9] net: dsa: realtek: rtl8365mb: re-latch the family D SerDes Mieczyslaw Nalewaj
2026-10-16 20:17 ` Linus Walleij
2026-10-16 1:09 ` [PATCH net-next v6 9/9] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-10-16 20:17 ` Linus Walleij
2026-10-17 10:59 ` [PATCH net-next v6 0/9] " Stanislaw Pal
2026-10-19 2:44 ` Luiz Angelo Daros de Luca
2026-10-19 5:09 ` Mieczyslaw Nalewaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9124a33c-55b5-4c7a-b8a7-25d0bd4e6936@yahoo.com \
--to=namiltd@yahoo.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luizluca@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®