From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F32B6282F01 for ; Fri, 20 Mar 2026 13:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774013759; cv=none; b=jPzyriYE3uKfYjUqNrT6o/NZ0d1hEsZ2oWrqrLqPo0BFab0virA3p8TFNy+nq51tahSyUb8nyZ+60wA1Sj+WDRO3A42HTd0vIIuPpHzbc3Kwv7eaQG1PI04jYNiwkjnilJQnTrWFfMPlfcF82aqLBNw6cSMjai+5w+95mVblzOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774013759; c=relaxed/simple; bh=vOIODmvYnxGfLzFs6a25c4Q6CgP93l3ESJqaUth0kgA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UIYDs8wqzMPvlyF5fh1B08ZWvji20dzktMSZnS+EkhCFsYWMyf5JgIeFUU7KGzHdAS/V8eEvHjMqJb1GdxuKEQKfnYeD0d7BxltzIyDugof/15OW1B3RaPgQuWdVbRerrmeI9mtW2yQfv8YF385qocyawnmE3mQ9E+cccil+vt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=IYd/W5kQ; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="IYd/W5kQ" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-409de4132b5so354847fac.1 for ; Fri, 20 Mar 2026 06:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774013756; x=1774618556; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wk5S/NjC4u0xUL6oomLxP9g3uOp7kISttmV1Dk/7kAk=; b=IYd/W5kQ8Xq61cZX+4I8cxD3H6IFCCXWOfIsvrbg7FX1JsUB1alYnygqJQ/aO2o6Be R86jx6VyCXaueBpDk4ufRuh2P+CuJw/sSjwsrghwLrnGpk7o/lDY0nQVnS7yoFARzze8 7pkxXb/WkWv9pePx/oNQf+Ghx6J/EFc/Af38UJ3ncUUixocQujT4+rGJCGyAyrcgPqkw GUv9P5gDlvGbDyexlOq2u9gdg14aN7/Pu3xK/7zgGwcuTsA2cwd7dQ7TVi0UPy0Ap2tk 1v4wH7Ktw3saoN+d+iYtHDUDhvQwVPNQV3v+rYKhyZ4y3MITI8jjpFCj/gNU4Mp5qP5/ zOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774013756; x=1774618556; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wk5S/NjC4u0xUL6oomLxP9g3uOp7kISttmV1Dk/7kAk=; b=rOpdcltox2gT/YiVThTDaMT9GmwAOf84AeqXi35+tZTwi1vpi/WTabiaEXZGbwezVS lTa173mZ/IbeumbYiobRZgYLT2loT2lVj+4k29/5zCkjah96Mj6Q8WZ/zMOCvKvN4TRQ TPPUSRMHDVYXCi/nPxX0xk9htxxEQhQtemT+IvmQ55BMe5imDy4ccgzzQFts0UYKYreF sACU/FVw5PoDYH03zRuu4TCgt+Fy0A7VOwGL6y3pnkyBgoD9gbVl5nmmrvpnitajp2I6 Mmnu2gvZfLaFYgKTJIdqx4p2UM4NsmTL9dQ7tHSX5XpYLq1ZWOe0Yhnk2D4OVvVTeKAD 1/mg== X-Forwarded-Encrypted: i=1; AJvYcCXEwhB5FfxxP9amdVmPOlYuFDiw3l3ynho2EukejMyvvpbK9oUTjm4EfOvRXrSaGpTpjfmmu1ZDAE0y5cI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4lkNDCtXr1QWFAmpvbsGwt7iABIpo83qbTAhdbOyAkkWKm0Io CNrY4RQ4ylwOoWjJDK8VGwPd5OHaqLZwrHWxujGnlcAx6CVk4HbWSFva3XV2qEWtJaM= X-Gm-Gg: ATEYQzyzam63Fx5B/Mv7ITHNfzt6cuzKNRLd8zjsoyksGEsBzwwdKSQgTjrMZDWHABW ZQRymRgT9YkfB14oIfIjCHWTgsT6tYu3PTSiMCG5NBJ99LGeArvTsSbovxaD+EHBJXtuNpQD8Iz 5iIfaTilheIMjlZvR1ebPh+Vu1awuePa/iT4C0X4k+DVIaOGFmidIt78V2dASWPAA0wCwk98I8a 1FSBDzBz47ZHrKiFsKBOxZR0x8pBHKESm3UCmqPwyR3gnMrbZFBfVGRjOfKXefOQ8HkyyMNyhQW aElt002KsJFfsf2lkDTo2hh9xQWBGGcdaEgMp/WhpgBjHk1ckBBQ6rJs4mdLFN4AkUTZAhYPnBn 2OVll0bTxvf7o88wb0ZtkcEUWQuwE/hBs0PSPNeMyKFEt5ooRqqEEjGOvOJmWBtRh3qjNxhoRmx LyUTQfbAbcRP6L4hs2tTPEuT18dRNbx4sHVpthsPWLpVYeNWxOpqh59REHtndz+iIuA9rh3eE= X-Received: by 2002:a05:6870:e9aa:b0:417:23f2:6d77 with SMTP id 586e51a60fabf-41c10fd1b74mr1962084fac.16.1774013755741; Fri, 20 Mar 2026 06:35:55 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:6a3c:6fc:3be2:208d? ([2600:8803:e7e4:500:6a3c:6fc:3be2:208d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41c1497485esm2142629fac.8.2026.03.20.06.35.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Mar 2026 06:35:55 -0700 (PDT) Message-ID: <9124e760-6e9e-4621-b684-071dbb271635@baylibre.com> Date: Fri, 20 Mar 2026 08:35:54 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: mediatek: add device-tree for Genio 720-EVK board To: Louis-Alexis Eyraud , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Sean Wang Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20251203-add-mediatek-genio-520-720-evk-v1-0-df794b2a30ae@collabora.com> <20251203-add-mediatek-genio-520-720-evk-v1-3-df794b2a30ae@collabora.com> <7d1e52c0b9c3a6d30e9db617b9bcfa23ed9046b5.camel@collabora.com> Content-Language: en-US From: David Lechner In-Reply-To: <7d1e52c0b9c3a6d30e9db617b9bcfa23ed9046b5.camel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/26 7:37 AM, Louis-Alexis Eyraud wrote: > Hi David, > > On Thu, 2026-03-12 at 19:26 -0500, David Lechner wrote: >> On 12/3/25 7:59 AM, Louis-Alexis Eyraud wrote: >>> Add support for MediaTek MT8189 SoC and its variants, and a device- >>> tree >>> for the basic hardware enablement of the Genio 720-EVK board, based >>> on >>> MT8391 SoC. >>> >> >> ... >> >>> + mmc0_default_pins: mmc0-default-pins { >>> + pins-clk { >>> + pinmux = ; >>> + drive-strength = <6>; >>> + bias-pull-down = ; >>> + }; >>> + >>> + pins-cmd-dat { >>> + pinmux = >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + ; >>> + input-enable; >>> + drive-strength = <6>; >>> + bias-pull-up = ; >>> + }; >> >> Should we also have pins-ds here to match mmc0-uhs-pins? >> > The data strobe pin is only used for the HS modes, that is why it is > only declared for uhs state. > No other mediatek board devicetrees have it for default state too, so I > don't think it is needed here. > >>> + >>> + pins-rst { >>> + pinmux = >>> ; >>> + drive-strength = <6>; >>> + bias-pull-up = ; >>> + }; >>> + }; >>> + >>> + mmc0_uhs_pins: mmc0-uhs-pins { >>> + pins-clk { >>> + pinmux = ; >>> + drive-strength = <8>; >>> + bias-pull-down = ; >>> + }; >>> + >>> + pins-cmd-dat { >>> + pinmux = >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + ; >>> + input-enable; >>> + drive-strength = <8>; >>> + bias-pull-up = ; >>> + }; >>> + >>> + pins-ds { >>> + pinmux = ; >>> + drive-strength = <8>; >>> + bias-pull-down = ; >>> + }; >>> + >>> + pins-rst { >>> + pinmux = >>> ; >>> + bias-pull-up = ; >>> + }; >>> + }; >>> + >>> + mmc1_default_pins: mmc1-default-pins { >>> + pins-clk { >>> + pinmux = ; >>> + drive-strength = <6>; >>> + bias-pull-down = ; >>> + }; >>> + >>> + pins-cmd-dat { >>> + pinmux = >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + ; >>> + input-enable; >>> + drive-strength = <6>; >>> + bias-pull-up = ; >>> + }; >>> + >>> + pins-insert { >>> + pinmux = ; >>> + bias-pull-up; >>> + }; >>> + }; >>> + >>> + mmc1_uhs_pins: mmc1-uhs-pins { >>> + pins-clk { >>> + pinmux = ; >>> + drive-strength = <8>; >>> + bias-pull-down = ; >>> + }; >>> + >>> + pins-cmd-dat { >>> + pinmux = >>> , >>> + >>> , >>> + >>> , >>> + >>> , >>> + ; >>> + input-enable; >>> + drive-strength = <8>; >>> + bias-pull-up = ; >>> + }; >> >> Don't we also need pins-insert here? (to match mmc1-default-pins) >> > From what I've found, it was done this way for other board devicetrees > to avoid possible reconfiguration happen for the card detection pin > while switching to UHS and causing a switch failure. > Also, what you declare in pinmux nodes is how the pin configuration > should change in a specific mode and you declare only what changes, and > not what stay the same. > >> I was having trouble with the CD input pin not working in U-Boot >> until I added it. > I checked and debugged this on my board and did not get that kind of > issue, whether this pin config is not present for uhs state or if I add > it. > When inserting my sd card or when I boot with it already inserted, the > mtk-sd driver first sets the pinctrl state to default before switching > to ufs. The GPIO02 pin config is also OK in both states. > The mt8189 pinctrl driver seems to apply a default config for this pin > that is the same as the one that is set here. > > There might be u-boot particularities that could explain it fixes your > issue. > > Regards, > Louis-Alexis >> >>> + }; >>> + Thanks for having a look at this and taking the time to explain. I will see what I can do to fix it in U-Boot.