From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Daniel Wagner <dwagner@suse.de>, Yi Zhang <yi.zhang@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v3 0/3] More fixes for FC enabling
Date: Thu, 6 Jul 2023 06:51:30 +0000 [thread overview]
Message-ID: <9125301c-61e0-96e4-35be-94d9c9565e90@nvidia.com> (raw)
In-Reply-To: <op7hkwiauywfosn4q4h3cihdzcoy4m4vqthanv4urwxo4trazy@2qtljklkt4ry>
On 7/4/2023 12:08 AM, Shinichiro Kawasaki wrote:
> On Jul 03, 2023 / 11:16, Daniel Wagner wrote:
>> I've rebased the series on the current HEAD and moved the def_hostnqn bits from
>> the second patch to the third. This should make it more consistent in commit
>> history.
>>
>> Also retested and found a bug in the context matching code in libnvme which I
>> post a fix too.
>
> Thanks Daniel.
>
> One thing I noticed is that now the 3rd patch removes the references from
> nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since
> I see the motivation discussed here [1]. I will wait for several days to make
> sure it's ok for others. In case anyone relies on those files to set up blktests
> environment, please speak up.
>
> [1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/
>
> Other that, changes in v3 looks good to me. If there is no voice, I'll apply
> the patches as they are.
Adding Max and Yi who were part of original discussion [1].
-ck
next prev parent reply other threads:[~2023-07-06 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 9:16 Daniel Wagner
2023-07-03 9:16 ` [PATCH blktests v3 1/3] nvme/048: Check for queue count check directly Daniel Wagner
2023-07-03 9:16 ` [PATCH blktests v3 2/3] nvme/rc: Avoid triggering host nvme-cli autoconnect Daniel Wagner
2023-07-03 9:16 ` [PATCH blktests v3 3/3] nvme/{041,042,043,044,045,048}: Use default hostnqn and hostid Daniel Wagner
2023-07-04 7:08 ` [PATCH blktests v3 0/3] More fixes for FC enabling Shinichiro Kawasaki
2023-07-06 6:51 ` Chaitanya Kulkarni [this message]
2023-07-10 3:52 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9125301c-61e0-96e4-35be-94d9c9565e90@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®