From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] tty: serial: remove hub6 multiport support
Date: Fri, 16 Oct 2026 16:41:39 +0200 [thread overview]
Message-ID: <912aecf9-b135-48fb-b539-52ba3a1704a1@app.fastmail.com> (raw)
In-Reply-To: <atImm4Ixv_PwUqLb@ashevche-desk.local>
On Fri, Oct 16, 2026, at 15:28, Andy Shevchenko wrote:
> On Fri, Oct 16, 2026 at 02:59:47PM +0200, Arnd Bergmann wrote:
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> But there are some minor issues to fix, see below.
>
> ...
>
>> {
>> unsigned long old_iobase, old_mapbase;
>> - unsigned int old_type, old_iotype, old_hub6, old_shift;
>> + unsigned int old_type, old_iotype, old_shift;
>
> Move it line up, so we will have reversed xmas tree order.
>
> ...
>
>> + /* hub6 is no longer support */
>> + if (new_info->hub6 != 0)
>> + return -EINVAL;
>
> Please, fix the indentation, should use tabs.
Fixed both, and the typo in the comment here, thanks
for the review!
Arnd
next prev parent reply other threads:[~2026-10-16 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 12:59 Arnd Bergmann
2026-10-16 12:59 ` [PATCH 2/2] [v2] serial: 8250: remove obsolete and broken PORT_RSA support Arnd Bergmann
2026-10-16 13:14 ` Arnd Bergmann
2026-10-16 13:28 ` [PATCH 1/2] tty: serial: remove hub6 multiport support Andy Shevchenko
2026-10-16 14:41 ` Arnd Bergmann [this message]
2026-10-16 13:32 ` Andy Shevchenko
2026-10-16 14:10 ` Hugo Villeneuve
2026-10-16 15:56 ` Hugo Villeneuve
2026-10-16 16:16 ` Arnd Bergmann
2026-10-16 17:17 ` Hugo Villeneuve
2026-10-16 16:48 ` Hugo Villeneuve
2026-10-16 17:12 ` Arnd Bergmann
2026-10-16 17:16 ` Hugo Villeneuve
2026-10-16 18:28 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=912aecf9-b135-48fb-b539-52ba3a1704a1@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®