From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=80.86.107.70 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794169816; b=U5f24NLAFqfMt4kafXkEBr6w76JtpGo1bKUDK7u28+WLSw5AwSI8ilD2xRSps5eRQrRA /4fdjAOJPLcWDk6YWsCjayhPuLOHSlZXBvQQAfWshr1ubLkJjeYvqsw0oLs7x9i7mFWjo n9eEvOsNsW94R4APi9A9PvSzcP8nZqIlVG7ac08v53hN5OzE8SYqQUfSw9iXLZYvEtwH7 XEgt6QouBPQWIWQajOFPa8CMdZXS943dhDhjlWqhSoLNX5PBWb7M7O0tvcloFtlduTUfH R4TKzIYx/JFBMXSr1BnOJ2zEmdoimpOksd4YRlNinL1/nfNcU2tvzt0x4YQmeFOoy+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794169816; h=DMARC-Filter:Received:DKIM-Filter:DKIM-Signature:Message-ID:Subject: From:To:Cc:Date:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:User-Agent:MIME-Version; bh=CLg0dkhkAHqwvH4NqaW3nQ9pKyM6DLsfJFXhxQWDQ00=; b=TPk42m2ywN9KMkOp7ShGw3blD2ToGL6GOHPKMK9zYOJ/1G1T7+jiT+Uqc0WcDrl8Np/i duk+jp51AjSG5v00mD19SFLAeNSuZ/FSSpvMoYrFCtRDcLUwsFksGd8mDWPjIPN2xlM/p 0/Hy5Gt/oJwewSaIrvPBlcCSnmi1CS8t2M8B9VzSxRTDtFzY00ZuluDj8ygEFGNrzAoJP ceyRe8tOirfa8NmC12xt+tM7p6XhrnrCoKbEZI//GkLiR/AJNh//hEyXwt0/ThFY4U6sQ 4a9c0ZWD1TFsQSHrhEODERDZYDcp0HG59dY1B32XSTuMQFh/qwf5+5EXKdteCKKfd6Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=rendec.net; spf=pass smtp.mailfrom=rendec.net; dkim=pass header.d=rendec.net header.i=@rendec.net header.a=rsa-sha256 header.s=default header.b=i4poTfs6; arc=none smtp.remote-ip=80.86.107.70 Received: from mail.mindbit.ro (xs1.mindbit.ro [80.86.107.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 563C0606D80E for ; Sun, 8 Nov 2026 20:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 563C0606D80E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=rendec.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rendec.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rendec.net header.i=@rendec.net header.a=rsa-sha256 header.s=default header.b=i4poTfs6 Received: from dog.kanata.rendec.net (pool-174-112-193-187.cpe.net.cable.rogers.com [174.112.193.187]) by mail.mindbit.ro (Postfix) with ESMTPSA id 39EDFD4223; Sun, 8 Nov 2026 22:30:11 +0200 (EET) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.mindbit.ro 39EDFD4223 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rendec.net; s=default; t=1794169813; bh=CLg0dkhkAHqwvH4NqaW3nQ9pKyM6DLsfJFXhxQWDQ00=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=i4poTfs6sLriei2b8QRGHlw6KjyTG6NLgwR+p3tAfmpwrNOONvb8J77ZkXxCA8CL3 sYO03+q9Hfzuaklw4QWATFZIvjr3StGH5Q50CzVOxzMFbF0jO25m27QiCyuq5QTiIo DqnkQrOGyVI1Bh0WsAi9HAeCarhrfENIHg+m9apQdrXKKbA7pl5nkE23uIBulrv2lA M0XEpsFyWZgq+lAOtg0C7elFUGWh0nYDdws+3END/2OoNC/BZiN+1OQIA2qLVKFMxW SK25IMV8g6j2S6yZAWzU2V7ckPD/GigjTvfcIwYUU3nav3gxA33A7iWEKuRj9KId9k ChTKFNl9KelFw== Message-ID: <912bdd213166ff7d6c24580896b92bb0a3edea78.camel@rendec.net> Subject: Re: [PATCH v7 10/10] irqchip/imx-irqsteer: Use devm_irq_domain_create_linear() From: Radu Rendec To: Zhipeng.wang_1@oss.nxp.com, Thomas Gleixner , Marc Zyngier , Frank Li Cc: Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Fabio Estevam , Jindong Yue , xuegang.liu@nxp.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Date: Sun, 08 Nov 2026 15:30:09 -0500 In-Reply-To: <20261104073759.386777-11-Zhipeng.wang_1@oss.nxp.com> References: <20261104073759.386777-1-Zhipeng.wang_1@oss.nxp.com> <20261104073759.386777-11-Zhipeng.wang_1@oss.nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-2.fc43) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Wed, 2026-11-04 at 16:37 +0900, Zhipeng.wang_1@oss.nxp.com wrote: > From: Zhipeng Wang >=20 > Replace irq_domain_create_linear() with the new > devm_irq_domain_create_linear() helper, so the IRQ domain is released > automatically on unbind and remove() no longer has to call > irq_domain_remove(). No functional change. >=20 > Signed-off-by: Zhipeng Wang > --- > =C2=A0drivers/irqchip/irq-imx-irqsteer.c | 7 +++---- > =C2=A01 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx= -irqsteer.c > index d15b806b278c..da6e8d1bbec1 100644 > --- a/drivers/irqchip/irq-imx-irqsteer.c > +++ b/drivers/irqchip/irq-imx-irqsteer.c > @@ -248,8 +248,9 @@ static int imx_irqsteer_probe(struct platform_device = *pdev) > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > - data->domain =3D irq_domain_create_linear(dev_fwnode(&pdev->dev), data-= >reg_num * 32, > - &imx_irqsteer_domain_ops, data); > + data->domain =3D devm_irq_domain_create_linear(&pdev->dev, dev_fwnode(&= pdev->dev), > + =C2=A0=C2=A0=C2=A0=C2=A0 data->reg_num * 32, > + =C2=A0=C2=A0=C2=A0=C2=A0 &imx_irqsteer_domain_ops, data); > =C2=A0 if (!data->domain) { > =C2=A0 dev_err(&pdev->dev, "failed to create IRQ domain\n"); > =C2=A0 return -ENOMEM; > @@ -298,8 +299,6 @@ static void imx_irqsteer_remove(struct platform_devic= e *pdev) > =C2=A0 for (hwirq =3D 0; hwirq < irqsteer_data->reg_num * 32; hwirq++) > =C2=A0 irq_dispose_mapping(irq_find_mapping(irqsteer_data->domain, hwirq= )); > =C2=A0 > - irq_domain_remove(irqsteer_data->domain); > - > =C2=A0 if (ret >=3D 0) > =C2=A0 pm_runtime_put_noidle(&pdev->dev); > =C2=A0} Reviewed-by: Radu Rendec