mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Bui Duc Phuc <phucduc.bui@gmail.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Cheng-Yi Chiang <cychiang@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	povik+lin@cutebit.org, u.kleine-koenig@baylibre.com,
	kuninori.morimoto.gx@renesas.com, christian.ehrhardt@codasip.com,
	Linus Walleij <linusw@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Thorsten Blum <thorsten.blum@linux.dev>,
	Chris Morgan <macromorgan@hotmail.com>,
	Dan Carpenter <error27@gmail.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Rosen Penev <rosenp@gmail.com>,
	Weidong Wang <wangweidong.a@awinic.com>,
	Teguh Sobirin <teguh@sobir.in>, Val Packett <val@packett.cool>,
	Luca Weiss <luca.weiss@fairphone.com>,
	wangdicheng <wangdicheng@kylinos.cn>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com, chrome-platform@lists.linux.dev,
	asahi@lists.linux.dev, Mark Brown <broonie@kernel.org>,
	Takashi Iwai <tiwai@suse.com>, Tzung-Bi Shih <tzungbi@kernel.org>,
	David Rhodes <david.rhodes@cirrus.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [PATCH v2 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers
Date: Mon, 6 Jul 2026 11:58:02 +0100	[thread overview]
Message-ID: <91335528-fe36-44c7-8e72-37bb0d4f2620@opensource.cirrus.com> (raw)
In-Reply-To: <CAABR9nGSRH3DmehUxQVmfJ4Po8TOhfHXDnjjkzVJDZZ1w0_51w@mail.gmail.com>

On 06/07/2026 11:46 am, Bui Duc Phuc wrote:
> Hi Cezary, Richard,
> 
> Thanks to both of you for the reviews!
> 
>>> -     ret = IRQ_HANDLED;
>>> +     return IRQ_HANDLED;
>>>
>>> -err:
>>> -     pm_runtime_put(cs35l56_base->dev);
>>> -err_unlock:
>>> -     mutex_unlock(&cs35l56_base->irq_lock);
>>> -
>>> -     return ret;
>>>    }
>> Nitpick: this will leave a superfluous newline.
> 
> You're right. I'll remove the extra blank line.
> 
>> It looks like a bug that it checks rv but returns ret.
> 
> I'm not sure I fully understand what you meant by that comment. This
> conversion preserves the existing behavior, so although checking rv
> and returning ret may look a bit odd, I don't think it changes the
> behavior or introduces a bug.
> 

I mean the code is correct but it looks wrong. Because it tests for
an error in rv but then returns a value in ret.

This can be cleaned up now. ret isn't needed because it can return
IRQ_NONE in all these places.

>> The local ret variable can be deleted.
>> Should change all the error returns to directly return IRQ_NONE.
> 
> As you suggested,
> I'll remove the ret variable entirely and return IRQ_NONE /
> IRQ_HANDLED directly.
> 
> Best regards,
> Phuc


  reply	other threads:[~2026-07-06 10:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03  5:53 [PATCH v2 00/24] ASoC: codecs: Use guard() for mutex & spin lock - part 1 phucduc.bui
2026-07-03  5:53 ` [PATCH v2 01/24] ASoC: codecs: ab8500: Use guard() for mutex locks phucduc.bui
2026-07-03  5:53 ` [PATCH v2 02/24] ASoC: codecs: ak4613: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 03/24] ASoC: codecs: arizona-jack: Use guard() cleanup helpers phucduc.bui
2026-07-06 12:58   ` Charles Keepax
2026-07-07  2:29     ` Bui Duc Phuc
2026-07-03  5:53 ` [PATCH v2 04/24] ASoC: codecs: arizona: Use guard() for mutex locks phucduc.bui
2026-07-03  5:53 ` [PATCH v2 05/24] ASoC: codecs: aw87390: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 06/24] ASoC: codecs: aw88081: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 07/24] ASoC: codecs: aw88166: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 08/24] ASoC: codecs: aw88261: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 09/24] ASoC: codecs: aw88395: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 10/24] ASoC: codecs: aw88399: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 11/24] ASoC: codecs: cros_ec_codec: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 12/24] ASoC: codecs: cs-amp-lib: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers phucduc.bui
2026-07-06  9:38   ` Richard Fitzgerald
2026-07-06 10:12   ` Cezary Rojewski
2026-07-06 10:46     ` Bui Duc Phuc
2026-07-06 10:58       ` Richard Fitzgerald [this message]
2026-07-06 12:37         ` Bui Duc Phuc
2026-07-03  5:53 ` [PATCH v2 14/24] ASoC: codecs: cs42l42: Use guard() cleanup helpers phucduc.bui
2026-07-03  5:53 ` [PATCH v2 15/24] ASoC: codecs: cs42l43: Use guard() and PM runtime scope helpers phucduc.bui
2026-07-06 13:18   ` Charles Keepax
2026-07-07  3:59     ` Bui Duc Phuc
2026-07-03  5:53 ` [PATCH v2 16/24] ASoC: codecs: cs42l84: Use guard() for mutex locks phucduc.bui
2026-07-03  5:53 ` [PATCH v2 17/24] ASoC: codecs: cs43130: " phucduc.bui
2026-07-06 13:20   ` Charles Keepax
2026-07-03  5:53 ` [PATCH v2 18/24] ASoC: codecs: cs47l15: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 19/24] ASoC: codecs: cs47l35: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 20/24] ASoC: codecs: cs47l85: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 21/24] ASoC: codecs: cs47l90: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 22/24] ASoC: codecs: cs47l92: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 23/24] ASoC: codecs: cs48l32: " phucduc.bui
2026-07-06 13:23   ` Charles Keepax
2026-07-03  5:53 ` [PATCH v2 24/24] ASoC: codecs: cs2072x: " phucduc.bui
2026-07-06 10:21 ` [PATCH v2 00/24] ASoC: codecs: Use guard() for mutex & spin lock - part 1 Cezary Rojewski
2026-07-07  4:40   ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91335528-fe36-44c7-8e72-37bb0d4f2620@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=arnd@arndb.de \
    --cc=asahi@lists.linux.dev \
    --cc=bleung@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=christian.ehrhardt@codasip.com \
    --cc=chrome-platform@lists.linux.dev \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=cychiang@chromium.org \
    --cc=david.rhodes@cirrus.com \
    --cc=error27@gmail.com \
    --cc=groeck@chromium.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=macromorgan@hotmail.com \
    --cc=marco.crivellari@suse.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=phucduc.bui@gmail.com \
    --cc=povik+lin@cutebit.org \
    --cc=rosenp@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=teguh@sobir.in \
    --cc=thorsten.blum@linux.dev \
    --cc=tiwai@suse.com \
    --cc=tzungbi@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=val@packett.cool \
    --cc=wangdicheng@kylinos.cn \
    --cc=wangweidong.a@awinic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®