From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753732AbeAOFL2 (ORCPT + 1 other); Mon, 15 Jan 2018 00:11:28 -0500 Received: from merlin.infradead.org ([205.233.59.134]:35668 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbeAOFLW (ORCPT ); Mon, 15 Jan 2018 00:11:22 -0500 From: Randy Dunlap Subject: [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT To: Platform Driver , LKML Cc: Darren Hart , Andy Shevchenko Message-ID: <913480bb-d06a-3f13-e8fc-20f83ff499a0@infradead.org> Date: Sun, 14 Jan 2018 21:11:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Randy Dunlap Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. This also makes all platform/x86/ drivers consistent w.r.t depending on INPUT instead of selecting it. Signed-off-by: Randy Dunlap Cc: Darren Hart Cc: Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org --- drivers/platform/x86/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- lnx-415-rc8.orig/drivers/platform/x86/Kconfig +++ lnx-415-rc8/drivers/platform/x86/Kconfig @@ -812,9 +812,8 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" - depends on ACPI + depends on ACPI && INPUT depends on RFKILL || RFKILL=n - select INPUT select BACKLIGHT_CLASS_DEVICE help Support for Intel Classmate PC ACPI devices, including some