mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, ceph-devel@vger.kernel.org,
	Alex Markuze <amarkuze@redhat.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	Viacheslav Dubeyko <slava@dubeyko.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ceph: fix writeback_count leak in write_folio_nounlock()
Date: Tue, 2 Jun 2026 20:26:37 +0200	[thread overview]
Message-ID: <913d1b9f-627a-47f8-856d-6b20bf552247@web.de> (raw)
In-Reply-To: <20260602090754.3678981-1-vulab@iscas.ac.cn>

…
> Add atomic_long_dec() calls on all error paths that currently return

      atomic_long_dec_return()?


> without decrementing the counter.

Can any duplicate source code be avoided in affected if branches
of the function implementation “write_folio_nounlock”?
https://elixir.bootlin.com/linux/v7.1-rc6/source/fs/ceph/addr.c#L717-L874

Regards,
Markus

      reply	other threads:[~2026-06-02 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  9:07 Wentao Liang
2026-06-02 18:26 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=913d1b9f-627a-47f8-856d-6b20bf552247@web.de \
    --to=markus.elfring@web.de \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    --cc=stable@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®