From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 085472F7444 for ; Wed, 24 Dec 2025 12:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766578935; cv=none; b=hDSiQ1JCLliY+l+6o3VNWAKASTbnNg+xjzbiPIOGX8WSKxHVWTPD9dSIeMOUZbOh4SRh4qtxQu8gcGd40lOuJGSTnk7xAvJdYt8BjATrMzophDS3hpV9R5VWZjlsT/39awLXkX2QywqmI/0Fvh6SDKBuxYutv9hVFIIFtQ+MwE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766578935; c=relaxed/simple; bh=nUyCZA0w+J8V4qN49QUYUhTLX6xbASa4PyskQSL8xN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=meAOvMlkP5/Pasv/+2MeymF4sLWpYb2F48e9vL8MFTLvRXmwjpSUK9fzcZGQxFf8l6gI0iw+m+KgEqXvTVSdYKqbeStxnuyVShtEr0oVUfiZ0suBoRWC4F8UbNdht0mkivpDi8sq/r6tH+n5KEQ57JxA9zBboCMMG8uhZp1Bjqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fdYSltIl; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fdYSltIl" Message-ID: <913d3349-9ae8-4fbf-9de0-b627cad12c24@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766578928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4HimEiFvEpjNM/KP9ZP7eDvgtRaba89QYB7YmI/yJS4=; b=fdYSltIl8I9+SQyNxStBxRO/Wra07Y2shBxkql1hJnCZQRpVSpzcGhxEXlcIDhWxJjhKjM a/mv/0Jq3kvFBpD9Hn6pEc6QJgTAP0cgEM9FOV2Gg7AJx5k+Hd3onkqxhOA6ZHnQNLGcA/ 8uwlyQlVLWlAutiMW4MbQUlqCI8Vo3M= Date: Wed, 24 Dec 2025 20:21:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH V2 3/5] mm/khugepaged: change collapse_pte_mapped_thp() to return void Content-Language: en-US To: Shivank Garg Cc: Zi Yan , David Hildenbrand , Baolin Wang , "Liam R . Howlett" , Nico Pache , Andrew Morton , Ryan Roberts , Dev Jain , Barry Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes References: <20251224111351.41042-4-shivankg@amd.com> <20251224111351.41042-10-shivankg@amd.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <20251224111351.41042-10-shivankg@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2025/12/24 19:13, Shivank Garg wrote: > The only external caller of collapse_pte_mapped_thp() is uprobe, which > ignores the return value. Change the external API to return void to > simplify the interface. > > Introduce try_collapse_pte_mapped_thp() for internal use that preserves > the return value. This prepares for future patch that will convert > the return type to use enum scan_result. > > Suggested-by: David Hildenbrand (Red Hat) > Signed-off-by: Shivank Garg > --- Looks good overall, thanks! Acked-by: Lance Yang