From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78C9C636CC for ; Wed, 15 Feb 2023 05:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233319AbjBOFgo (ORCPT ); Wed, 15 Feb 2023 00:36:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233142AbjBOFgm (ORCPT ); Wed, 15 Feb 2023 00:36:42 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9839C2A9B0 for ; Tue, 14 Feb 2023 21:36:41 -0800 (PST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31F0FutM025508; Wed, 15 Feb 2023 05:36:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=eMsxikA2FKWM0cAyyuNKptymaSt/npyL9FJnQ+uOQSc=; b=FxV3qwIoK5wvwqTwdtx7P/Xe30YZTQUDQ3mDE7kvtyKG9/DvuUhxiQvsmPFBrQVhA80l pBrlyPw0yLyyNGvZQiKVPJcZldKd/WKNvlsT7Exo6+iqLrZsekfrishLhD72Dccb5MD/ /Suy/Ny1G8GO1FykHApHU9azG2cNoH8DurHJ/v6wMLoO6wB0y10B2B1rXWMUCIuH/8Mz eov1w0tlxE/dralzhJYIGSokDo5dkkE5DjUHFQT63LV2lw5K3nYaLldH9ZNfCAPpVDGk tVrnQkPEHSjhFBuhgPIVBJn7AnogKtCnco+JJGCvN/oQmL5Hhvvk+J8ZbmKWMKIKNXoU cw== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nrhx3s0vf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Feb 2023 05:36:26 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31F5aQCx028070 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Feb 2023 05:36:26 GMT Received: from [10.213.73.166] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 14 Feb 2023 21:36:24 -0800 Message-ID: <913fea79-09f9-b976-ff1a-cd833784abb6@quicinc.com> Date: Wed, 15 Feb 2023 11:05:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V1] um: Fix compilation warnings Content-Language: en-US To: Richard Weinberger CC: anton ivanov , Johannes Berg , linux-um , linux-kernel References: <1676410243-10566-1-git-send-email-quic_c_spathi@quicinc.com> <1950127775.130646.1676411821807.JavaMail.zimbra@nod.at> From: Srinivasarao Pathipati In-Reply-To: <1950127775.130646.1676411821807.JavaMail.zimbra@nod.at> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: _xvosdkay_gpVVwM-dww_kVZiKxqBlj1 X-Proofpoint-GUID: _xvosdkay_gpVVwM-dww_kVZiKxqBlj1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-15_02,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 mlxlogscore=677 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302150049 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/2023 3:27 AM, Richard Weinberger wrote: > ----- Ursprüngliche Mail ----- >> Von: "Srinivasarao Pathipati" >> static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc) >> { >> - struct uml_pt_regs r; >> + struct uml_pt_regs *r; >> int save_errno = errno; >> >> - r.is_user = 0; >> + r = malloc(sizeof(struct uml_pt_regs)); > I fear this is not correct since malloc() is not async-signal safe. Thanks Richard for quick response. Could you please suggest alternative function of malloc() with async-signal safe. if that is not possible Is there any other way to fix this warning? OR do we need to live with that warning? > > Thanks, > //richard