From: Song Liu <songliubraving@fb.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"Kernel Team" <Kernel-team@fb.com>
Subject: Re: [PATCH v5 2/4] perf: support build BPF skeletons with perf
Date: Mon, 28 Dec 2020 17:33:10 +0000 [thread overview]
Message-ID: <91431F35-1C62-42C6-9CB8-E7BF7BC32BB0@fb.com> (raw)
In-Reply-To: <20201228125554.GC450923@krava>
> On Dec 28, 2020, at 4:55 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Tue, Dec 15, 2020 at 10:14:10AM -0800, Song Liu wrote:
>
> SNIP
>
>> HOSTCC ?= gcc
>> HOSTLD ?= ld
>> HOSTAR ?= ar
>> +CLANG ?= clang
>> +LLVM_STRIP ?= llvm-strip
>>
>> PKG_CONFIG = $(CROSS_COMPILE)pkg-config
>> LLVM_CONFIG ?= llvm-config
>> @@ -735,7 +739,8 @@ prepare: $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h archheaders $(drm_ioc
>> $(x86_arch_prctl_code_array) \
>> $(rename_flags_array) \
>> $(arch_errno_name_array) \
>> - $(sync_file_range_arrays)
>> + $(sync_file_range_arrays) \
>> + bpf-skel
>>
>> $(OUTPUT)%.o: %.c prepare FORCE
>> $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=$(build-dir) $@
>> @@ -1008,7 +1013,43 @@ config-clean:
>> python-clean:
>> $(python-clean)
>>
>> -clean:: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBPERF)-clean config-clean fixdep-clean python-clean
>> +SKEL_OUT := $(abspath $(OUTPUT)util/bpf_skel)
>> +SKEL_TMP_OUT := $(abspath $(SKEL_OUT)/.tmp)
>> +SKELETONS :=
>> +
>> +ifdef BUILD_BPF_SKEL
>> +BPFTOOL := $(SKEL_TMP_OUT)/bpftool-bootstrap
>
> I think this needs to be:
>
> BPFTOOL := $(SKEL_TMP_OUT)/bootstrap/bpftool
>
> otherwise it won't compile for me
Yeah, we need the new name. When I sent v5, the patch that renamed the bootstrap
bpftool was in bpf-next, but not in Arnaldo's perf/core.
I will send v6 with this change included.
Thanks,
Song
next prev parent reply other threads:[~2020-12-28 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 18:14 [PATCH v5 0/4] Introduce perf-stat -b for BPF programs Song Liu
2020-12-15 18:14 ` [PATCH v5 1/4] bpftool: add Makefile target bootstrap Song Liu
2020-12-15 18:14 ` [PATCH v5 2/4] perf: support build BPF skeletons with perf Song Liu
2020-12-28 12:55 ` Jiri Olsa
2020-12-28 17:33 ` Song Liu [this message]
2020-12-15 18:14 ` [PATCH v5 3/4] perf-stat: enable counting events for BPF programs Song Liu
2020-12-15 18:14 ` [PATCH v5 4/4] perf-stat: add documentation for -b option Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91431F35-1C62-42C6-9CB8-E7BF7BC32BB0@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®