From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2797239DBE6 for ; Tue, 10 Mar 2026 14:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151992; cv=none; b=tHHwDlZMFp3Fiw/WtYRCokkNstw4lFznsuETPB+l7KSQpJzNP7w8Z2tgHcD/hiAX/Op7iEk0wyyTJ0vKZBT7YUjQKEfEL93eiz6J0/0yG7tQDRQCuGDND6Ztvql6KRKUNPjCZKP/IgX+R0TwT36cHu8HftkduOGr9ZmjXypeMec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151992; c=relaxed/simple; bh=fuHMn095nXnFWpT3nvSDB5emiYVKz1ZSOBPXG+Z7VVM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dewE9AaKM0Tiu7kifgpWDC0rkZvnvpP+At4/0spLFs2fXyERslpMKM2bA8s168HaRaMeCZVC00/J9fSzNlr8XG88HNFigXqFYnhCRGxBvBPLu7JBpMFOEIdCieWoNlHc7nG3dCFQfNLZaa/cvCAqIK2HXzg2sri0ODAlLg4CFgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fSGkSXoL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V3bBtZar; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fSGkSXoL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V3bBtZar" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaS3n3759039 for ; Tue, 10 Mar 2026 14:13:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uj7lRluEZ+PijDD6FAfpyVAEjjvz57dxZpftGNLTZuE=; b=fSGkSXoL6BwpNJAL TNBy0v+QW7JImjzR/ehgL8s+PmUs+bwuYfBP8QFCybN3Q76IO7lSoiirWQedfmED 3oMQwAIbZZ3MDHwah9qIkxFxqofbqJGPGs63w1rXCeju5+kGMGxH+cGTbNlgBB+1 BRx2Uxb+OEZnDFph6YpVwSg4ddkeiw9CPb6EBef4XT4hgyYhVVKRZWMpdY+edSBw pFe7NIGogQFF3MDx818ubnXeL5BrqE/6gdZjv8fScVLUNr7gpEZvpdoreGO63ijU VsqL63m/JGO7BCwUMGZpcDt+oTw4rWkGJn11uY5blIoQqwS7ZvFmNo5/KBOlvAT7 M5uITg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctk8ugcsq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 14:13:09 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a0100410fso45489426d6.0 for ; Tue, 10 Mar 2026 07:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773151989; x=1773756789; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uj7lRluEZ+PijDD6FAfpyVAEjjvz57dxZpftGNLTZuE=; b=V3bBtZarZbRqEX9hnXKcoRrBppHMui3bTI3HHXdgKi965KjSS+Ef60b7vr7ZpkkdRS Oi90XkcFixZHK258vsRVPqHisXXHbxihhTswhQEkNvEtZPq3X2OTaOj+niO7O6mGb/zC HYkdcSamkiX4xMNSxNavyjkJvgDtaeFEMz5Mh9e/T579g+rP/N5uJiapjiSY/4Jp2hbv Bo+K1ngeI21iC8MRXcQQ5XbdxTYudcK94jpt2aB1xbQYAUmTXTjEWXhfkgnxtFvn/Q8G onQPGaTt/ZHe3eLHz3wp4KX0/5PCw96N/P3RLZe6NtjV17h5xDOpmEOG12z2fKR/r6Kt 0t0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773151989; x=1773756789; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uj7lRluEZ+PijDD6FAfpyVAEjjvz57dxZpftGNLTZuE=; b=dEAs/88HrZv484ALNpe7YgwMWPkJSDtpA/hC4094k6UOj+d++pIJEMg0Jk9ENcOdQ2 HZ611aDvsb4BWst5OGXVOy/whwqxwr5pCWSu+ZRhg4kEIJNPNMgAk3TIDnPezF5xNBOL 00yUo3zltHMIsSOXmGVaUlWgWGDUsYuS9EsCI5gVr6ve68SnTew4swXkRvcbw3pw2fM8 XLKkbzjcM/23vni1KNi3YNcxd8/AQ2ysvljqV9APlYe3LcF2U4n03pPZJSCT57jvTTxb hRTMkSLyPV2izxVicZSxzZPXLFBKuz5Ad7YNSBdjkdysIdSUqTt/Rkq8c8a5lID3j25Q m4RA== X-Forwarded-Encrypted: i=1; AJvYcCXYpZOPOPtUpz09quWe4tglkzORlMueYBLg8+prAfmj6e1/IIJpyIdWNKKsUCvanA8+bkrefWPwyQwuI28=@vger.kernel.org X-Gm-Message-State: AOJu0YwoeOEmryNT8lP7SU3pQSZnC/WRrtrWGdDIaM23EaEfUj/VwHCb QxonySYqsvZBboTN7DJ1FBIKk9ykwGZqaLcIJB+nB41h6rXXxihcUXbsceI51IyUjyPZGR0yPAo 94xINKTCaJXSKBgX9yi6nwDAzj+NoR/O01S0Fh9+6Eku1aFYHrEuUp4WqNMH5Sej6Ck8= X-Gm-Gg: ATEYQzz8HImF9JWQkDFIg7xR5uUhGr1C8jpU2oGeXd6MHG5MkCo2BXj/6b1jx7qmKJ0 wUaNo5nT617BjfFySjUY8mXEyJ4Jzr2f0TuwFQkpUh2K7/fCny3SRNhplZX/i3l0+FnlEkkWCm6 3ILfGDHiXg2Kv/KXi869dxoZaUVwI4izV4xLH/UOeTA5MZxXuUht1t/iH1GTr9rcxOaf8p6QU4+ HcBt+R7bU5J9ir+Wi0mXKBphiwdaP6Ja5OZckLEIRY93elxyWsrxpvFfCtIyfpLUz9EjijfY/4j eaa9z9LSVbznsK+VKIKx6tDXgXXz4sGtKAQ/jNjsLOMPnwkUHKMiBz4GpwzqK0Mk2NVnCGq2Khk JsORaoG2DfZT1mC3eS3bGO/EZVkx6DW/6lROE2pNjNNWbz21OXNle+Uo80IUCLpCsnh3KRYnbNi ZHtpw= X-Received: by 2002:a05:6214:6003:b0:89a:595c:b805 with SMTP id 6a1803df08f44-89a595cbf5emr30835556d6.6.1773151988462; Tue, 10 Mar 2026 07:13:08 -0700 (PDT) X-Received: by 2002:a05:6214:6003:b0:89a:595c:b805 with SMTP id 6a1803df08f44-89a595cbf5emr30834966d6.6.1773151987983; Tue, 10 Mar 2026 07:13:07 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942f15d51fsm493523966b.53.2026.03.10.07.13.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 07:13:07 -0700 (PDT) Message-ID: <91452d3f-fbbb-4960-b5e4-85efdc2c84e4@oss.qualcomm.com> Date: Tue, 10 Mar 2026 15:13:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/11] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-8-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-8-b9c2a5471d9e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: MLH6zayHeT-RMSvbLOS7DkAx_-iXT2PO X-Proofpoint-GUID: MLH6zayHeT-RMSvbLOS7DkAx_-iXT2PO X-Authority-Analysis: v=2.4 cv=YcmwJgRf c=1 sm=1 tr=0 ts=69b026f5 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=z_dnvKGLtVwtNw_c-ccA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEyNCBTYWx0ZWRfX+RzdyVGbiUhD kHJc09Mw/5XVYtthgZaIfcqCy2YXhQ1osaflFuA4ot+j0FYGKJjaow246DMAGsshiGQtVRKIkFP AlNHsbnM+JVfY5dlpcR/oCLF6QCHQnmIlIRzNWzi65a2rc6G79euT7aPR932S/pSNPpFL5iABbn rkolpN6YVBYBd0Ex+PGDHq0/RDruGdOdmfZs67RnvKXRiH3X6/PAIvAB+z1KvzRNfAorgmcCCtQ a04kSeZCFerLasnHw+3yv5APXXjj61Ko/s+J6WRDIBqTkUTtYtYKyDJyjhqc3bVydFT0M7dbxcV mKzHSn9PhEBhl5ldf2f2AIMdZ8AoG77av3khm9ZSjT7zoUfF2XaLCYYyl3f8JBJclqBKF/j+1FN qKVyLKNeNy+mxJ5NxJA9bIFrR7pKnrCSaSCiP/5Aq73H9VjtnELvJ4jCxEdfV18DDb6O3gnVFbb 7UuOsUW01GZFIu0nMfw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100124 On 3/10/26 9:06 AM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550. > > Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engine node") > Signed-off-by: Harshal Dev > --- Reviewed-by: Konrad Dybcio Konrad