From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 777582E3370 for ; Sat, 15 Mar 2025 00:49:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741999783; cv=none; b=ROU5qxXkubFLjNP5sxPIczTDRmSKdPuehXo1Glmap5SH0CN5dR2LD8heFvGtXE5DQI5mf3fADJrhqEV4hOqg8/ESepX1CfDmcV+fPlT5CmxIiFdyuOhgyGb0H8Alf/0Nm+GrqW+8tfzOSN8joyQTc48381HwdEnKAkN8idDdYlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741999783; c=relaxed/simple; bh=EVcLkRoYjzPskNvsgLUC1U6E5af0qrbR6gcf9LQ/UQM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hhYBTLyeFXGHPQ1jZyagIVHMS0r7aH2R7axQXqhc0hFx6PqXXsQLzzKVaIzwH9DT9Bevgfl5zJxYaIsEuI4Ayu7yiFLMh9Xb7CeXeM2UBOujUXTDoTEGEtGu8qsAKCco+Op1MO9SdFiI27tS/H6NCKYmoMYdBd+zPSvna/ygy7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ahpWgTdZ; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ahpWgTdZ" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22398e09e39so57618775ad.3 for ; Fri, 14 Mar 2025 17:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741999782; x=1742604582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D1jM8RpZtcKZIilOJqvJ3/LMYhzoydClew6e4ccobUM=; b=ahpWgTdZrxepaLdjwWi6FGIjFOmg2quhTaWPIl3GLik9D8p7eQC65Hwif+AMlp1T4H hrrQhXL1guNdjxHtbsp7pNBAuOxpQzkHTEyp5oXXeMp6Zdwr5LxHedxoneCBfeD2WFP+ 7W5EIJ/gQzsqwYfUx9528D6z/uZvEPhcXZ2OtaYoI8KTa1XA74QKUpUVQ1XhFDRRKBdY vZV+Ux1HrrD0ZIqrsrNtWa4NgujnTfc3r62Ic/lhmrhz+/d71EUZXDwk1sxn24WVdlQq moP8q4eIG0kPCrIZeCOLBwz6dAveCcy1/fzznRJFUXZroT03Q2OhQD8w/VsGcb5pdmqc GtcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741999782; x=1742604582; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D1jM8RpZtcKZIilOJqvJ3/LMYhzoydClew6e4ccobUM=; b=sqd22jPZqImRTbU9ENuI0DyzhadwDSqQJ8dxKU6JL7omeOsBaM2QUw/1WRlz4kld12 9xjoB0Fllfy9UmDQTo15e19vJpPTTdbWP++JFS80EllQya1OFFkSvtwWHfRj0aM8XEhI TdXfgALv+bpVvyrmxUNLO6oW/jwhtxYQHWEya547MyyQvmcD1gFPQuS1M/EQ845gfwBg IfbyS/a3WZVL7kyt8OU5J2Khqgs0FSUUlTp/ZUgeR0dS/I1UqB2JKYCgkGMGJ44vRi9d Dtc1LfbLpi/e/CNjotJgkoedUSNHJaH9f8red3erh3xkjYLqJON6z7/+4eBq+BgdLOTK zGEw== X-Forwarded-Encrypted: i=1; AJvYcCUm5MpJe3A1RLg0G9YI/efJ2bJsbrX0j0jpPnSxol9F+VoGD3H+Oe2MmRISvHTfMD6ESXTLoWzP4wLLoy4=@vger.kernel.org X-Gm-Message-State: AOJu0YwuM7x0+JznL0oOpgvy6qGJNgM8NxSRZAGx+pnNVei/GRVOwuOS hTjzipqb+G2RdLBBwxi14kN9JivVO1SFVhgSHSqIcH1EE0Ofvp2KUp4R8mRUMg== X-Gm-Gg: ASbGncvoDeF7SR+u+Dzy5raN9So1NNv6gZmzxK9Sr2HG7kRxr8tudmAcfBEXVbKsjJT FRsH0unmwkTHopHVZT6Hc/80BVO4IBGQtoEtdI6gydrYL2bm21C43rIyIKpHjprrK3SYnceREiC y/cXvBNEUS2lis3o12fzYvURSTAllcMRVKfEja83ul4+ounvJbDaXs6qlqP0S68N1zVRTCJT1bH +eVjw7paZqVtc8Iyb+4lED7ewrRr16YFuTFyTrZroElUPLrgUSG/Rkar5dA20NTibXE2MtvNsZw i9E6pVqqS7j7o7IcrmZ7VnrVsmJ7OQP4/ySrU8AFjKleqehRSuDGAdMNFCAUcputIJTYELhMCi7 bs8KIcWFAJCZFYwNOVOYpWJeRIT6MUo3Qgq6dNF02HBGDMaDzSgA1fg== X-Google-Smtp-Source: AGHT+IEmHc6dXkowj/KC6TLkI13gyY8Emlnd81lhhSStCWu+Bw/F/Vpl30+Ts5hmEGYnRZqPPjqDcw== X-Received: by 2002:a05:6a00:3d0c:b0:736:6151:c6ca with SMTP id d2e1a72fcca58-7372234b8f3mr5799632b3a.4.1741999781372; Fri, 14 Mar 2025 17:49:41 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e14:7:1790:6e62:92ba:cb2b? ([2a00:79e0:2e14:7:1790:6e62:92ba:cb2b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73711529397sm3501714b3a.22.2025.03.14.17.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 17:49:40 -0700 (PDT) Message-ID: <914a0df4-96d0-4cd4-ac87-3826fa9c1440@google.com> Date: Fri, 14 Mar 2025 17:49:38 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Badhri Jagan Sridharan , Sebastian Reichel , Heikki Krogerus , "Rafael J. Wysocki" , Len Brown , Pavel Machek , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, RD Babiera , Kyle Tso References: <20250312-batt_ops-v1-0-88e0bb3129fd@google.com> <20250313-determined-wild-seahorse-f7871a@krzk-bin> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <20250313-determined-wild-seahorse-f7871a@krzk-bin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Krzysztof, Thanks for the review! On 3/13/25 1:50 AM, Krzysztof Kozlowski wrote: > On Wed, Mar 12, 2025 at 04:42:00PM -0700, Amit Sunil Dhamne wrote: >> Support for Battery Status & Battery Caps messages in response to >> Get_Battery_Status & Get_Battery_Cap request is required by USB PD devices >> powered by battery, as per "USB PD R3.1 V1.8 Spec", "6.13 Message >> Applicability" section. This patchset adds support for these AMSes >> to achieve greater compliance with the spec. > Which board uses it? I would be happy to see that connection between > batteries and USB connector on the schematics of some real device. How > does it look like? Any board that uses a USB Type-C connector that supplies power into or out of a battery while operating in sink or source mode respectively. The VBUS is connected to the (battery + buck boost IC's CHGin/Vin) or a companion IFPMIC connected to a battery.  In our board we have USB Connector <-> IFPMIC <-> Battery. Thanks, Amit > Best regards, > Krzysztof >