From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C52C4167B for ; Tue, 28 Nov 2023 09:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234750AbjK1JRe (ORCPT ); Tue, 28 Nov 2023 04:17:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjK1JRc (ORCPT ); Tue, 28 Nov 2023 04:17:32 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85E0ACC for ; Tue, 28 Nov 2023 01:17:38 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50baa1ca01cso3991995e87.2 for ; Tue, 28 Nov 2023 01:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701163057; x=1701767857; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ylfSfQ4mfjwEGaFynXToMh7jz4SUakfDKeXenMXl9cg=; b=ejt0efqSpNASL1RIWI0a3ikuMq3LPDyM5XSTxcni+8KsrSD5SBHFPEMiIOJsE4kPGV Bc3mRD8+BPj971C/3EVotQA1Bzi0yR6Xs3qls6BZ2XB3jt6bWbpOEX1+rRu7CwLgmWro BJCRr/6Wa4O+SduehlGlrEL4hdAuDH0+Ee5ywaWpo8cmDeXf10KoWuHE9KLtQg7ZQPkJ boLHHZp1E4MtPnBO9iu5XINKxqdYRC4VJZRrjo+BucnaEW+gDtgjy+/GmndZ1SyG4SXb RElhPv+AnVQln1BjW8HfsMldqDeQrUHJxmGRvtu4g4toRb0S8GKWAzuJHvv8nvbff1bG mJIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701163057; x=1701767857; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ylfSfQ4mfjwEGaFynXToMh7jz4SUakfDKeXenMXl9cg=; b=jf28fVL+NGcDDRhFMzp7E7nbVxIUO5X1TUzDmFeky7Pn4pDwlxlcu/WRsQDkBRH66p Rmoh7cuvZ22oZR8xqwxinzOLuT39Nf6YzF2ItgohzogHBSPnw1CrvAsdb8SCyXSfrWTi g3uwxOUhaTBoG/jTarQuZv/Cma0YuqTs2dfVU3pVOHOEY86xLWM+id/xqVQizcLLhpSk gjA90NSTp+wgEzTokXNmScNk+iUNNFgRXG8dagCP7GPEm+ftAutzMHjjMcQKkanVVEIW u8xthGp8ijryVilrdkQanEgUnVPrVS5wTOsHX9Ialc0tfFqzh6/smwjPu1UHBnMEmcdX jp3A== X-Gm-Message-State: AOJu0Yye0P3oQTii9zPj6ZEjnGpU/gri4YCxnwZvsZ1dFEjPCcHcJoAD YPrfL6vYQsdW3hWgM8kmGyeG5Q== X-Google-Smtp-Source: AGHT+IHRTADxly8467HjYp8r8wxHjFPtlnNKCcz3bsTNTcTtKbZAyP0BXNsnz7Mbgg9vo8pUAFPSHQ== X-Received: by 2002:ac2:4194:0:b0:503:7dd:7ebd with SMTP id z20-20020ac24194000000b0050307dd7ebdmr5082877lfh.24.1701163056771; Tue, 28 Nov 2023 01:17:36 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id dn26-20020a05640222fa00b0054ba556eb97sm512568edb.97.2023.11.28.01.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 01:17:36 -0800 (PST) Message-ID: <91528bf4-c971-415e-afb4-51791c6dfc91@linaro.org> Date: Tue, 28 Nov 2023 10:17:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] ASoC: dt-bindings: document WCD939x Audio Codec Content-Language: en-US To: neil.armstrong@linaro.org, Srinivas Kandagatla , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231123-topic-sm8650-upstream-wcd939x-codec-v1-0-21d4ad9276de@linaro.org> <20231123-topic-sm8650-upstream-wcd939x-codec-v1-2-21d4ad9276de@linaro.org> <160fc6c4-b07d-49c5-976b-aa0fa35e4f0f@linaro.org> <60c9ba5d-a2b8-43cd-8b8d-2c709b8e5d04@linaro.org> <752f5347-703a-4b38-b2b1-3493d270389c@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <752f5347-703a-4b38-b2b1-3493d270389c@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/11/2023 10:14, neil.armstrong@linaro.org wrote: >> >> Here the device exposes its version in registers, so you can easily rely >> on the compatibility. That's also the case multiple times talked on the >> mailing lists. > > ... you're right here version can be determined at runtime. > > But, since both are compatible, there's no primary part number, right? > > so why use "qcom,wcd9395-codec", "qcom,wcd9390-codec" This one, please. > when "qcom,wcd9390-codec", "qcom,wcd9395-codec" should > also be valid, so in this can why not use : Could be valid, sure, but we are humans and we treat higher number as something newer or bigger, thus previous one feels more natural. There are examples of this way, though. > "qcom,wcd9390-codec", "qcom,wcd939x-codec" > or > "qcom,wcd9395-codec", "qcom,wcd939x-codec" This not, because wildcards are not allowed in the compatibles. In the past there were examples how a wildcard stopped being wild, so guideline is: just don't use them. Best regards, Krzysztof