From: Aidan Stewart <astewart@tektelic.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "jirislaby@kernel.org" <jirislaby@kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] serial: core: restore of_node information in sysfs
Date: Tue, 17 Jun 2025 15:46:37 +0000 [thread overview]
Message-ID: <915d0631ac123bbbb5d3fac1248b97d9de3295c6.camel@tektelic.com> (raw)
In-Reply-To: <2025061746-raking-gusto-d1f3@gregkh>
On Tue, 2025-06-17 at 06:44 +0200, Greg KH wrote:
>
> On Mon, Jun 16, 2025 at 10:21:54AM -0600, Aidan Stewart wrote:
> >
> >
> > + if (IS_ENABLED(CONFIG_OF)) {
> > + device_set_of_node_from_dev(dev, parent_dev);
> > + }
>
> Did this pass checkpatch.pl?
I ran checkpatch.pl with the --strict option and I didn't get any warnings
or errors. Is there a style issue you would like me to fix?
> And why is the if statement needed?
I guess it's not really needed. I was trying to avoid the call for non-DT
systems, but it should still be safe to do. I will remove it in v2.
> thanks,
>
> greg k-h
--
Thanks,
Aidan Stewart
next prev parent reply other threads:[~2025-06-17 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 16:21 Aidan Stewart
2025-06-17 4:44 ` Greg KH
2025-06-17 15:46 ` Aidan Stewart [this message]
2025-06-17 15:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=915d0631ac123bbbb5d3fac1248b97d9de3295c6.camel@tektelic.com \
--to=astewart@tektelic.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®