From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7952A2B9A6 for ; Fri, 24 Jan 2025 02:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737686627; cv=none; b=FL7Wai59pUZt/zb25e2VYbR9J9nzDKLVEa0aTdacdOTyE7nPAYws8HMT/lRJd4sHLXA+k0OEWnVPnUEqgOVYu8ZiUKgSjsSXHUw5bTqeT1UZpzwvMNz8fSQgpWFSXmLuxayu33vlhj/P9sLtCjHwHFbvo0p0nFFbYqPdujLJEe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737686627; c=relaxed/simple; bh=Ea+o5mgPPSi79LiVF7xWzlz2h/NOLdA8cwxcZo1z9Kc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O+92SSgJ55D4kOwfiNANDkRjYybWAQr7lj5e1d8fI51j/rOKGUEcyztDix4CIXq5Co5OakmIYz6FRu2zkvlVGaY/14Gpc/BDWdYwyTrLXESGZCMXavWNW7/m7WbUWCb9qs5meztD9QNimaVHPsa3UmBuM1t2gsDhR1jkQopfVjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=fIz+Hyk6; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="fIz+Hyk6" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2167141dfa1so30283545ad.1 for ; Thu, 23 Jan 2025 18:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1737686624; x=1738291424; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aAEVMfSL85K0Fb818rr6S6+agwwVsO1oxeV+co+SL/A=; b=fIz+Hyk6m7t29bE4DbRFZUw+hKsCgxCa5JX1afX6AP11WoUaOCQ2t0STLYq0oER0Iq Mutfe3yxEW3qWBq0fo1kqGazLLeSNF7U78/pQkndq97xjXON64IoZR3Pw2YtOoLQ0lRj CMgHij20x0zM47GU3fGLdU8zyr7LnMKvSGa+U0oqt82xtaP1cVxYvlDnI0P+v9ob7Og6 zWyFnYn82wu9ag9RdRxdIIYCcQrVe7EicqYZlejvqUxA1GjaZ6gSb5F2OaTQqtJOrK/3 +knDAIP9HGYTukDfP8QrfUGbjpestK50hmI4/n+vd6m6jfarIZ7HpAK7SDxKZ6gEnv38 3kcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737686624; x=1738291424; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aAEVMfSL85K0Fb818rr6S6+agwwVsO1oxeV+co+SL/A=; b=cOY8KMmSOO8Ye3eg2IjzLme7wzlw792iQhstGUrRnW0asLgZtl5LJu4JEc/R4PAj9O Wkk8nTiZo90K6mZ4ulW0EvmwmiOG2R0L/dvlV9WrIO0ttE4zkP+uZr+AUPnyyNObnxDI VYseajZP8Hi4mfHrZrpsP7xVrsh+2RYkStNRDGT9E7NS1YIyK5k56znyE+eiUWYqvLDN luY6xBHxSWjWjIyXEvSbyMxFrlLBoq+0gLupSYldND8Rfoe6csKQ9eQgG+a++9gu2iY+ TmBshq9GJHqKxsJ7GOnyIMFLd4aQqpD/fR0XYWKDLYplDG//rd54+IfQ/x5MrTM+NwP6 /aIg== X-Forwarded-Encrypted: i=1; AJvYcCXbYwmtSY1+rQv8QVNqaHQTs+VvyrGka0AwarLCGR4tkQn523BnAybL6HbVtxy0uu5E4K1EiDNTy7tFlEQ=@vger.kernel.org X-Gm-Message-State: AOJu0YycsGKG+HQWCZqexWBkcxbeBO+A+zPsZyXbXW24zWSCmuizRk0c zDSmlEtLApHv6bSeoe1qeiWJbGhZDGIRqH+29C8CyGiik/Moh5ZtiQJnRMf8B7M= X-Gm-Gg: ASbGnctLC67qXKd32z6Xo4I8ON1A3fORkaFu8kyPtItErvyyEMFe0hZ++a5e8wdMRoO HWW3k1aI96ODCjJtxK2bDKASOuSHsr8LlayV0d6fVDffsaBrKwoV0soNJrEIkuINbvcC81h4F/a ItD/hKk8Z4s1G3IAYws73L0gtDT/BBfhPfmRSZKzgTVUDrsCZA42U2+TwWt/zWU/Ju3iWvGs8Kv 6VFDPbS0fOwBw1g4YTYaFhhMc3WWonl+YNqFVbb5GCuwpHmSHp4fc083uis840wQubyqyNDfT+r hTgElSANkte/mtCtFd/hHnkyL0HIOA== X-Google-Smtp-Source: AGHT+IHTWa6ZCDsSKDB8q4F0CTBJysKJhjEmOkLroQcS07omC9+DalweP+QvYBIrAKMtnEtGr9eVNQ== X-Received: by 2002:a17:903:228f:b0:216:33f0:58d5 with SMTP id d9443c01a7336-21da4a9ddc2mr25531815ad.17.1737686624071; Thu, 23 Jan 2025 18:43:44 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da424f368sm5862405ad.257.2025.01.23.18.43.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 18:43:43 -0800 (PST) Message-ID: <915e19a9-204c-4a22-b132-6ae5fac3e270@bytedance.com> Date: Fri, 24 Jan 2025 10:43:38 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade To: Alexander Gordeev Cc: Kevin Brodsky , Gerald Schaefer , Heiko Carstens , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton References: <20250123160349.200154-1-agordeev@linux.ibm.com> Content-Language: en-US From: Qi Zheng In-Reply-To: <20250123160349.200154-1-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/1/24 00:03, Alexander Gordeev wrote: > Commit 78966b550289 ("s390: pgtable: add statistics for PUD and P4D > level page table") misses the call to pagetable_p4d_ctor() against > a newly allocated P4D table in crst_table_upgrade(); > > Commit 68c601de75d8 ("mm: introduce ctor/dtor at PGD level") misses > the call to pagetable_pgd_ctor() against a newly allocated PGD and > the call to pagetable_dtor() against a newly allocated P4D that is > about to be freed on crst_table_upgrade() PGD upgrade fail path. > > The missed constructors and destructor break (at least) the page > table accounting when a process memory space is upgraded. > > Reported-by: Heiko Carstens > Closes: https://lore.kernel.org/all/20250122074954.8685-A-hca@linux.ibm.com/ > Suggested-by: Heiko Carstens > Fixes: 78966b550289 ("s390: pgtable: add statistics for PUD and P4D level page table") > Fixes: 68c601de75d8 ("mm: introduce ctor/dtor at PGD level") > Signed-off-by: Alexander Gordeev > --- > The patch is against: > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git next-20250123 > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-stable > --- > arch/s390/mm/pgalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Qi Zheng Thanks!