From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbcHONZy (ORCPT ); Mon, 15 Aug 2016 09:25:54 -0400 Received: from mout.web.de ([212.227.15.14]:55105 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbcHONZw (ORCPT ); Mon, 15 Aug 2016 09:25:52 -0400 Subject: Re: backlight-tosa: Delete owner assignment To: Vegard Nossum References: Cc: linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Jingoo Han , Lee Jones , Tomi Valkeinen , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <916b664f-7818-18ca-445b-27413259ebef@users.sourceforge.net> Date: Mon, 15 Aug 2016 15:25:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2pE/pb4U7D7Rl7yMa6oTkG0GHIsQudGBu/SQ6u2yD9NGWOjtwUu DG2V48tFBLjbuF9iI0DLOm8alTklepfwO9U+FTGIU+Y08+L7/JLbFObrNEfjPiWkxKwLA4j 3Tvsa8c+m6Q0bPzrxWfUn1SSFbRI3AqvZMjvkGD2RLs9mBZ04pmauRPLRMAc4gQYrBF0O02 1VDiThlBzsxbVXCq2sR7w== X-UI-Out-Filterresults: notjunk:1;V01:K0:0PX+PG36pa4=:tbzYk1mG2edD9QjSeBXBjW SQBWGXOqdHnnRlacFqFdj5PVRgwhpq5owQd3nUQrcmIuWJpbL61uU4Bjgr4Yf34+ipEDA8lfr Rj5R9WZBzFgy/fw2SZVV6V3Kk8es1O8cJYmhr/XAp3nSWwDIG0qLNZ4PuOHhaWCyQ66skTfxq KX7y0NgxiJrTk/hY55h5ROagsrFwfMaEFLCTZXlTBVWsVZMPD6iPag234Aa4weGizKsxndIKh njM1qHQ4zI05OJqtk4c3U+fD/iI172xrBDqZxafs6oruOnUEWOV3iRGS1A+qIlcWJ8xjgx8Bm ccbJy4ESoq0bJyojRZgHWaGngrhtMCeGy/2HKcbRletx4Rv1hAJfmpxWMa4wN5OFabF3g8+qu qaJbZR5NZLaF5rY1x9n8W84T6h3XOD6vOd6VIpabChETZyeMYpMPbKyzYcBbfpEg/oqQ9uEfX IVoHUYV4DJCLpCVO1wqCqPAlcmzErZzB/ui0Z/WCCYtUnYApFsbD1Ap9YymfT6tnwcsdFOhQF dNDJpPyeNcI5+fQDRqRpkyBMMR9ye7E/ySMgEw7x9sAKrFL7sn8ZCxCRHyG7OMstYQDwjQJa9 sSw7hdR0iuRCWIZGa7IGbLEmQS+4K9IAmXnXPb643D6c6r/JWCqtnaqdUPpjQumSV3CbbqCEf qL+Q66OdpSoCA+sdbBUyOP6m042G7fKoMo8CcF0Unc/0kCzSG9qjc2N5ygNI+T4HsIZjp1+ql 5+utJmCEPcOBUmPd2BTe/YlQg7gVl10v7TNbupjqLl7eVG/1uQpOM7ZAua5gzhblPEDUNPj8Q FN9uuuA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The field "owner" is set by core. Thus delete an extra initialisation. > > Just a small nit on the patch title: "delete owner assignment" is > virtually useless as a title because it has no meaning without the > broader context and only describes the literal change. It's like > naming a patch "add a line" or "change the code"; > it serves no purpose. I have got an other impression. Do you want that I add any more background information to the commit message? > How about "backlight-tosa: delete _unnecessary_ assignment"? Will the underlined key word trigger any related software development concerns? Would another look be needed on how the usage of the mentioned data structure element was reduced over time? Regards, Markus