From: Quentin Lambert <lambert.quentin@gmail.com>
To: John Garry <john.garry@huawei.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree
Date: Mon, 21 Nov 2016 15:25:23 +0100 [thread overview]
Message-ID: <916d3638-f3a6-dedc-c89d-de368db0213b@gmail.com> (raw)
In-Reply-To: <aed62bfb-f26a-78de-8d8e-2b186b07d21f@huawei.com>
On 11/21/2016 03:16 PM, John Garry wrote:
> On 21/11/2016 13:20, Quentin Lambert wrote:
>>
>>
>> On 11/21/2016 01:53 PM, John Garry wrote:
>>> However I have noticed that we should do a call to hisi_sas_free() for
>>> this failure, and later failures in the probe.
>> I don't understand why, and would welcome the opportunity to learn
>> something.
>>
>
> We call hisi_sas_alloc() from hisi_sas_shost_alloc(); if we fail after
> this in hisi_sas_probe(), then we should free the memmories and
> workqueue got in hisi_sas_alloc(), which we don't.
Thanks.
Are you writing the patch or do you want me to do it?
Quentin
next prev parent reply other threads:[~2016-11-21 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 17:42 Quentin Lambert
2016-11-21 12:53 ` John Garry
2016-11-21 13:20 ` Quentin Lambert
2016-11-21 14:16 ` John Garry
2016-11-21 14:25 ` Quentin Lambert [this message]
2016-11-21 14:32 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=916d3638-f3a6-dedc-c89d-de368db0213b@gmail.com \
--to=lambert.quentin@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®