From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: Mike Rapoport <rppt@gmail.com>, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] sh: kprobes: remove unused variables in kprobe_exceptions_notify()
Date: Sat, 07 Jun 2025 15:10:14 +0200 [thread overview]
Message-ID: <916e98179181eebbfbfc2548a40a800e8c703525.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20250517093048.1149919-1-rppt@kernel.org>
Hi Mike,
On Sat, 2025-05-17 at 12:30 +0300, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> kbuild reports the following warning:
>
> arch/sh/kernel/kprobes.c: In function 'kprobe_exceptions_notify':
> > > arch/sh/kernel/kprobes.c:412:24: warning: variable 'p' set but not used [-Wunused-but-set-variable]
> 412 | struct kprobe *p = NULL;
> | ^
>
> The variable 'p' is indeed unused since the commit fa5a24b16f94
> ("sh/kprobes: Don't call the ->break_handler() in SH kprobes code")
>
> Remove that variable along with 'kprobe_opcode_t *addr' which also
> becomes unused after 'p' is removed.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505151341.EuRFR22l-lkp@intel.com/
> Fixes: fa5a24b16f94 ("sh/kprobes: Don't call the ->break_handler() in SH kprobes code")
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
>
> I don't know why the warning poped up only now, the code there didn't
> change for some time :/
>
> arch/sh/kernel/kprobes.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/sh/kernel/kprobes.c b/arch/sh/kernel/kprobes.c
> index 49c4ffd782d6..a250fb1b9420 100644
> --- a/arch/sh/kernel/kprobes.c
> +++ b/arch/sh/kernel/kprobes.c
> @@ -404,13 +404,10 @@ int __kprobes kprobe_fault_handler(struct pt_regs *regs, int trapnr)
> int __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> unsigned long val, void *data)
> {
> - struct kprobe *p = NULL;
> struct die_args *args = (struct die_args *)data;
> int ret = NOTIFY_DONE;
> - kprobe_opcode_t *addr = NULL;
> struct kprobe_ctlblk *kcb = get_kprobe_ctlblk();
>
> - addr = (kprobe_opcode_t *) (args->regs->pc);
> if (val == DIE_TRAP &&
> args->trapnr == (BREAKPOINT_INSTRUCTION & 0xff)) {
> if (!kprobe_running()) {
> @@ -421,7 +418,6 @@ int __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> ret = NOTIFY_DONE;
> }
> } else {
> - p = get_kprobe(addr);
> if ((kcb->kprobe_status == KPROBE_HIT_SS) ||
> (kcb->kprobe_status == KPROBE_REENTER)) {
> if (post_kprobe_handler(args->regs))
Thanks for catching this! Looks good to me!
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2025-06-07 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 9:30 Mike Rapoport
2025-05-19 8:48 ` Geert Uytterhoeven
2025-05-19 10:01 ` Mike Rapoport
2025-05-19 10:39 ` Geert Uytterhoeven
2025-06-07 13:10 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=916e98179181eebbfbfc2548a40a800e8c703525.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rppt@gmail.com \
--cc=rppt@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®