From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbeDPG1a (ORCPT ); Mon, 16 Apr 2018 02:27:30 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:58681 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016AbeDPG1X (ORCPT ); Mon, 16 Apr 2018 02:27:23 -0400 Subject: Re: [PATCH] ARM: dts: da850: use gpio-ranges To: David Lechner , Linus Walleij CC: Linux ARM , Kevin Hilman , Haojian Zhuang , Tony Lindgren , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" References: <1519079371-25493-1-git-send-email-david@lechnology.com> From: Sekhar Nori Message-ID: <917ac1f1-99a6-ac84-7486-ac97b0a617d8@ti.com> Date: Mon, 16 Apr 2018 11:55:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 April 2018 12:27 AM, David Lechner wrote: > On 02/23/2018 05:44 AM, Sekhar Nori wrote: >> On Thursday 22 February 2018 09:04 PM, Linus Walleij wrote: >>> On Mon, Feb 19, 2018 at 11:29 PM, David Lechner >>> wrote: >>> >>>> This makes use of the gpio-ranges feature that connects GPIO >>>> controllers and PINMUX controllers. >>>> >>>> In da850.dtsi, pinctrl-single,gpio-range is added to the pinmux node >>>> and gpio-ranges is added to the GPIO node. Unfortunately, the way the >>>> pinctrl-single driver enumerates the pins (starting with LSB) causes >>>> them to be in reverse order compared to the way the gpios are assigned. >>>> As a result, we have to declare the mapping for each GPIO individually. >>>> >>>> This also lets us remove all of the GPIO pinmuxes from >>>> da850-lego-ev3.dts. (Other da850 boards do not currently have any >>>> GPIO pinmuxes declared.) >>>> >>>> Signed-off-by: David Lechner >>> >>> Nice, >>> Acked-by: Linus Walleij >> >> Looks good to me too. And quite painstakingly done! >> >> I suppose this needs to wait a bit due to the dependencies? Let me know >> once its okay to merge. >> >> Thanks, >> Sekhar >> > > Hi Sekhar, > > The dependencies are in v4.17-rc1 so you can pick up this patch now. applied to v4.18/dt. I had to manually adjust the patch to make it apply, probably because it was based off your common clock conversion branch. Thanks, Sekhar