From: Li Nan <linan666@huaweicloud.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>, linan666@huaweicloud.com
Cc: song@kernel.org, neilb@suse.de, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v5 1/2] md/raid10: fix incorrect done of recovery
Date: Fri, 2 Jun 2023 14:57:46 +0800 [thread overview]
Message-ID: <917d7c23-eefc-efc5-1b12-949a684900bc@huaweicloud.com> (raw)
In-Reply-To: <2e36d874-4dd3-080c-3499-44f2f09b9169@molgen.mpg.de>
在 2023/6/1 15:06, Paul Menzel 写道:
> Dear Li,
>
>
> Thank you for your patch.
>
> Am 01.06.23 um 08:24 schrieb linan666@huaweicloud.com:
>> From: Li Nan <linan122@huawei.com>
>
> Unfortunately, I do not understand your commit message summary “fix
> incorrect done of recovery”. Maybe:
>
> Do not add sparse disk when recovery aborts
>
"recovery fail" is better?
>> In raid10_sync_request(), if data cannot be read from any disk for
>> recovery, it will go to 'giveup' and let 'chunks_skipped' + 1. After
>> multiple 'giveup', when 'chunks_skipped >= geo.raid_disks', it will
>> return 'max_sector', indicating that the recovery has been completed.
>> However, the recovery is just aborted and the data remains inconsistent.
>>
>> Fix it by setting mirror->recovery_disabled, which will prevent the spare
>> disk from being added to this mirror. The same issue also exists during
>> resync, it will be fixed afterwards.
>>
>> Signed-off-by: Li Nan <linan122@huawei.com>
>> ---
>> drivers/md/raid10.c | 18 +++++++++++++++++-
>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>> index d93d8cb2b620..3ba1516ea160 100644
>> --- a/drivers/md/raid10.c
>> +++ b/drivers/md/raid10.c
>> @@ -3303,6 +3303,7 @@ static sector_t raid10_sync_request(struct mddev
>> *mddev, sector_t sector_nr,
>> int chunks_skipped = 0;
>> sector_t chunk_mask = conf->geo.chunk_mask;
>> int page_idx = 0;
>> + int error_disk = -1;
>> /*
>> * Allow skipping a full rebuild for incremental assembly
>> @@ -3386,7 +3387,20 @@ static sector_t raid10_sync_request(struct
>> mddev *mddev, sector_t sector_nr,
>> return reshape_request(mddev, sector_nr, skipped);
>> if (chunks_skipped >= conf->geo.raid_disks) {
>> - /* if there has been nothing to do on any drive,
>> + pr_err("md/raid10:%s: %s fail\n", mdname(mddev),
>> + test_bit(MD_RECOVERY_SYNC, &mddev->recovery) ? "resync"
>> : "recovery");
>> + if (error_disk >= 0 &&
>> + !test_bit(MD_RECOVERY_SYNC, &mddev->recovery)) {
>> + /*
>> + * recovery fail, set mirrors.recovory_disabled,
>
> recov*e*ry
>
>> + * device shouldn't be added to there.
>> + */
>> + conf->mirrors[error_disk].recovery_disabled =
>> + mddev->recovery_disabled;
>> + return 0;
>> + }
>> + /*
>> + * if there has been nothing to do on any drive,
>> * then there is nothing to do at all..
>
> Just one dot/period at the end?
>
Thanks for your suggestion. I will change it in next version.
--
Thanks,
Nan
next prev parent reply other threads:[~2023-06-02 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 6:24 [PATCH v5 0/2] raid10 bugfix linan666
2023-06-01 6:24 ` [PATCH v5 1/2] md/raid10: fix incorrect done of recovery linan666
2023-06-01 7:06 ` Paul Menzel
2023-06-02 6:57 ` Li Nan [this message]
2023-06-02 8:33 ` Paul Menzel
2023-06-02 9:23 ` Li Nan
2023-06-01 6:24 ` [PATCH v5 2/2] md/raid10: fix io loss while replacement replace rdev linan666
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917d7c23-eefc-efc5-1b12-949a684900bc@huaweicloud.com \
--to=linan666@huaweicloud.com \
--cc=houtao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=pmenzel@molgen.mpg.de \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®